[kudu-CR] Block Bloom filter false positive rate correction

["Alexey Serbin (Code Review)" <ge...@cloudera.org>]

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16248 )

Change subject: Block Bloom filter false positive rate correction
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16248/10/src/kudu/util/block_bloom_filter.cc
File src/kudu/util/block_bloom_filter.cc:

http://gerrit.cloudera.org:8080/#/c/16248/10/src/kudu/util/block_bloom_filter.cc@296
PS10, Line 296: (candidate <= fpp)
Isn't it a typo?

I guess it should have been 'if (candidate > fpp)'.



-- 
To view, visit http://gerrit.cloudera.org:8080/16248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58a5191ee86edfa6e4f415829a6a647f586e9af6
Gerrit-Change-Number: 16248
Gerrit-PatchSet: 10
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 09 Sep 2020 19:34:22 +0000
Gerrit-HasComments: Yes