You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/09/21 17:41:27 UTC

[GitHub] [incubator-yunikorn-k8shim] craigcondit commented on pull request #304: [YUNIKORN-857] Add ENV var to disable gang scheduling.

craigcondit commented on pull request #304:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/304#issuecomment-924212549


   > the shim side manages all configs in `schedulerconfig.go`, using flags and loading from ENVs. Pls see our dockerfile: https://github.com/apache/incubator-yunikorn-k8shim/blob/master/deployments/image/configmap/Dockerfile, we want to use the same pattern to retrieve this ENV VAR as well. Please take a look.
   
   Updated PR with these changes.
   
   @yangwwei, can you re-approve workflow and review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org