You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/04/08 07:06:48 UTC
[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull
request #146: Fix binary partition values in Spark.
aokolnychyi commented on a change in pull request #146: Fix binary partition values in Spark.
URL: https://github.com/apache/incubator-iceberg/pull/146#discussion_r272908128
##########
File path: spark/src/test/java/org/apache/iceberg/spark/source/TestPartitionValues.java
##########
@@ -53,11 +62,28 @@
};
}
- private static final Schema SCHEMA = new Schema(
+ protected static final Schema SUPPORTED_PRIMITIVES = new Schema(
Review comment:
nit: Why protected? Do we expect `TestPartitionValues` to be extended and used in another package?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org