You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@jspwiki.apache.org by Juan Pablo Santos Rodríguez <ju...@gmail.com> on 2014/02/03 21:10:02 UTC
Re: Does jspwiki-wikipages need svn:ignore?
Hi Brian,
Regarding the '?' marked files I omit them on Eclipse through Window ->
Preferences -> Team -> Ignored resources and add "target", ".settings",
".project" and so on; that way I don't "see" them.
As for the 'M' ones, the install target should *not* have touched them.
Could you tell us which is the change introduced at jspwiki-wikipages/en? I
don't see that change on my local copy.
thanks,
juan pablo
On Fri, Jan 24, 2014 at 10:52 AM, Brian Burch <br...@pingtoo.com> wrote:
> I've recently started building and working with the trunk. I was preparing
> a patch and noticed several objects were flagged as modified when I haven't
> touched them.
>
> I did a fresh checkout but made no changes at all. After running "mvn
> clean install", here is what I see:
>
> brian@schizo:~/sandboxApache/jspwiki$ svn status
> M jspwiki-wikipages
> ? jspwiki-wikipages/de/target
> M jspwiki-wikipages/en
> ? jspwiki-wikipages/es/target
> ? jspwiki-wikipages/fi/target
> ? jspwiki-wikipages/fr/target
> ? jspwiki-wikipages/it/target
> ? jspwiki-wikipages/nl/target
> ? jspwiki-wikipages/pt_BR/target
> ? jspwiki-wikipages/zh_CN/target
> ? target
>
> Have I missed something, or is this just a case of missing svn:ignore
> properties, or if the pages really are committable, why is the install
> target touching these directories?
>
> Sorry to be picky!
>
> Brian
>
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Craig L Russell <cr...@oracle.com>.
On Feb 4, 2014, at 9:47 AM, Adrien Beau wrote:
> I agree with Brian; it is a common practice (and I think a best practice)
> to ignore the "target" directories at the SVN level.
+1
>
> After a clean checkout and a standard Maven build, there should be no file
> in an "unknown" SVN status.
+1
> Otherwise, there is a risk that someone will
> end up adding build artifacts to SVN.
For me, the bigger issue is that it's more difficult to see the changes among all the files/directories that should be ignored.
If you have your maven project set up correctly, you should only need one .svnignore at the root level, e.g. something like this:
clr% cat .svnignore
.project
.classpath
.settings
.externalToolBuilders
target
If it looks like you need several .svnignore files, perhaps the maven sub-projects are not properly set up with a parent.
Craig
>
> The other solutions (e.g. ignoring them at the IDE level) are not
> centralized, or require distributing IDE settings, which is not a good idea.
Craig L Russell
Architect, Oracle
http://db.apache.org/jdo
408 276-5638 mailto:Craig.Russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Adrien Beau <ad...@gmail.com>.
I agree with Brian; it is a common practice (and I think a best practice)
to ignore the "target" directories at the SVN level.
After a clean checkout and a standard Maven build, there should be no file
in an "unknown" SVN status. Otherwise, there is a risk that someone will
end up adding build artifacts to SVN.
The other solutions (e.g. ignoring them at the IDE level) are not
centralized, or require distributing IDE settings, which is not a good idea.
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Craig L Russell <cr...@oracle.com>.
I have to confess that svn is sometimes out of my reach, but here's a simple example [1].
At the trunk level of the jdo project there is an .svnignore containing target.
One level down (api), there is no .svnignore but there is a target.
The target directory has svn status of "I", which means ignored.
I always assumed that .svnignore was applied recursively. I don't know how it works. Maybe I'm using an old out-of-date version of svn (August 2013).
Craig
[1] [CraigRussell-3:~/apache/jdo/trunk] clr% ls -a
. enhancer20
.. exectck
.DS_Store getProperties.patch
.classpath jdo-655.patch
.project jdo623.patch
.settings jdo_checks.xml
.svnignore lib
FetchGroup Lifecycle.JPG model20
LICENSE.txt parent-pom
NOTICE.txt pom.xml
README.html query.ser
api query20
api2-legacy specification
btree tck
copyjdorijars tck.txt
[CraigRussell-3:~/apache/jdo/trunk] clr% cat .svnignore
.project
.classpath
.settings
.externalToolBuilders
target
[CraigRussell-3:~/apache/jdo/trunk] clr% cd api
[CraigRussell-3:jdo/trunk/api] clr% ls
nbactions.xml pom.xml target
pmfservice.patch src test
[CraigRussell-3:jdo/trunk/api] clr% ls -a
. .project pom.xml
.. .settings src
.DS_Store nbactions.xml target
.classpath pmfservice.patch test
[CraigRussell-3:jdo/trunk/api] clr% svn st
? nbactions.xml
? src/java/javax/jdo/PersistenceManagerFactoryService.java
M src/java/javax/jdo/spi/JDOImplHelper.java
[CraigRussell-3:jdo/trunk/api] clr% svn st target/
I target
[CraigRussell-3:jdo/trunk/api] clr% svn --version
svn, version 1.8.3 (r1516576)
compiled Aug 26 2013, 09:38:58 on i386-apple-darwin10.8.0
On Feb 5, 2014, at 4:59 AM, Brian Burch wrote:
> On 05/02/14 09:27, Juan Pablo Santos Rodríguez wrote:
>> Hi,
>>
>> svn propset / propedit should be enough, see
>> http://anilsaldhana.blogspot.com.es/2008/09/recursively-ignore-target-directory-in.htmlfor
>> an example
>
> I haven't followed your link, but all I can say is the syntax for multiple targets of an svn property is tricky.
>
> Here are some simple cases that worked for me:
>
> brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages$ svn propset svn:ignore 'target' .
> property 'svn:ignore' set on '.'
> brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages$ svn --verbose proplist .
> Properties on '.':
> svn:ignore
> target
>
> and
>
> brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages$ cd de
> brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages/de$ svn propset svn:ignore 'target' .
> property 'svn:ignore' set on '.'
> brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages/de$ svn --verbose proplist .
> Properties on '.':
> svn:ignore
> target
>
> leaving me with
>
> brian@schizo:~/sandboxApache/jspwiki_2_10_0$ svn status
> M .
> M jspwiki-wikipages
> M jspwiki-wikipages/de
> ? jspwiki-wikipages/en/target
> ? jspwiki-wikipages/es/target
> ? jspwiki-wikipages/fi/target
> ? jspwiki-wikipages/fr/target
> ? jspwiki-wikipages/it/target
> ? jspwiki-wikipages/nl/target
> ? jspwiki-wikipages/pt_BR/target
> ? jspwiki-wikipages/zh_CN/target
>
>> if nobody does it before, I'll do it tonight for target .settings,
>> .classpath and .project (for other files/folders, now would be the right
>> time to ask for it)
>
> I noticed tomcat root properties defines svn:ignore for ".*". If you used this valid wildcard form, it would allow you to remove ".project".
>
> Craig suggested there was a way to define svn properties ONLY in the top-level project and have them inherited by sub-projects. Perhaps he can explain, because I don't know how to do that.
>
> The svn redbook states "The property is set on the directory in which you wish the patterns to be applied. 29" and footnote 29 states "The patterns are strictly for that directory—they do not carry recursively into subdirectories." If there is way to achieve recursion, it must be some kind of maven magic.
>
> Tomcat also ignores "nbproject", which is a subdirectory created by netbeans. However, now that jspwiki has been converted to a maven project, it appears that netbeans does not need this directory. (My old jspwiki 2.8.4 project sandbox used ant and it contains an nbproject sub-directory).
>
> The sub-project jspwiki-war has a root svn:ignore for ".classpath", but not for ".project". We either need Craig's trick, or ".*" in this project too.
>
> I hope my comments can avoid some frustration with the change!
>
> Good luck,
>
> Brian
>
>> br,
>> juan pablo
>>
>>
>> On Wed, Feb 5, 2014 at 9:54 AM, Harry Metske <ha...@gmail.com> wrote:
>>
>>> Brian,
>>>
>>> if you could reply the required svn commands for all the resources
>>> requiring the svn properties , that would be fine.
>>>
>>> regards,
>>> Harry
>>>
>>>
>>>
>>> On 5 February 2014 09:07, Brian Burch <br...@pingtoo.com> wrote:
>>>
>>>> On 04/02/14 22:14, Juan Pablo Santos Rodríguez wrote:
>>>>
>>>>> Hi Brian,
>>>>>
>>>>> apologies if I sounded harsh, that was definitely not my intention.
>>>>>
>>>>
>>>> No, I never thought you were! Nor was I offended.
>>>>
>>>>
>>>> Got a
>>>>> bunch of mails and went answering through them as quick and concise as
>>>>> possible, didn't mean to be picky in any way.
>>>>>
>>>>
>>>> I understand you have been under a lot of pressure to get the project
>>>> converted and stabilised. I appreciate all your efforts and help.
>>>>
>>>>
>>>> Regarding the missing
>>>>> svn:ignore, as I was used to my workspace I didn't gave too much
>>> attention
>>>>> to this issue, but will look into it as soon as I'm able to.
>>>>>
>>>>
>>>> It is quite a trivial change. I could do it in a few minutes with either
>>>> netbeans, or from a command line - I don't use eclipse. The svn diff I
>>>> supplied doesn't help with /how/ to do the change.
>>>>
>>>> If it would help, I could send you the svn commands to make the change?
>>> It
>>>> isn't keeping me up at night, but seems like low hanging fruit that could
>>>> be taken out quickly.
>>>>
>>>> Regards,
>>>>
>>>> Brian
>>>>
>>>>
>>>> br,
>>>>> juan pablo
>>>>>
>>>>>
>>>>> On Tue, Feb 4, 2014 at 4:33 PM, Brian Burch <br...@pingtoo.com> wrote:
>>>>>
>>>>> On 03/02/14 20:10, Juan Pablo Santos Rodríguez wrote:
>>>>>>
>>>>>> Hi Brian,
>>>>>>>
>>>>>>> Regarding the '?' marked files I omit them on Eclipse through Window
>>> ->
>>>>>>> Preferences -> Team -> Ignored resources and add "target",
>>> ".settings",
>>>>>>> ".project" and so on; that way I don't "see" them.
>>>>>>>
>>>>>>>
>>>>>> Please don't think I am being picky! The project is has now changed
>>>>>> "home"
>>>>>> twice in a short time, so now it has full and permanent status under
>>>>>> apache, it makes sense to clean up the loose ends quickly - before we
>>> all
>>>>>> get used to ignoring them!
>>>>>>
>>>>>> Your answer is a bit ostrich-like! Just 'cos you don't see them, it
>>>>>> doesn't mean everyone else can't either!
>>>>>>
>>>>>> I have just done another virgin "svn checkout" of 2.10.0 at r1564324,
>>>>>> "svn
>>>>>> --verbose proplist ." shows:
>>>>>>
>>>>>> Properties on '.':
>>>>>> svn:ignore
>>>>>> .project
>>>>>>
>>>>>>
>>>>>> I added "target" to the project root svn:ignore property, and here is
>>> the
>>>>>> diff:
>>>>>>
>>>>>> Index: .
>>>>>> ===================================================================
>>>>>> --- . (revision 1564343)
>>>>>> +++ . (working copy)
>>>>>>
>>>>>> Property changes on: .
>>>>>> ___________________________________________________________________
>>>>>> Modified: svn:ignore
>>>>>> ## -1 +1,2 ##
>>>>>> .project
>>>>>> +target
>>>>>>
>>>>>> svn does not need a trailing slash for a directory.
>>>>>>
>>>>>>
>>>>>> As for the 'M' ones, the install target should *not* have touched
>>> them.
>>>>>>
>>>>>>> Could you tell us which is the change introduced at
>>>>>>> jspwiki-wikipages/en?
>>>>>>> I
>>>>>>> don't see that change on my local copy.
>>>>>>>
>>>>>>>
>>>>>> I now see:
>>>>>>
>>>>>> brian@schizo:~/sandboxApache/jspwiki_2_10_0$ svn status
>>>>>> M .
>>>>>> ? jspwiki-wikipages/de/target
>>>>>> ? jspwiki-wikipages/en/target
>>>>>>
>>>>>> ? jspwiki-wikipages/es/target
>>>>>> ? jspwiki-wikipages/fi/target
>>>>>> ? jspwiki-wikipages/fr/target
>>>>>> ? jspwiki-wikipages/it/target
>>>>>> ? jspwiki-wikipages/nl/target
>>>>>> ? jspwiki-wikipages/pt_BR/target
>>>>>> ? jspwiki-wikipages/target
>>>>>> ? jspwiki-wikipages/zh_CN/target
>>>>>>
>>>>>> I think you need to add svn:ignore properties on each of these
>>> individual
>>>>>> "targets" within the jspwiki-wikipages sub-project - I can't see how to
>>>>>> do
>>>>>> the same thing using wildcards.
>>>>>>
>>>>>> I hope this is helpful?
>>>>>>
>>>>>> Brian
>>>>>>
>>>>>>
>>>>>> thanks,
>>>>>>
>>>>>>> juan pablo
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Jan 24, 2014 at 10:52 AM, Brian Burch <br...@pingtoo.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>> I've recently started building and working with the trunk. I was
>>>>>>>
>>>>>>>> preparing
>>>>>>>> a patch and noticed several objects were flagged as modified when I
>>>>>>>> haven't
>>>>>>>> touched them.
>>>>>>>>
>>>>>>>> I did a fresh checkout but made no changes at all. After running "mvn
>>>>>>>> clean install", here is what I see:
>>>>>>>>
>>>>>>>> brian@schizo:~/sandboxApache/jspwiki$ svn status
>>>>>>>> M jspwiki-wikipages
>>>>>>>> ? jspwiki-wikipages/de/target
>>>>>>>> M jspwiki-wikipages/en
>>>>>>>> ? jspwiki-wikipages/es/target
>>>>>>>> ? jspwiki-wikipages/fi/target
>>>>>>>> ? jspwiki-wikipages/fr/target
>>>>>>>> ? jspwiki-wikipages/it/target
>>>>>>>> ? jspwiki-wikipages/nl/target
>>>>>>>> ? jspwiki-wikipages/pt_BR/target
>>>>>>>> ? jspwiki-wikipages/zh_CN/target
>>>>>>>> ? target
>>>>>>>>
>>>>>>>> Have I missed something, or is this just a case of missing svn:ignore
>>>>>>>> properties, or if the pages really are committable, why is the
>>> install
>>>>>>>> target touching these directories?
>>>>>>>>
>>>>>>>> Sorry to be picky!
>>>>>>>>
>>>>>>>> Brian
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
Craig L Russell
Architect, Oracle
http://db.apache.org/jdo
408 276-5638 mailto:Craig.Russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi,
finally went with adding an .svnignore file, after which:
svn propset svn:ignore --depth=immediates -F .svnignore .
svn propset svn:ignore --depth=immediates -F .svnignore jspwiki-it-tests
svn propset svn:ignore --depth=immediates -F .svnignore jspwiki-wikipages
to avoid setting the svn:ignore property on every subfolder under every
src. This way we also have an easy option to repeat (in case we add new
modules) the commands or if we want to add new exclusions
br,
juan pablo
On Wed, Feb 5, 2014 at 1:59 PM, Brian Burch <br...@pingtoo.com> wrote:
> On 05/02/14 09:27, Juan Pablo Santos Rodríguez wrote:
>
>> Hi,
>>
>> svn propset / propedit should be enough, see
>> http://anilsaldhana.blogspot.com.es/2008/09/recursively-
>> ignore-target-directory-in.htmlfor
>> an example
>>
>
> I haven't followed your link, but all I can say is the syntax for multiple
> targets of an svn property is tricky.
>
> Here are some simple cases that worked for me:
>
> brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages$ svn
> propset svn:ignore 'target' .
> property 'svn:ignore' set on '.'
> brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages$ svn
> --verbose proplist .
>
> Properties on '.':
> svn:ignore
> target
>
> and
>
> brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages$ cd de
> brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages/de$ svn
> propset svn:ignore 'target' .
> property 'svn:ignore' set on '.'
> brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages/de$ svn
> --verbose proplist .
>
> Properties on '.':
> svn:ignore
> target
>
> leaving me with
>
>
> brian@schizo:~/sandboxApache/jspwiki_2_10_0$ svn status
> M .
> M jspwiki-wikipages
> M jspwiki-wikipages/de
>
> ? jspwiki-wikipages/en/target
> ? jspwiki-wikipages/es/target
> ? jspwiki-wikipages/fi/target
> ? jspwiki-wikipages/fr/target
> ? jspwiki-wikipages/it/target
> ? jspwiki-wikipages/nl/target
> ? jspwiki-wikipages/pt_BR/target
> ? jspwiki-wikipages/zh_CN/target
>
>
> if nobody does it before, I'll do it tonight for target .settings,
>> .classpath and .project (for other files/folders, now would be the right
>> time to ask for it)
>>
>
> I noticed tomcat root properties defines svn:ignore for ".*". If you used
> this valid wildcard form, it would allow you to remove ".project".
>
> Craig suggested there was a way to define svn properties ONLY in the
> top-level project and have them inherited by sub-projects. Perhaps he can
> explain, because I don't know how to do that.
>
> The svn redbook states "The property is set on the directory in which you
> wish the patterns to be applied. 29" and footnote 29 states "The patterns
> are strictly for that directory—they do not carry recursively into
> subdirectories." If there is way to achieve recursion, it must be some kind
> of maven magic.
>
> Tomcat also ignores "nbproject", which is a subdirectory created by
> netbeans. However, now that jspwiki has been converted to a maven project,
> it appears that netbeans does not need this directory. (My old jspwiki
> 2.8.4 project sandbox used ant and it contains an nbproject sub-directory).
>
> The sub-project jspwiki-war has a root svn:ignore for ".classpath", but
> not for ".project". We either need Craig's trick, or ".*" in this project
> too.
>
> I hope my comments can avoid some frustration with the change!
>
> Good luck,
>
>
> Brian
>
> br,
>> juan pablo
>>
>>
>> On Wed, Feb 5, 2014 at 9:54 AM, Harry Metske <ha...@gmail.com>
>> wrote:
>>
>> Brian,
>>>
>>> if you could reply the required svn commands for all the resources
>>> requiring the svn properties , that would be fine.
>>>
>>> regards,
>>> Harry
>>>
>>>
>>>
>>> On 5 February 2014 09:07, Brian Burch <br...@pingtoo.com> wrote:
>>>
>>> On 04/02/14 22:14, Juan Pablo Santos Rodríguez wrote:
>>>>
>>>> Hi Brian,
>>>>>
>>>>> apologies if I sounded harsh, that was definitely not my intention.
>>>>>
>>>>>
>>>> No, I never thought you were! Nor was I offended.
>>>>
>>>>
>>>> Got a
>>>>
>>>>> bunch of mails and went answering through them as quick and concise as
>>>>> possible, didn't mean to be picky in any way.
>>>>>
>>>>>
>>>> I understand you have been under a lot of pressure to get the project
>>>> converted and stabilised. I appreciate all your efforts and help.
>>>>
>>>>
>>>> Regarding the missing
>>>>
>>>>> svn:ignore, as I was used to my workspace I didn't gave too much
>>>>>
>>>> attention
>>>
>>>> to this issue, but will look into it as soon as I'm able to.
>>>>>
>>>>>
>>>> It is quite a trivial change. I could do it in a few minutes with either
>>>> netbeans, or from a command line - I don't use eclipse. The svn diff I
>>>> supplied doesn't help with /how/ to do the change.
>>>>
>>>> If it would help, I could send you the svn commands to make the change?
>>>>
>>> It
>>>
>>>> isn't keeping me up at night, but seems like low hanging fruit that
>>>> could
>>>> be taken out quickly.
>>>>
>>>> Regards,
>>>>
>>>> Brian
>>>>
>>>>
>>>> br,
>>>>
>>>>> juan pablo
>>>>>
>>>>>
>>>>> On Tue, Feb 4, 2014 at 4:33 PM, Brian Burch <br...@pingtoo.com> wrote:
>>>>>
>>>>> On 03/02/14 20:10, Juan Pablo Santos Rodríguez wrote:
>>>>>
>>>>>>
>>>>>> Hi Brian,
>>>>>>
>>>>>>>
>>>>>>> Regarding the '?' marked files I omit them on Eclipse through Window
>>>>>>>
>>>>>> ->
>>>
>>>> Preferences -> Team -> Ignored resources and add "target",
>>>>>>>
>>>>>> ".settings",
>>>
>>>> ".project" and so on; that way I don't "see" them.
>>>>>>>
>>>>>>>
>>>>>>> Please don't think I am being picky! The project is has now changed
>>>>>> "home"
>>>>>> twice in a short time, so now it has full and permanent status under
>>>>>> apache, it makes sense to clean up the loose ends quickly - before we
>>>>>>
>>>>> all
>>>
>>>> get used to ignoring them!
>>>>>>
>>>>>> Your answer is a bit ostrich-like! Just 'cos you don't see them, it
>>>>>> doesn't mean everyone else can't either!
>>>>>>
>>>>>> I have just done another virgin "svn checkout" of 2.10.0 at r1564324,
>>>>>> "svn
>>>>>> --verbose proplist ." shows:
>>>>>>
>>>>>> Properties on '.':
>>>>>> svn:ignore
>>>>>> .project
>>>>>>
>>>>>>
>>>>>> I added "target" to the project root svn:ignore property, and here is
>>>>>>
>>>>> the
>>>
>>>> diff:
>>>>>>
>>>>>> Index: .
>>>>>> ===================================================================
>>>>>> --- . (revision 1564343)
>>>>>> +++ . (working copy)
>>>>>>
>>>>>> Property changes on: .
>>>>>> ___________________________________________________________________
>>>>>> Modified: svn:ignore
>>>>>> ## -1 +1,2 ##
>>>>>> .project
>>>>>> +target
>>>>>>
>>>>>> svn does not need a trailing slash for a directory.
>>>>>>
>>>>>>
>>>>>> As for the 'M' ones, the install target should *not* have touched
>>>>>>
>>>>> them.
>>>
>>>>
>>>>>> Could you tell us which is the change introduced at
>>>>>>> jspwiki-wikipages/en?
>>>>>>> I
>>>>>>> don't see that change on my local copy.
>>>>>>>
>>>>>>>
>>>>>>> I now see:
>>>>>>
>>>>>> brian@schizo:~/sandboxApache/jspwiki_2_10_0$ svn status
>>>>>> M .
>>>>>> ? jspwiki-wikipages/de/target
>>>>>> ? jspwiki-wikipages/en/target
>>>>>>
>>>>>> ? jspwiki-wikipages/es/target
>>>>>> ? jspwiki-wikipages/fi/target
>>>>>> ? jspwiki-wikipages/fr/target
>>>>>> ? jspwiki-wikipages/it/target
>>>>>> ? jspwiki-wikipages/nl/target
>>>>>> ? jspwiki-wikipages/pt_BR/target
>>>>>> ? jspwiki-wikipages/target
>>>>>> ? jspwiki-wikipages/zh_CN/target
>>>>>>
>>>>>> I think you need to add svn:ignore properties on each of these
>>>>>>
>>>>> individual
>>>
>>>> "targets" within the jspwiki-wikipages sub-project - I can't see how to
>>>>>> do
>>>>>> the same thing using wildcards.
>>>>>>
>>>>>> I hope this is helpful?
>>>>>>
>>>>>> Brian
>>>>>>
>>>>>>
>>>>>> thanks,
>>>>>>
>>>>>> juan pablo
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Jan 24, 2014 at 10:52 AM, Brian Burch <br...@pingtoo.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>> I've recently started building and working with the trunk. I was
>>>>>>>
>>>>>>> preparing
>>>>>>>> a patch and noticed several objects were flagged as modified when I
>>>>>>>> haven't
>>>>>>>> touched them.
>>>>>>>>
>>>>>>>> I did a fresh checkout but made no changes at all. After running
>>>>>>>> "mvn
>>>>>>>> clean install", here is what I see:
>>>>>>>>
>>>>>>>> brian@schizo:~/sandboxApache/jspwiki$ svn status
>>>>>>>> M jspwiki-wikipages
>>>>>>>> ? jspwiki-wikipages/de/target
>>>>>>>> M jspwiki-wikipages/en
>>>>>>>> ? jspwiki-wikipages/es/target
>>>>>>>> ? jspwiki-wikipages/fi/target
>>>>>>>> ? jspwiki-wikipages/fr/target
>>>>>>>> ? jspwiki-wikipages/it/target
>>>>>>>> ? jspwiki-wikipages/nl/target
>>>>>>>> ? jspwiki-wikipages/pt_BR/target
>>>>>>>> ? jspwiki-wikipages/zh_CN/target
>>>>>>>> ? target
>>>>>>>>
>>>>>>>> Have I missed something, or is this just a case of missing
>>>>>>>> svn:ignore
>>>>>>>> properties, or if the pages really are committable, why is the
>>>>>>>>
>>>>>>> install
>>>
>>>> target touching these directories?
>>>>>>>>
>>>>>>>> Sorry to be picky!
>>>>>>>>
>>>>>>>> Brian
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Brian Burch <br...@pingtoo.com>.
On 12/02/14 17:01, Juan Pablo Santos Rodríguez wrote:
> Hi,
>
> that file is generated as part of the unit tests, but as for current trunk
> shouldn't be there anymore, cfr with
> $SVN/jspwiki-war/src/test/resources/jspwiki-custom.properties. Same
> happened with jspwiki.log, which should be inside ./target
>
> Most probably, that file is there because of previous executions. Would you
> mind deleting it and compile again to ensure that this file only gets
> generated inside .jspwiki-war/target ?
Yes, that did the trick. At revision 1567757 the file is no longer
created when the tests are run.
By the way, the new patch I submitted to fix JIRA 814 failed at the
latest svn revision. The messages refer to jspwiki.properties, so I need
to investigate tomorrow.
Brian
> thanks + br,
> juan pablo
>
>
>
> On Wed, Feb 12, 2014 at 5:54 PM, Brian Burch <br...@pingtoo.com> wrote:
>
>> On 11/02/14 23:21, Juan Pablo Santos Rodríguez wrote:
>>
>>> Hi Brian,
>>>
>>> included the new file on .svnignore and applied svn propset svn:ignore..
>>> on
>>> 2.10.1-svn-4 (current trunk)
>>>
>>
>> Thanks, Juan Pablo,
>>
>> the trunk is looking a lot cleaner after your changes.
>>
>> However, can you explain this recent arrival?
>>
>> brian@schizo:~/sandboxApache/jspwiki$ svn status
>> ? jspwiki-war/rss.rdf
>>
>> and
>>
>> brian@schizo:~/sandboxApache/jspwiki$ cat jspwiki-war/rss.rdf
>> <?xml version="1.0" encoding="UTF-8"?>
>> <rdf:RDF xmlns:dc='http://purl.org/dc/elements/1.1/' xmlns:wiki='
>> http://purl.org/rss/1.0/modules/wiki/' xmlns='http://purl.org/rss/1.0/'
>> xmlns:rdf='http://www.w3.org/1999/02/22-rdf-syntax-ns#'>
>> <channel rdf:about='http://localhost/'><link>http://localhost/</link>
>> <title>JSPWiki</title><description>Oh poor me, my owner has not set a
>> channel description at all. Pity me.</description><dc:language>
>> en-us</dc:language><items><rdf:Seq></rdf:Seq></items></channel>
>>
>> I don't think it is anything I've done... should the file be committed, or
>> ignored?
>>
>> Best wishes,
>>
>> Brian
>>
>>
>> br,
>>> juan pablo
>>>
>>>
>>>
>>> On Tue, Feb 11, 2014 at 12:08 PM, Brian Burch <br...@pingtoo.com> wrote:
>>>
>>> Oops! I was wrong about netbeans! (see inline)
>>>>
>>>> On 05/02/14 12:59, Brian Burch wrote:
>>>> <snip/>
>>>>
>>>> Tomcat also ignores "nbproject", which is a subdirectory created by
>>>>
>>>>> netbeans. However, now that jspwiki has been converted to a maven
>>>>> project, it appears that netbeans does not need this directory. (My old
>>>>> jspwiki 2.8.4 project sandbox used ant and it contains an nbproject
>>>>> sub-directory).
>>>>>
>>>>>
>>>> I changed a netbeans project property and subsequently noticed a new file
>>>> was created:
>>>>
>>>> jspwiki-war/nb-configuration.xml
>>>>
>>>> It seems to me netbeans would use this single file to hold /any/ local
>>>> configuration properties for a particular maven project. Given the main
>>>> and
>>>> all three jspwiki-* sub-projects might possibly qualify for local
>>>> changes,
>>>> I suggest you add this specific filename to the svnignore.
>>>>
>>>> Sorry to keep referring to tomcat's ant project, but it carries a lot of
>>>> useful battle scars. If, at some time in the future, we decide it would
>>>> be
>>>> useful to maintain /recommended/ versions of project files for different
>>>> IDEs, we could create a separate directory where they can be committed,
>>>> but
>>>> will not automatically become active. There is probably a maven way to
>>>> achieve this (rather than apeing tomcat), but we can worry about that
>>>> if/when the need arises.
>>>>
>>>> I don't think this change merits opening a new JIRA.
>>>>
>>>> Regards,
>>>>
>>>> Brian
>>>>
>>>>
>>>>
>>>
>>
>
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi,
that file is generated as part of the unit tests, but as for current trunk
shouldn't be there anymore, cfr with
$SVN/jspwiki-war/src/test/resources/jspwiki-custom.properties. Same
happened with jspwiki.log, which should be inside ./target
Most probably, that file is there because of previous executions. Would you
mind deleting it and compile again to ensure that this file only gets
generated inside .jspwiki-war/target ?
thanks + br,
juan pablo
On Wed, Feb 12, 2014 at 5:54 PM, Brian Burch <br...@pingtoo.com> wrote:
> On 11/02/14 23:21, Juan Pablo Santos Rodríguez wrote:
>
>> Hi Brian,
>>
>> included the new file on .svnignore and applied svn propset svn:ignore..
>> on
>> 2.10.1-svn-4 (current trunk)
>>
>
> Thanks, Juan Pablo,
>
> the trunk is looking a lot cleaner after your changes.
>
> However, can you explain this recent arrival?
>
> brian@schizo:~/sandboxApache/jspwiki$ svn status
> ? jspwiki-war/rss.rdf
>
> and
>
> brian@schizo:~/sandboxApache/jspwiki$ cat jspwiki-war/rss.rdf
> <?xml version="1.0" encoding="UTF-8"?>
> <rdf:RDF xmlns:dc='http://purl.org/dc/elements/1.1/' xmlns:wiki='
> http://purl.org/rss/1.0/modules/wiki/' xmlns='http://purl.org/rss/1.0/'
> xmlns:rdf='http://www.w3.org/1999/02/22-rdf-syntax-ns#'>
> <channel rdf:about='http://localhost/'><link>http://localhost/</link>
> <title>JSPWiki</title><description>Oh poor me, my owner has not set a
> channel description at all. Pity me.</description><dc:language>
> en-us</dc:language><items><rdf:Seq></rdf:Seq></items></channel>
>
> I don't think it is anything I've done... should the file be committed, or
> ignored?
>
> Best wishes,
>
> Brian
>
>
> br,
>> juan pablo
>>
>>
>>
>> On Tue, Feb 11, 2014 at 12:08 PM, Brian Burch <br...@pingtoo.com> wrote:
>>
>> Oops! I was wrong about netbeans! (see inline)
>>>
>>> On 05/02/14 12:59, Brian Burch wrote:
>>> <snip/>
>>>
>>> Tomcat also ignores "nbproject", which is a subdirectory created by
>>>
>>>> netbeans. However, now that jspwiki has been converted to a maven
>>>> project, it appears that netbeans does not need this directory. (My old
>>>> jspwiki 2.8.4 project sandbox used ant and it contains an nbproject
>>>> sub-directory).
>>>>
>>>>
>>> I changed a netbeans project property and subsequently noticed a new file
>>> was created:
>>>
>>> jspwiki-war/nb-configuration.xml
>>>
>>> It seems to me netbeans would use this single file to hold /any/ local
>>> configuration properties for a particular maven project. Given the main
>>> and
>>> all three jspwiki-* sub-projects might possibly qualify for local
>>> changes,
>>> I suggest you add this specific filename to the svnignore.
>>>
>>> Sorry to keep referring to tomcat's ant project, but it carries a lot of
>>> useful battle scars. If, at some time in the future, we decide it would
>>> be
>>> useful to maintain /recommended/ versions of project files for different
>>> IDEs, we could create a separate directory where they can be committed,
>>> but
>>> will not automatically become active. There is probably a maven way to
>>> achieve this (rather than apeing tomcat), but we can worry about that
>>> if/when the need arises.
>>>
>>> I don't think this change merits opening a new JIRA.
>>>
>>> Regards,
>>>
>>> Brian
>>>
>>>
>>>
>>
>
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Brian Burch <br...@pingtoo.com>.
On 11/02/14 23:21, Juan Pablo Santos Rodríguez wrote:
> Hi Brian,
>
> included the new file on .svnignore and applied svn propset svn:ignore.. on
> 2.10.1-svn-4 (current trunk)
Thanks, Juan Pablo,
the trunk is looking a lot cleaner after your changes.
However, can you explain this recent arrival?
brian@schizo:~/sandboxApache/jspwiki$ svn status
? jspwiki-war/rss.rdf
and
brian@schizo:~/sandboxApache/jspwiki$ cat jspwiki-war/rss.rdf
<?xml version="1.0" encoding="UTF-8"?>
<rdf:RDF xmlns:dc='http://purl.org/dc/elements/1.1/'
xmlns:wiki='http://purl.org/rss/1.0/modules/wiki/'
xmlns='http://purl.org/rss/1.0/'
xmlns:rdf='http://www.w3.org/1999/02/22-rdf-syntax-ns#'>
<channel
rdf:about='http://localhost/'><link>http://localhost/</link><title>JSPWiki</title><description>Oh
poor me, my owner has not set a channel description at all. Pity
me.</description><dc:language>en-us</dc:language><items><rdf:Seq></rdf:Seq></items></channel>
I don't think it is anything I've done... should the file be committed,
or ignored?
Best wishes,
Brian
> br,
> juan pablo
>
>
>
> On Tue, Feb 11, 2014 at 12:08 PM, Brian Burch <br...@pingtoo.com> wrote:
>
>> Oops! I was wrong about netbeans! (see inline)
>>
>> On 05/02/14 12:59, Brian Burch wrote:
>> <snip/>
>>
>> Tomcat also ignores "nbproject", which is a subdirectory created by
>>> netbeans. However, now that jspwiki has been converted to a maven
>>> project, it appears that netbeans does not need this directory. (My old
>>> jspwiki 2.8.4 project sandbox used ant and it contains an nbproject
>>> sub-directory).
>>>
>>
>> I changed a netbeans project property and subsequently noticed a new file
>> was created:
>>
>> jspwiki-war/nb-configuration.xml
>>
>> It seems to me netbeans would use this single file to hold /any/ local
>> configuration properties for a particular maven project. Given the main and
>> all three jspwiki-* sub-projects might possibly qualify for local changes,
>> I suggest you add this specific filename to the svnignore.
>>
>> Sorry to keep referring to tomcat's ant project, but it carries a lot of
>> useful battle scars. If, at some time in the future, we decide it would be
>> useful to maintain /recommended/ versions of project files for different
>> IDEs, we could create a separate directory where they can be committed, but
>> will not automatically become active. There is probably a maven way to
>> achieve this (rather than apeing tomcat), but we can worry about that
>> if/when the need arises.
>>
>> I don't think this change merits opening a new JIRA.
>>
>> Regards,
>>
>> Brian
>>
>>
>
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi Brian,
included the new file on .svnignore and applied svn propset svn:ignore.. on
2.10.1-svn-4 (current trunk)
br,
juan pablo
On Tue, Feb 11, 2014 at 12:08 PM, Brian Burch <br...@pingtoo.com> wrote:
> Oops! I was wrong about netbeans! (see inline)
>
> On 05/02/14 12:59, Brian Burch wrote:
> <snip/>
>
> Tomcat also ignores "nbproject", which is a subdirectory created by
>> netbeans. However, now that jspwiki has been converted to a maven
>> project, it appears that netbeans does not need this directory. (My old
>> jspwiki 2.8.4 project sandbox used ant and it contains an nbproject
>> sub-directory).
>>
>
> I changed a netbeans project property and subsequently noticed a new file
> was created:
>
> jspwiki-war/nb-configuration.xml
>
> It seems to me netbeans would use this single file to hold /any/ local
> configuration properties for a particular maven project. Given the main and
> all three jspwiki-* sub-projects might possibly qualify for local changes,
> I suggest you add this specific filename to the svnignore.
>
> Sorry to keep referring to tomcat's ant project, but it carries a lot of
> useful battle scars. If, at some time in the future, we decide it would be
> useful to maintain /recommended/ versions of project files for different
> IDEs, we could create a separate directory where they can be committed, but
> will not automatically become active. There is probably a maven way to
> achieve this (rather than apeing tomcat), but we can worry about that
> if/when the need arises.
>
> I don't think this change merits opening a new JIRA.
>
> Regards,
>
> Brian
>
>
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Brian Burch <br...@pingtoo.com>.
Oops! I was wrong about netbeans! (see inline)
On 05/02/14 12:59, Brian Burch wrote:
<snip/>
> Tomcat also ignores "nbproject", which is a subdirectory created by
> netbeans. However, now that jspwiki has been converted to a maven
> project, it appears that netbeans does not need this directory. (My old
> jspwiki 2.8.4 project sandbox used ant and it contains an nbproject
> sub-directory).
I changed a netbeans project property and subsequently noticed a new
file was created:
jspwiki-war/nb-configuration.xml
It seems to me netbeans would use this single file to hold /any/ local
configuration properties for a particular maven project. Given the main
and all three jspwiki-* sub-projects might possibly qualify for local
changes, I suggest you add this specific filename to the svnignore.
Sorry to keep referring to tomcat's ant project, but it carries a lot of
useful battle scars. If, at some time in the future, we decide it would
be useful to maintain /recommended/ versions of project files for
different IDEs, we could create a separate directory where they can be
committed, but will not automatically become active. There is probably a
maven way to achieve this (rather than apeing tomcat), but we can worry
about that if/when the need arises.
I don't think this change merits opening a new JIRA.
Regards,
Brian
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Brian Burch <br...@pingtoo.com>.
On 05/02/14 09:27, Juan Pablo Santos Rodríguez wrote:
> Hi,
>
> svn propset / propedit should be enough, see
> http://anilsaldhana.blogspot.com.es/2008/09/recursively-ignore-target-directory-in.htmlfor
> an example
I haven't followed your link, but all I can say is the syntax for
multiple targets of an svn property is tricky.
Here are some simple cases that worked for me:
brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages$ svn
propset svn:ignore 'target' .
property 'svn:ignore' set on '.'
brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages$ svn
--verbose proplist .
Properties on '.':
svn:ignore
target
and
brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages$ cd de
brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages/de$ svn
propset svn:ignore 'target' .
property 'svn:ignore' set on '.'
brian@schizo:~/sandboxApache/jspwiki_2_10_0/jspwiki-wikipages/de$ svn
--verbose proplist .
Properties on '.':
svn:ignore
target
leaving me with
brian@schizo:~/sandboxApache/jspwiki_2_10_0$ svn status
M .
M jspwiki-wikipages
M jspwiki-wikipages/de
? jspwiki-wikipages/en/target
? jspwiki-wikipages/es/target
? jspwiki-wikipages/fi/target
? jspwiki-wikipages/fr/target
? jspwiki-wikipages/it/target
? jspwiki-wikipages/nl/target
? jspwiki-wikipages/pt_BR/target
? jspwiki-wikipages/zh_CN/target
> if nobody does it before, I'll do it tonight for target .settings,
> .classpath and .project (for other files/folders, now would be the right
> time to ask for it)
I noticed tomcat root properties defines svn:ignore for ".*". If you
used this valid wildcard form, it would allow you to remove ".project".
Craig suggested there was a way to define svn properties ONLY in the
top-level project and have them inherited by sub-projects. Perhaps he
can explain, because I don't know how to do that.
The svn redbook states "The property is set on the directory in which
you wish the patterns to be applied. 29" and footnote 29 states "The
patterns are strictly for that directory—they do not carry recursively
into subdirectories." If there is way to achieve recursion, it must be
some kind of maven magic.
Tomcat also ignores "nbproject", which is a subdirectory created by
netbeans. However, now that jspwiki has been converted to a maven
project, it appears that netbeans does not need this directory. (My old
jspwiki 2.8.4 project sandbox used ant and it contains an nbproject
sub-directory).
The sub-project jspwiki-war has a root svn:ignore for ".classpath", but
not for ".project". We either need Craig's trick, or ".*" in this
project too.
I hope my comments can avoid some frustration with the change!
Good luck,
Brian
> br,
> juan pablo
>
>
> On Wed, Feb 5, 2014 at 9:54 AM, Harry Metske <ha...@gmail.com> wrote:
>
>> Brian,
>>
>> if you could reply the required svn commands for all the resources
>> requiring the svn properties , that would be fine.
>>
>> regards,
>> Harry
>>
>>
>>
>> On 5 February 2014 09:07, Brian Burch <br...@pingtoo.com> wrote:
>>
>>> On 04/02/14 22:14, Juan Pablo Santos Rodríguez wrote:
>>>
>>>> Hi Brian,
>>>>
>>>> apologies if I sounded harsh, that was definitely not my intention.
>>>>
>>>
>>> No, I never thought you were! Nor was I offended.
>>>
>>>
>>> Got a
>>>> bunch of mails and went answering through them as quick and concise as
>>>> possible, didn't mean to be picky in any way.
>>>>
>>>
>>> I understand you have been under a lot of pressure to get the project
>>> converted and stabilised. I appreciate all your efforts and help.
>>>
>>>
>>> Regarding the missing
>>>> svn:ignore, as I was used to my workspace I didn't gave too much
>> attention
>>>> to this issue, but will look into it as soon as I'm able to.
>>>>
>>>
>>> It is quite a trivial change. I could do it in a few minutes with either
>>> netbeans, or from a command line - I don't use eclipse. The svn diff I
>>> supplied doesn't help with /how/ to do the change.
>>>
>>> If it would help, I could send you the svn commands to make the change?
>> It
>>> isn't keeping me up at night, but seems like low hanging fruit that could
>>> be taken out quickly.
>>>
>>> Regards,
>>>
>>> Brian
>>>
>>>
>>> br,
>>>> juan pablo
>>>>
>>>>
>>>> On Tue, Feb 4, 2014 at 4:33 PM, Brian Burch <br...@pingtoo.com> wrote:
>>>>
>>>> On 03/02/14 20:10, Juan Pablo Santos Rodríguez wrote:
>>>>>
>>>>> Hi Brian,
>>>>>>
>>>>>> Regarding the '?' marked files I omit them on Eclipse through Window
>> ->
>>>>>> Preferences -> Team -> Ignored resources and add "target",
>> ".settings",
>>>>>> ".project" and so on; that way I don't "see" them.
>>>>>>
>>>>>>
>>>>> Please don't think I am being picky! The project is has now changed
>>>>> "home"
>>>>> twice in a short time, so now it has full and permanent status under
>>>>> apache, it makes sense to clean up the loose ends quickly - before we
>> all
>>>>> get used to ignoring them!
>>>>>
>>>>> Your answer is a bit ostrich-like! Just 'cos you don't see them, it
>>>>> doesn't mean everyone else can't either!
>>>>>
>>>>> I have just done another virgin "svn checkout" of 2.10.0 at r1564324,
>>>>> "svn
>>>>> --verbose proplist ." shows:
>>>>>
>>>>> Properties on '.':
>>>>> svn:ignore
>>>>> .project
>>>>>
>>>>>
>>>>> I added "target" to the project root svn:ignore property, and here is
>> the
>>>>> diff:
>>>>>
>>>>> Index: .
>>>>> ===================================================================
>>>>> --- . (revision 1564343)
>>>>> +++ . (working copy)
>>>>>
>>>>> Property changes on: .
>>>>> ___________________________________________________________________
>>>>> Modified: svn:ignore
>>>>> ## -1 +1,2 ##
>>>>> .project
>>>>> +target
>>>>>
>>>>> svn does not need a trailing slash for a directory.
>>>>>
>>>>>
>>>>> As for the 'M' ones, the install target should *not* have touched
>> them.
>>>>>
>>>>>> Could you tell us which is the change introduced at
>>>>>> jspwiki-wikipages/en?
>>>>>> I
>>>>>> don't see that change on my local copy.
>>>>>>
>>>>>>
>>>>> I now see:
>>>>>
>>>>> brian@schizo:~/sandboxApache/jspwiki_2_10_0$ svn status
>>>>> M .
>>>>> ? jspwiki-wikipages/de/target
>>>>> ? jspwiki-wikipages/en/target
>>>>>
>>>>> ? jspwiki-wikipages/es/target
>>>>> ? jspwiki-wikipages/fi/target
>>>>> ? jspwiki-wikipages/fr/target
>>>>> ? jspwiki-wikipages/it/target
>>>>> ? jspwiki-wikipages/nl/target
>>>>> ? jspwiki-wikipages/pt_BR/target
>>>>> ? jspwiki-wikipages/target
>>>>> ? jspwiki-wikipages/zh_CN/target
>>>>>
>>>>> I think you need to add svn:ignore properties on each of these
>> individual
>>>>> "targets" within the jspwiki-wikipages sub-project - I can't see how to
>>>>> do
>>>>> the same thing using wildcards.
>>>>>
>>>>> I hope this is helpful?
>>>>>
>>>>> Brian
>>>>>
>>>>>
>>>>> thanks,
>>>>>
>>>>>> juan pablo
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Fri, Jan 24, 2014 at 10:52 AM, Brian Burch <br...@pingtoo.com>
>>>>>> wrote:
>>>>>>
>>>>>> I've recently started building and working with the trunk. I was
>>>>>>
>>>>>>> preparing
>>>>>>> a patch and noticed several objects were flagged as modified when I
>>>>>>> haven't
>>>>>>> touched them.
>>>>>>>
>>>>>>> I did a fresh checkout but made no changes at all. After running "mvn
>>>>>>> clean install", here is what I see:
>>>>>>>
>>>>>>> brian@schizo:~/sandboxApache/jspwiki$ svn status
>>>>>>> M jspwiki-wikipages
>>>>>>> ? jspwiki-wikipages/de/target
>>>>>>> M jspwiki-wikipages/en
>>>>>>> ? jspwiki-wikipages/es/target
>>>>>>> ? jspwiki-wikipages/fi/target
>>>>>>> ? jspwiki-wikipages/fr/target
>>>>>>> ? jspwiki-wikipages/it/target
>>>>>>> ? jspwiki-wikipages/nl/target
>>>>>>> ? jspwiki-wikipages/pt_BR/target
>>>>>>> ? jspwiki-wikipages/zh_CN/target
>>>>>>> ? target
>>>>>>>
>>>>>>> Have I missed something, or is this just a case of missing svn:ignore
>>>>>>> properties, or if the pages really are committable, why is the
>> install
>>>>>>> target touching these directories?
>>>>>>>
>>>>>>> Sorry to be picky!
>>>>>>>
>>>>>>> Brian
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi,
svn propset / propedit should be enough, see
http://anilsaldhana.blogspot.com.es/2008/09/recursively-ignore-target-directory-in.htmlfor
an example
if nobody does it before, I'll do it tonight for target .settings,
.classpath and .project (for other files/folders, now would be the right
time to ask for it)
br,
juan pablo
On Wed, Feb 5, 2014 at 9:54 AM, Harry Metske <ha...@gmail.com> wrote:
> Brian,
>
> if you could reply the required svn commands for all the resources
> requiring the svn properties , that would be fine.
>
> regards,
> Harry
>
>
>
> On 5 February 2014 09:07, Brian Burch <br...@pingtoo.com> wrote:
>
> > On 04/02/14 22:14, Juan Pablo Santos Rodríguez wrote:
> >
> >> Hi Brian,
> >>
> >> apologies if I sounded harsh, that was definitely not my intention.
> >>
> >
> > No, I never thought you were! Nor was I offended.
> >
> >
> > Got a
> >> bunch of mails and went answering through them as quick and concise as
> >> possible, didn't mean to be picky in any way.
> >>
> >
> > I understand you have been under a lot of pressure to get the project
> > converted and stabilised. I appreciate all your efforts and help.
> >
> >
> > Regarding the missing
> >> svn:ignore, as I was used to my workspace I didn't gave too much
> attention
> >> to this issue, but will look into it as soon as I'm able to.
> >>
> >
> > It is quite a trivial change. I could do it in a few minutes with either
> > netbeans, or from a command line - I don't use eclipse. The svn diff I
> > supplied doesn't help with /how/ to do the change.
> >
> > If it would help, I could send you the svn commands to make the change?
> It
> > isn't keeping me up at night, but seems like low hanging fruit that could
> > be taken out quickly.
> >
> > Regards,
> >
> > Brian
> >
> >
> > br,
> >> juan pablo
> >>
> >>
> >> On Tue, Feb 4, 2014 at 4:33 PM, Brian Burch <br...@pingtoo.com> wrote:
> >>
> >> On 03/02/14 20:10, Juan Pablo Santos Rodríguez wrote:
> >>>
> >>> Hi Brian,
> >>>>
> >>>> Regarding the '?' marked files I omit them on Eclipse through Window
> ->
> >>>> Preferences -> Team -> Ignored resources and add "target",
> ".settings",
> >>>> ".project" and so on; that way I don't "see" them.
> >>>>
> >>>>
> >>> Please don't think I am being picky! The project is has now changed
> >>> "home"
> >>> twice in a short time, so now it has full and permanent status under
> >>> apache, it makes sense to clean up the loose ends quickly - before we
> all
> >>> get used to ignoring them!
> >>>
> >>> Your answer is a bit ostrich-like! Just 'cos you don't see them, it
> >>> doesn't mean everyone else can't either!
> >>>
> >>> I have just done another virgin "svn checkout" of 2.10.0 at r1564324,
> >>> "svn
> >>> --verbose proplist ." shows:
> >>>
> >>> Properties on '.':
> >>> svn:ignore
> >>> .project
> >>>
> >>>
> >>> I added "target" to the project root svn:ignore property, and here is
> the
> >>> diff:
> >>>
> >>> Index: .
> >>> ===================================================================
> >>> --- . (revision 1564343)
> >>> +++ . (working copy)
> >>>
> >>> Property changes on: .
> >>> ___________________________________________________________________
> >>> Modified: svn:ignore
> >>> ## -1 +1,2 ##
> >>> .project
> >>> +target
> >>>
> >>> svn does not need a trailing slash for a directory.
> >>>
> >>>
> >>> As for the 'M' ones, the install target should *not* have touched
> them.
> >>>
> >>>> Could you tell us which is the change introduced at
> >>>> jspwiki-wikipages/en?
> >>>> I
> >>>> don't see that change on my local copy.
> >>>>
> >>>>
> >>> I now see:
> >>>
> >>> brian@schizo:~/sandboxApache/jspwiki_2_10_0$ svn status
> >>> M .
> >>> ? jspwiki-wikipages/de/target
> >>> ? jspwiki-wikipages/en/target
> >>>
> >>> ? jspwiki-wikipages/es/target
> >>> ? jspwiki-wikipages/fi/target
> >>> ? jspwiki-wikipages/fr/target
> >>> ? jspwiki-wikipages/it/target
> >>> ? jspwiki-wikipages/nl/target
> >>> ? jspwiki-wikipages/pt_BR/target
> >>> ? jspwiki-wikipages/target
> >>> ? jspwiki-wikipages/zh_CN/target
> >>>
> >>> I think you need to add svn:ignore properties on each of these
> individual
> >>> "targets" within the jspwiki-wikipages sub-project - I can't see how to
> >>> do
> >>> the same thing using wildcards.
> >>>
> >>> I hope this is helpful?
> >>>
> >>> Brian
> >>>
> >>>
> >>> thanks,
> >>>
> >>>> juan pablo
> >>>>
> >>>>
> >>>>
> >>>> On Fri, Jan 24, 2014 at 10:52 AM, Brian Burch <br...@pingtoo.com>
> >>>> wrote:
> >>>>
> >>>> I've recently started building and working with the trunk. I was
> >>>>
> >>>>> preparing
> >>>>> a patch and noticed several objects were flagged as modified when I
> >>>>> haven't
> >>>>> touched them.
> >>>>>
> >>>>> I did a fresh checkout but made no changes at all. After running "mvn
> >>>>> clean install", here is what I see:
> >>>>>
> >>>>> brian@schizo:~/sandboxApache/jspwiki$ svn status
> >>>>> M jspwiki-wikipages
> >>>>> ? jspwiki-wikipages/de/target
> >>>>> M jspwiki-wikipages/en
> >>>>> ? jspwiki-wikipages/es/target
> >>>>> ? jspwiki-wikipages/fi/target
> >>>>> ? jspwiki-wikipages/fr/target
> >>>>> ? jspwiki-wikipages/it/target
> >>>>> ? jspwiki-wikipages/nl/target
> >>>>> ? jspwiki-wikipages/pt_BR/target
> >>>>> ? jspwiki-wikipages/zh_CN/target
> >>>>> ? target
> >>>>>
> >>>>> Have I missed something, or is this just a case of missing svn:ignore
> >>>>> properties, or if the pages really are committable, why is the
> install
> >>>>> target touching these directories?
> >>>>>
> >>>>> Sorry to be picky!
> >>>>>
> >>>>> Brian
> >>>>>
> >>>>>
> >>>>>
> >>>>
> >>>
> >>
> >
>
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Harry Metske <ha...@gmail.com>.
Brian,
if you could reply the required svn commands for all the resources
requiring the svn properties , that would be fine.
regards,
Harry
On 5 February 2014 09:07, Brian Burch <br...@pingtoo.com> wrote:
> On 04/02/14 22:14, Juan Pablo Santos Rodríguez wrote:
>
>> Hi Brian,
>>
>> apologies if I sounded harsh, that was definitely not my intention.
>>
>
> No, I never thought you were! Nor was I offended.
>
>
> Got a
>> bunch of mails and went answering through them as quick and concise as
>> possible, didn't mean to be picky in any way.
>>
>
> I understand you have been under a lot of pressure to get the project
> converted and stabilised. I appreciate all your efforts and help.
>
>
> Regarding the missing
>> svn:ignore, as I was used to my workspace I didn't gave too much attention
>> to this issue, but will look into it as soon as I'm able to.
>>
>
> It is quite a trivial change. I could do it in a few minutes with either
> netbeans, or from a command line - I don't use eclipse. The svn diff I
> supplied doesn't help with /how/ to do the change.
>
> If it would help, I could send you the svn commands to make the change? It
> isn't keeping me up at night, but seems like low hanging fruit that could
> be taken out quickly.
>
> Regards,
>
> Brian
>
>
> br,
>> juan pablo
>>
>>
>> On Tue, Feb 4, 2014 at 4:33 PM, Brian Burch <br...@pingtoo.com> wrote:
>>
>> On 03/02/14 20:10, Juan Pablo Santos Rodríguez wrote:
>>>
>>> Hi Brian,
>>>>
>>>> Regarding the '?' marked files I omit them on Eclipse through Window ->
>>>> Preferences -> Team -> Ignored resources and add "target", ".settings",
>>>> ".project" and so on; that way I don't "see" them.
>>>>
>>>>
>>> Please don't think I am being picky! The project is has now changed
>>> "home"
>>> twice in a short time, so now it has full and permanent status under
>>> apache, it makes sense to clean up the loose ends quickly - before we all
>>> get used to ignoring them!
>>>
>>> Your answer is a bit ostrich-like! Just 'cos you don't see them, it
>>> doesn't mean everyone else can't either!
>>>
>>> I have just done another virgin "svn checkout" of 2.10.0 at r1564324,
>>> "svn
>>> --verbose proplist ." shows:
>>>
>>> Properties on '.':
>>> svn:ignore
>>> .project
>>>
>>>
>>> I added "target" to the project root svn:ignore property, and here is the
>>> diff:
>>>
>>> Index: .
>>> ===================================================================
>>> --- . (revision 1564343)
>>> +++ . (working copy)
>>>
>>> Property changes on: .
>>> ___________________________________________________________________
>>> Modified: svn:ignore
>>> ## -1 +1,2 ##
>>> .project
>>> +target
>>>
>>> svn does not need a trailing slash for a directory.
>>>
>>>
>>> As for the 'M' ones, the install target should *not* have touched them.
>>>
>>>> Could you tell us which is the change introduced at
>>>> jspwiki-wikipages/en?
>>>> I
>>>> don't see that change on my local copy.
>>>>
>>>>
>>> I now see:
>>>
>>> brian@schizo:~/sandboxApache/jspwiki_2_10_0$ svn status
>>> M .
>>> ? jspwiki-wikipages/de/target
>>> ? jspwiki-wikipages/en/target
>>>
>>> ? jspwiki-wikipages/es/target
>>> ? jspwiki-wikipages/fi/target
>>> ? jspwiki-wikipages/fr/target
>>> ? jspwiki-wikipages/it/target
>>> ? jspwiki-wikipages/nl/target
>>> ? jspwiki-wikipages/pt_BR/target
>>> ? jspwiki-wikipages/target
>>> ? jspwiki-wikipages/zh_CN/target
>>>
>>> I think you need to add svn:ignore properties on each of these individual
>>> "targets" within the jspwiki-wikipages sub-project - I can't see how to
>>> do
>>> the same thing using wildcards.
>>>
>>> I hope this is helpful?
>>>
>>> Brian
>>>
>>>
>>> thanks,
>>>
>>>> juan pablo
>>>>
>>>>
>>>>
>>>> On Fri, Jan 24, 2014 at 10:52 AM, Brian Burch <br...@pingtoo.com>
>>>> wrote:
>>>>
>>>> I've recently started building and working with the trunk. I was
>>>>
>>>>> preparing
>>>>> a patch and noticed several objects were flagged as modified when I
>>>>> haven't
>>>>> touched them.
>>>>>
>>>>> I did a fresh checkout but made no changes at all. After running "mvn
>>>>> clean install", here is what I see:
>>>>>
>>>>> brian@schizo:~/sandboxApache/jspwiki$ svn status
>>>>> M jspwiki-wikipages
>>>>> ? jspwiki-wikipages/de/target
>>>>> M jspwiki-wikipages/en
>>>>> ? jspwiki-wikipages/es/target
>>>>> ? jspwiki-wikipages/fi/target
>>>>> ? jspwiki-wikipages/fr/target
>>>>> ? jspwiki-wikipages/it/target
>>>>> ? jspwiki-wikipages/nl/target
>>>>> ? jspwiki-wikipages/pt_BR/target
>>>>> ? jspwiki-wikipages/zh_CN/target
>>>>> ? target
>>>>>
>>>>> Have I missed something, or is this just a case of missing svn:ignore
>>>>> properties, or if the pages really are committable, why is the install
>>>>> target touching these directories?
>>>>>
>>>>> Sorry to be picky!
>>>>>
>>>>> Brian
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Brian Burch <br...@pingtoo.com>.
On 04/02/14 22:14, Juan Pablo Santos Rodríguez wrote:
> Hi Brian,
>
> apologies if I sounded harsh, that was definitely not my intention.
No, I never thought you were! Nor was I offended.
> Got a
> bunch of mails and went answering through them as quick and concise as
> possible, didn't mean to be picky in any way.
I understand you have been under a lot of pressure to get the project
converted and stabilised. I appreciate all your efforts and help.
> Regarding the missing
> svn:ignore, as I was used to my workspace I didn't gave too much attention
> to this issue, but will look into it as soon as I'm able to.
It is quite a trivial change. I could do it in a few minutes with either
netbeans, or from a command line - I don't use eclipse. The svn diff I
supplied doesn't help with /how/ to do the change.
If it would help, I could send you the svn commands to make the change?
It isn't keeping me up at night, but seems like low hanging fruit that
could be taken out quickly.
Regards,
Brian
> br,
> juan pablo
>
>
> On Tue, Feb 4, 2014 at 4:33 PM, Brian Burch <br...@pingtoo.com> wrote:
>
>> On 03/02/14 20:10, Juan Pablo Santos Rodríguez wrote:
>>
>>> Hi Brian,
>>>
>>> Regarding the '?' marked files I omit them on Eclipse through Window ->
>>> Preferences -> Team -> Ignored resources and add "target", ".settings",
>>> ".project" and so on; that way I don't "see" them.
>>>
>>
>> Please don't think I am being picky! The project is has now changed "home"
>> twice in a short time, so now it has full and permanent status under
>> apache, it makes sense to clean up the loose ends quickly - before we all
>> get used to ignoring them!
>>
>> Your answer is a bit ostrich-like! Just 'cos you don't see them, it
>> doesn't mean everyone else can't either!
>>
>> I have just done another virgin "svn checkout" of 2.10.0 at r1564324, "svn
>> --verbose proplist ." shows:
>>
>> Properties on '.':
>> svn:ignore
>> .project
>>
>>
>> I added "target" to the project root svn:ignore property, and here is the
>> diff:
>>
>> Index: .
>> ===================================================================
>> --- . (revision 1564343)
>> +++ . (working copy)
>>
>> Property changes on: .
>> ___________________________________________________________________
>> Modified: svn:ignore
>> ## -1 +1,2 ##
>> .project
>> +target
>>
>> svn does not need a trailing slash for a directory.
>>
>>
>> As for the 'M' ones, the install target should *not* have touched them.
>>> Could you tell us which is the change introduced at jspwiki-wikipages/en?
>>> I
>>> don't see that change on my local copy.
>>>
>>
>> I now see:
>>
>> brian@schizo:~/sandboxApache/jspwiki_2_10_0$ svn status
>> M .
>> ? jspwiki-wikipages/de/target
>> ? jspwiki-wikipages/en/target
>>
>> ? jspwiki-wikipages/es/target
>> ? jspwiki-wikipages/fi/target
>> ? jspwiki-wikipages/fr/target
>> ? jspwiki-wikipages/it/target
>> ? jspwiki-wikipages/nl/target
>> ? jspwiki-wikipages/pt_BR/target
>> ? jspwiki-wikipages/target
>> ? jspwiki-wikipages/zh_CN/target
>>
>> I think you need to add svn:ignore properties on each of these individual
>> "targets" within the jspwiki-wikipages sub-project - I can't see how to do
>> the same thing using wildcards.
>>
>> I hope this is helpful?
>>
>> Brian
>>
>>
>> thanks,
>>> juan pablo
>>>
>>>
>>>
>>> On Fri, Jan 24, 2014 at 10:52 AM, Brian Burch <br...@pingtoo.com> wrote:
>>>
>>> I've recently started building and working with the trunk. I was
>>>> preparing
>>>> a patch and noticed several objects were flagged as modified when I
>>>> haven't
>>>> touched them.
>>>>
>>>> I did a fresh checkout but made no changes at all. After running "mvn
>>>> clean install", here is what I see:
>>>>
>>>> brian@schizo:~/sandboxApache/jspwiki$ svn status
>>>> M jspwiki-wikipages
>>>> ? jspwiki-wikipages/de/target
>>>> M jspwiki-wikipages/en
>>>> ? jspwiki-wikipages/es/target
>>>> ? jspwiki-wikipages/fi/target
>>>> ? jspwiki-wikipages/fr/target
>>>> ? jspwiki-wikipages/it/target
>>>> ? jspwiki-wikipages/nl/target
>>>> ? jspwiki-wikipages/pt_BR/target
>>>> ? jspwiki-wikipages/zh_CN/target
>>>> ? target
>>>>
>>>> Have I missed something, or is this just a case of missing svn:ignore
>>>> properties, or if the pages really are committable, why is the install
>>>> target touching these directories?
>>>>
>>>> Sorry to be picky!
>>>>
>>>> Brian
>>>>
>>>>
>>>
>>
>
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi Brian,
apologies if I sounded harsh, that was definitely not my intention. Got a
bunch of mails and went answering through them as quick and concise as
possible, didn't mean to be picky in any way. Regarding the missing
svn:ignore, as I was used to my workspace I didn't gave too much attention
to this issue, but will look into it as soon as I'm able to.
br,
juan pablo
On Tue, Feb 4, 2014 at 4:33 PM, Brian Burch <br...@pingtoo.com> wrote:
> On 03/02/14 20:10, Juan Pablo Santos Rodríguez wrote:
>
>> Hi Brian,
>>
>> Regarding the '?' marked files I omit them on Eclipse through Window ->
>> Preferences -> Team -> Ignored resources and add "target", ".settings",
>> ".project" and so on; that way I don't "see" them.
>>
>
> Please don't think I am being picky! The project is has now changed "home"
> twice in a short time, so now it has full and permanent status under
> apache, it makes sense to clean up the loose ends quickly - before we all
> get used to ignoring them!
>
> Your answer is a bit ostrich-like! Just 'cos you don't see them, it
> doesn't mean everyone else can't either!
>
> I have just done another virgin "svn checkout" of 2.10.0 at r1564324, "svn
> --verbose proplist ." shows:
>
> Properties on '.':
> svn:ignore
> .project
>
>
> I added "target" to the project root svn:ignore property, and here is the
> diff:
>
> Index: .
> ===================================================================
> --- . (revision 1564343)
> +++ . (working copy)
>
> Property changes on: .
> ___________________________________________________________________
> Modified: svn:ignore
> ## -1 +1,2 ##
> .project
> +target
>
> svn does not need a trailing slash for a directory.
>
>
> As for the 'M' ones, the install target should *not* have touched them.
>> Could you tell us which is the change introduced at jspwiki-wikipages/en?
>> I
>> don't see that change on my local copy.
>>
>
> I now see:
>
> brian@schizo:~/sandboxApache/jspwiki_2_10_0$ svn status
> M .
> ? jspwiki-wikipages/de/target
> ? jspwiki-wikipages/en/target
>
> ? jspwiki-wikipages/es/target
> ? jspwiki-wikipages/fi/target
> ? jspwiki-wikipages/fr/target
> ? jspwiki-wikipages/it/target
> ? jspwiki-wikipages/nl/target
> ? jspwiki-wikipages/pt_BR/target
> ? jspwiki-wikipages/target
> ? jspwiki-wikipages/zh_CN/target
>
> I think you need to add svn:ignore properties on each of these individual
> "targets" within the jspwiki-wikipages sub-project - I can't see how to do
> the same thing using wildcards.
>
> I hope this is helpful?
>
> Brian
>
>
> thanks,
>> juan pablo
>>
>>
>>
>> On Fri, Jan 24, 2014 at 10:52 AM, Brian Burch <br...@pingtoo.com> wrote:
>>
>> I've recently started building and working with the trunk. I was
>>> preparing
>>> a patch and noticed several objects were flagged as modified when I
>>> haven't
>>> touched them.
>>>
>>> I did a fresh checkout but made no changes at all. After running "mvn
>>> clean install", here is what I see:
>>>
>>> brian@schizo:~/sandboxApache/jspwiki$ svn status
>>> M jspwiki-wikipages
>>> ? jspwiki-wikipages/de/target
>>> M jspwiki-wikipages/en
>>> ? jspwiki-wikipages/es/target
>>> ? jspwiki-wikipages/fi/target
>>> ? jspwiki-wikipages/fr/target
>>> ? jspwiki-wikipages/it/target
>>> ? jspwiki-wikipages/nl/target
>>> ? jspwiki-wikipages/pt_BR/target
>>> ? jspwiki-wikipages/zh_CN/target
>>> ? target
>>>
>>> Have I missed something, or is this just a case of missing svn:ignore
>>> properties, or if the pages really are committable, why is the install
>>> target touching these directories?
>>>
>>> Sorry to be picky!
>>>
>>> Brian
>>>
>>>
>>
>
Re: Does jspwiki-wikipages need svn:ignore?
Posted by Brian Burch <br...@pingtoo.com>.
On 03/02/14 20:10, Juan Pablo Santos Rodríguez wrote:
> Hi Brian,
>
> Regarding the '?' marked files I omit them on Eclipse through Window ->
> Preferences -> Team -> Ignored resources and add "target", ".settings",
> ".project" and so on; that way I don't "see" them.
Please don't think I am being picky! The project is has now changed
"home" twice in a short time, so now it has full and permanent status
under apache, it makes sense to clean up the loose ends quickly - before
we all get used to ignoring them!
Your answer is a bit ostrich-like! Just 'cos you don't see them, it
doesn't mean everyone else can't either!
I have just done another virgin "svn checkout" of 2.10.0 at r1564324,
"svn --verbose proplist ." shows:
Properties on '.':
svn:ignore
.project
I added "target" to the project root svn:ignore property, and here is
the diff:
Index: .
===================================================================
--- . (revision 1564343)
+++ . (working copy)
Property changes on: .
___________________________________________________________________
Modified: svn:ignore
## -1 +1,2 ##
.project
+target
svn does not need a trailing slash for a directory.
> As for the 'M' ones, the install target should *not* have touched them.
> Could you tell us which is the change introduced at jspwiki-wikipages/en? I
> don't see that change on my local copy.
I now see:
brian@schizo:~/sandboxApache/jspwiki_2_10_0$ svn status
M .
? jspwiki-wikipages/de/target
? jspwiki-wikipages/en/target
? jspwiki-wikipages/es/target
? jspwiki-wikipages/fi/target
? jspwiki-wikipages/fr/target
? jspwiki-wikipages/it/target
? jspwiki-wikipages/nl/target
? jspwiki-wikipages/pt_BR/target
? jspwiki-wikipages/target
? jspwiki-wikipages/zh_CN/target
I think you need to add svn:ignore properties on each of these
individual "targets" within the jspwiki-wikipages sub-project - I can't
see how to do the same thing using wildcards.
I hope this is helpful?
Brian
> thanks,
> juan pablo
>
>
>
> On Fri, Jan 24, 2014 at 10:52 AM, Brian Burch <br...@pingtoo.com> wrote:
>
>> I've recently started building and working with the trunk. I was preparing
>> a patch and noticed several objects were flagged as modified when I haven't
>> touched them.
>>
>> I did a fresh checkout but made no changes at all. After running "mvn
>> clean install", here is what I see:
>>
>> brian@schizo:~/sandboxApache/jspwiki$ svn status
>> M jspwiki-wikipages
>> ? jspwiki-wikipages/de/target
>> M jspwiki-wikipages/en
>> ? jspwiki-wikipages/es/target
>> ? jspwiki-wikipages/fi/target
>> ? jspwiki-wikipages/fr/target
>> ? jspwiki-wikipages/it/target
>> ? jspwiki-wikipages/nl/target
>> ? jspwiki-wikipages/pt_BR/target
>> ? jspwiki-wikipages/zh_CN/target
>> ? target
>>
>> Have I missed something, or is this just a case of missing svn:ignore
>> properties, or if the pages really are committable, why is the install
>> target touching these directories?
>>
>> Sorry to be picky!
>>
>> Brian
>>
>