You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by derrickdoo <gi...@git.apache.org> on 2016/12/08 08:19:46 UTC
[GitHub] kafka-site pull request #36: Streams standalone docs
GitHub user derrickdoo opened a pull request:
https://github.com/apache/kafka-site/pull/36
Streams standalone docs
Here's the changes we talked about to pull Streams documentation out to it's own page. Ended up having to do the redirect on URLs that contain anchor tags that match the pattern 'streams_' with JS in the head section of the page because anchor tags aren't available on the server so you can't do rewrite rules based off them.
(also added in a change I thought was already out there to show info about Kafka Summit on the events page)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/derrickdoo/kafka-site streamsStandaloneDocs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka-site/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit 17f1344520f619da0f8af2648ddf39ccb2462f5a
Author: Derrick Or <de...@gmail.com>
Date: 2016-11-09T23:35:51Z
added new meetup links and kafka summit to events page
commit 9a9461e6d5f7c5b811bab5aca96aa52cc4f991e2
Author: Derrick Or <de...@gmail.com>
Date: 2016-12-08T08:10:57Z
move 0101 streams docs to own page, handle existing anchor links with frontend redirects
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site issue #36: Streams standalone docs
Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on the issue:
https://github.com/apache/kafka-site/pull/36
Thanks @derrickdoo , LGTM overall. One meta question:
Does any of those changes need to be in `kafka`'s docs folder as well? During each release we will do a copy-paste from the built tars to `kafka-site`:
https://cwiki.apache.org/confluence/display/KAFKA/Release+Process#ReleaseProcess-Websiteupdateprocess
Next time when we do this, some of the changes may be reverted.
So maybe we need another PR on the `kafka` repo as well for some of those changes, other changes like the `event.html` are not included in the docs folder and hence we do not need them in the `kafka` repo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site issue #36: Streams standalone docs
Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on the issue:
https://github.com/apache/kafka-site/pull/36
Thanks @derrickdoo ! Please add me to reviewers list when you created the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site issue #36: Streams standalone docs
Posted by derrickdoo <gi...@git.apache.org>.
Github user derrickdoo commented on the issue:
https://github.com/apache/kafka-site/pull/36
@guozhangwang yes, 2 things need to happen to new copies of stuff in side the versioned docs folder.
1. streams.html will need to have the full shell around it, so the includes at the top and bottom as seen in 0101/streams.html need to be there all the time now.
2. paths to images in all the new doc files (0101 and beyond) need to include the full path to the image directory.
I'll make a PR to the kafka repo to make sure everything is all set for the next release
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site pull request #36: Streams standalone docs
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka-site/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site issue #36: Streams standalone docs
Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on the issue:
https://github.com/apache/kafka-site/pull/36
Merged, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site issue #36: Streams standalone docs
Posted by derrickdoo <gi...@git.apache.org>.
Github user derrickdoo commented on the issue:
https://github.com/apache/kafka-site/pull/36
@guozhangwang here's a PR for the standalone Streams docs page
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---