You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2019/01/17 11:59:11 UTC
[GitHub] egorklimov commented on a change in pull request #3205:
[ZEPPELIN-3814] Add apply button to table settings
egorklimov commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings
URL: https://github.com/apache/zeppelin/pull/3205#discussion_r248643084
##########
File path: zeppelin-web/src/app/visualization/builtins/visualization-table-setting.html
##########
@@ -17,6 +17,12 @@
<span style="vertical-align: middle; display: inline-block; margin-top: 3px;">Table Options</span>
<span style="float: right;">
<div class="btn-group" role="group" aria-label="...">
+ <div type="button" ng-click="applyTableOption()"
+ uib-tooltip="Apply new setting" tooltip-placement="left"
+ class="btn btn-default" style="font-size: 11px; padding: 2px 5px 2px 5px;">
+ <i class="fa fa-check-square" aria-hidden="true"></i>
Review comment:
@felixcheung table settings have just three options, so I suppose it's not really necessary, moreover this behavior is not supported in more complexity settings in `advanced-transformation-settings`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services