You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/12 01:19:00 UTC

[jira] [Commented] (MINIFICPP-479) Incorporate property validation information into manifest

    [ https://issues.apache.org/jira/browse/MINIFICPP-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718326#comment-16718326 ] 

ASF GitHub Bot commented on MINIFICPP-479:
------------------------------------------

GitHub user phrocker opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/460

    MINIFICPP-479: Add processor property descriptor updates. WIP

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-479

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/460.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #460
    
----
commit 371ab8cf0cbcd25c4924696ffe1c7215da2c2977
Author: Marc Parisi <ph...@...>
Date:   2018-08-12T17:22:00Z

    MINIFICPP-479 and others: commit initial stuff
    
    get back on track
    
    MINIFICPP-479: begin incorporating validators
    
    MINIFICPP-479: Adding code found on laptop
    
    Found more code in stashed repos

commit ce89c4dfc6839ef071a8488af61abbefd0038027
Author: Marc Parisi <ph...@...>
Date:   2018-08-19T16:00:00Z

    MINIFICPP-479: inc commit .. does not work fully

commit 72df0111bb5c6ae03be38c0471578178e7945365
Author: Marc Parisi <ph...@...>
Date:   2018-12-11T01:03:34Z

    MINIFICPP-479: Make updates to how values can be used
    
    MINIFICPP-479: Add comments

commit 54fc1f36cea1f7bb30e208acf95487c29b0fe2af
Author: Marc Parisi <ph...@...>
Date:   2018-12-12T01:12:58Z

    MINIFICPP-479: Update processors

----


> Incorporate property validation information into manifest
> ---------------------------------------------------------
>
>                 Key: MINIFICPP-479
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-479
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Andrew Christianson
>            Assignee: Mr TheSegfault
>            Priority: Major
>
> High-level intent is to avoid round-trip to c2 to know that flow is valid (or, invalid in common/trivial ways).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)