You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sis.apache.org by Martin Desruisseaux <ma...@geomatys.fr> on 2014/12/31 16:43:20 UTC

Suggestion on today Shapefile commit: avoid duplicating test files

Hello Marc

I just saw the today commit on the Shapefile module, thanks. I noticed
that the "SignedBikeRoute_4326_clipped" test files were copied in a new
package. Can I make 2 suggestions?

1) Please use "svn copy" when copying files, for preserving history and
reducing the space consumption on Apache servers.

2) In this case, why copying the test files? Why not using the existing
test files? This can be done by modifying
AbstractTestBaseForInternalJDBC file at line 46, if we replace
'AbstractTestBaseForInternalJDBC.class' by 'ShapeFileTest.class'.

    Martin


Re: Suggestion on today Shapefile commit: avoid duplicating test files

Posted by Martin Desruisseaux <ma...@geomatys.fr>.
Le 01/01/15 08:37, Martin Desruisseaux a écrit :
> (...snip...) and always check with "svn update" on the command
> line before to commit.

Sorry, typo. I mean "svn status".

I saw that the duplicated files have been removed. Thanks!

    Martin


Re: Suggestion on today Shapefile commit: avoid duplicating test files

Posted by Martin Desruisseaux <ma...@geomatys.fr>.
Hello Marc

Thanks for the reply. As said previously, I would suggest to never rely
on an IDE or graphical tools to do the right thing - unless one knows
his tools very well -, and always check with "svn update" on the command
line before to commit. The "new contributor" page [1] tries to explain
the expected output, and also suggest a configuration to apply on
Subversion installation.

About the move intend, isn't the old location
(org/apache/sis/storage/shapefile/) a more natural place than the new
one (org/apache/sis/internal/shapefile/jdbc)? Testing a shapefile is
more than testing a DBase format, and the "SignedBikeRoute" tests files
are rather about shapefile in its wider sense. For example the *.prj
file has nothing to to with JDBC.

What about leaving the test files in their previous location (which I
think is more appropriate), remove the new copy, and get
AbstractTestBaseForInternalJDBC to use the existing files?

    Martin


[1] http://sis.apache.org/contributor.html#commit

Le 31/12/14 18:39, Marc Le Bihan a écrit :
> Hello,
>
>    In fact, SignedBikeRoute_4326_clipped was moved to the new location.
>    But when I did an svn update just before doing my commit, I was
> surprised by files coming back to me with "restored" status. I
> destroyed them again, except for these test files.
>
>   I correct these troubles soon.
>
> Marc.


Re: Suggestion on today Shapefile commit: avoid duplicating test files

Posted by Marc Le Bihan <ml...@gmail.com>.
Hello,

    In fact, SignedBikeRoute_4326_clipped was moved to the new location.
    But when I did an svn update just before doing my commit, I was 
surprised by files coming back to me with "restored" status. I destroyed 
them again, except for these test files.

   I correct these troubles soon.

Marc.

-----Message d'origine----- 
From: Martin Desruisseaux
Sent: Wednesday, December 31, 2014 4:43 PM
To: Apache SIS
Subject: Suggestion on today Shapefile commit: avoid duplicating test files

Hello Marc

I just saw the today commit on the Shapefile module, thanks. I noticed
that the "SignedBikeRoute_4326_clipped" test files were copied in a new
package. Can I make 2 suggestions?

1) Please use "svn copy" when copying files, for preserving history and
reducing the space consumption on Apache servers.

2) In this case, why copying the test files? Why not using the existing
test files? This can be done by modifying
AbstractTestBaseForInternalJDBC file at line 46, if we replace
'AbstractTestBaseForInternalJDBC.class' by 'ShapeFileTest.class'.

    Martin