You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Michael Gottesman (JIRA)" <ji...@apache.org> on 2008/08/05 21:54:44 UTC
[jira] Created: (HBASE-796) Deprecates Text/String methods from
HTable and modifies all classes that used Text/String methods so that they
use byte[] instead
Deprecates Text/String methods from HTable and modifies all classes that used Text/String methods so that they use byte[] instead
---------------------------------------------------------------------------------------------------------------------------------
Key: HBASE-796
URL: https://issues.apache.org/jira/browse/HBASE-796
Project: Hadoop HBase
Issue Type: Improvement
Components: client, mapred, test
Reporter: Michael Gottesman
Fix For: 0.2.0
This patch deprecates the text/string methods in HTable and changes all tests/normal methods that use those deprecated methods so that they use the byte[] version of the methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-796) Deprecates Text/String methods from
HTable and modifies all classes that used Text/String methods so that they
use byte[] instead
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620025#action_12620025 ]
stack commented on HBASE-796:
-----------------------------
Agree that we deprecate Text only. Let me fix the patch and get it into RC2 so we can remove in 0.3.0 timeframe.
> Deprecates Text/String methods from HTable and modifies all classes that used Text/String methods so that they use byte[] instead
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-796
> URL: https://issues.apache.org/jira/browse/HBASE-796
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: client, mapred, test
> Reporter: Michael Gottesman
> Fix For: 0.2.0
>
> Attachments: patch
>
>
> This patch deprecates the text/string methods in HTable and changes all tests/normal methods that use those deprecated methods so that they use the byte[] version of the methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-796) Deprecates Text/String methods from
HTable and modifies all classes that used Text/String methods so that they
use byte[] instead
Posted by "Michael Gottesman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Gottesman updated HBASE-796:
------------------------------------
Attachment: patch
here is the patch
> Deprecates Text/String methods from HTable and modifies all classes that used Text/String methods so that they use byte[] instead
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-796
> URL: https://issues.apache.org/jira/browse/HBASE-796
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: client, mapred, test
> Reporter: Michael Gottesman
> Fix For: 0.2.0
>
> Attachments: patch
>
>
> This patch deprecates the text/string methods in HTable and changes all tests/normal methods that use those deprecated methods so that they use the byte[] version of the methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-796) Deprecates Text/String methods from
HTable and modifies all classes that used Text/String methods so that they
use byte[] instead
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-796.
-------------------------
Resolution: Fixed
Committed deprecation of Text methods. Thanks for the patch Michael.
> Deprecates Text/String methods from HTable and modifies all classes that used Text/String methods so that they use byte[] instead
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-796
> URL: https://issues.apache.org/jira/browse/HBASE-796
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: client, mapred, test
> Reporter: Michael Gottesman
> Fix For: 0.2.0
>
> Attachments: patch
>
>
> This patch deprecates the text/string methods in HTable and changes all tests/normal methods that use those deprecated methods so that they use the byte[] version of the methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-796) Deprecates Text/String methods from
HTable and modifies all classes that used Text/String methods so that they
use byte[] instead
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620022#action_12620022 ]
Jim Kellerman commented on HBASE-796:
-------------------------------------
-1 on deprecating String, it is too useful.
+0 on deprecating Text, it is used throughout Hadoop.
> Deprecates Text/String methods from HTable and modifies all classes that used Text/String methods so that they use byte[] instead
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-796
> URL: https://issues.apache.org/jira/browse/HBASE-796
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: client, mapred, test
> Reporter: Michael Gottesman
> Fix For: 0.2.0
>
> Attachments: patch
>
>
> This patch deprecates the text/string methods in HTable and changes all tests/normal methods that use those deprecated methods so that they use the byte[] version of the methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-796) Deprecates Text/String methods from
HTable and modifies all classes that used Text/String methods so that they
use byte[] instead
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman resolved HBASE-796.
---------------------------------
Resolution: Fixed
Methods that should have been deprecated as a part of this patch but weren't will be deprecated in 0.2.1. Opening a new Jira for that.
> Deprecates Text/String methods from HTable and modifies all classes that used Text/String methods so that they use byte[] instead
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-796
> URL: https://issues.apache.org/jira/browse/HBASE-796
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: client, mapred, test
> Reporter: Michael Gottesman
> Fix For: 0.2.0
>
> Attachments: patch
>
>
> This patch deprecates the text/string methods in HTable and changes all tests/normal methods that use those deprecated methods so that they use the byte[] version of the methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-796) Deprecates Text/String methods from
HTable and modifies all classes that used Text/String methods so that they
use byte[] instead
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620314#action_12620314 ]
Jim Kellerman commented on HBASE-796:
-------------------------------------
HColumnDescriptor, HBaseAdmin, and BatchUpdate are a part of the client API. If methods in HTable no longer accept Text, then neither should these.
> Deprecates Text/String methods from HTable and modifies all classes that used Text/String methods so that they use byte[] instead
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-796
> URL: https://issues.apache.org/jira/browse/HBASE-796
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: client, mapred, test
> Reporter: Michael Gottesman
> Fix For: 0.2.0
>
> Attachments: patch
>
>
> This patch deprecates the text/string methods in HTable and changes all tests/normal methods that use those deprecated methods so that they use the byte[] version of the methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HBASE-796) Deprecates Text/String
methods from HTable and modifies all classes that used Text/String methods
so that they use byte[] instead
Posted by "Michael Gottesman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620118#action_12620118 ]
gottesmm edited comment on HBASE-796 at 8/5/08 7:24 PM:
-----------------------------------------------------------------
@Jim this patch was not about removing all classes that accept Text parameters. Rather it was about presenting a more streamlined interface in class HTable for use by clients.
So all it does is deprecate the Text classes from class HTable and makes sure that those methods are not referenced anywhere else in the codebase. If you would like to remove all of the Text methods from all classes that is something else entirely and is not what this patch does.
I understand the javadoc problems and that was something that I overlooked. I will check it out now.
was (Author: gottesmm):
@Jim this patch was not about removing all classes that accept Text parameters. Rather it was about presenting a more streamlined interface to HBase Clients in class HTable.
So all it does is deprecate the Text classes from class HTable and makes sure that those methods are not referenced anywhere else in the codebase. If you would like to remove all of the Text methods from all classes that is something else entirely and is not what this patch does.
I understand the javadoc problems and that was something that I overlooked. I will check it out now.
> Deprecates Text/String methods from HTable and modifies all classes that used Text/String methods so that they use byte[] instead
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-796
> URL: https://issues.apache.org/jira/browse/HBASE-796
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: client, mapred, test
> Reporter: Michael Gottesman
> Fix For: 0.2.0
>
> Attachments: patch
>
>
> This patch deprecates the text/string methods in HTable and changes all tests/normal methods that use those deprecated methods so that they use the byte[] version of the methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-796) Deprecates Text/String methods from
HTable and modifies all classes that used Text/String methods so that they
use byte[] instead
Posted by "Michael Gottesman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620118#action_12620118 ]
Michael Gottesman commented on HBASE-796:
-----------------------------------------
@Jim this patch was not about removing all classes that accept Text parameters. Rather it was about presenting a more streamlined interface to HBase Clients in class HTable.
So all it does is deprecate the Text classes from class HTable and makes sure that those methods are not referenced anywhere else in the codebase. If you would like to remove all of the Text methods from all classes that is something else entirely and is not what this patch does.
I understand the javadoc problems and that was something that I overlooked. I will check it out now.
> Deprecates Text/String methods from HTable and modifies all classes that used Text/String methods so that they use byte[] instead
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-796
> URL: https://issues.apache.org/jira/browse/HBASE-796
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: client, mapred, test
> Reporter: Michael Gottesman
> Fix For: 0.2.0
>
> Attachments: patch
>
>
> This patch deprecates the text/string methods in HTable and changes all tests/normal methods that use those deprecated methods so that they use the byte[] version of the methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-796) Deprecates Text/String methods from
HTable and modifies all classes that used Text/String methods so that they
use byte[] instead
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620021#action_12620021 ]
Andrew Purtell commented on HBASE-796:
--------------------------------------
+1 on deprecating Text, -1 on deprecating String. IMHO, string convenience functions are important when working with the rest of Java-land. Even with o.a.h.h.u.Bytes, converting from byte[] to String back to byte[] makes client code unnecessarily ugly.
> Deprecates Text/String methods from HTable and modifies all classes that used Text/String methods so that they use byte[] instead
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-796
> URL: https://issues.apache.org/jira/browse/HBASE-796
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: client, mapred, test
> Reporter: Michael Gottesman
> Fix For: 0.2.0
>
> Attachments: patch
>
>
> This patch deprecates the text/string methods in HTable and changes all tests/normal methods that use those deprecated methods so that they use the byte[] version of the methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HBASE-796) Deprecates Text/String methods from
HTable and modifies all classes that used Text/String methods so that they
use byte[] instead
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman reopened HBASE-796:
---------------------------------
There are a number of examples in javadoc that still use Text, and a number of classes that still accept Text parameters. These should all be corrected before this patch is released.
> Deprecates Text/String methods from HTable and modifies all classes that used Text/String methods so that they use byte[] instead
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-796
> URL: https://issues.apache.org/jira/browse/HBASE-796
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: client, mapred, test
> Reporter: Michael Gottesman
> Fix For: 0.2.0
>
> Attachments: patch
>
>
> This patch deprecates the text/string methods in HTable and changes all tests/normal methods that use those deprecated methods so that they use the byte[] version of the methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.