[GitHub] [jmeter] FSchumacher commented on pull request #700: Replace oro

[GitBox <gi...@apache.org>]

FSchumacher commented on pull request #700:
URL: https://github.com/apache/jmeter/pull/700#issuecomment-1049035482


   > Just wondering: does it replace all `oro` usages? Frankly speaking, I was surprised there are many usages of oro.
   
   ```console
   $ find src -name "*.java" -exec grep -rl \.oro\. {} \;
   src/components/src/main/java/org/apache/jmeter/visualizers/RenderAsRegexp.java
   src/components/src/main/java/org/apache/jmeter/assertions/ResponseAssertion.java
   src/components/src/main/java/org/apache/jmeter/assertions/JSONPathAssertion.java
   src/components/src/main/java/org/apache/jmeter/assertions/jmespath/JMESPathAssertion.java
   src/components/src/main/java/org/apache/jmeter/assertions/CompareAssertion.java
   src/components/src/main/java/org/apache/jmeter/extractor/RegexExtractor.java
   src/core/src/test/java/org/apache/jmeter/report/dashboard/ApdexPerTransactionTest.java
   src/core/src/main/java/org/apache/jmeter/engine/util/ReplaceFunctionsWithStrings.java
   src/core/src/main/java/org/apache/jmeter/util/JMeterUtils.java
   src/core/src/main/java/org/apache/jmeter/save/CSVSaveService.java
   src/core/src/main/java/org/apache/jmeter/report/dashboard/ReportGenerator.java
   src/protocol/http/src/test/java/org/apache/jmeter/protocol/http/sampler/TestHTTPSamplersAgainstHttpMirrorServer.java
   src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/util/accesslog/LogFilter.java
   src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/util/accesslog/SessionFilter.java
   src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/util/EncoderCache.java
   src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/parser/HtmlParsingUtils.java
   src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/parser/RegexpHTMLParser.java
   src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/modifier/URLRewritingModifier.java
   src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/config/MultipartUrlConfig.java
   src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/control/HttpMirrorThread.java
   src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
   src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
   src/functions/src/main/java/org/apache/jmeter/functions/RegexFunction.java
   src/functions/src/main/java/org/apache/jmeter/functions/EscapeOroRegexpChars.java
   ```
   I have started with the functions and assertions. The other stuff is less user visible, but would need to replaced, too.
   
   > 
   > > `jmeter.use_java_regex`
   > 
   > What do you think if the property is something like `jmeter.regex.engine=oro|java` ? Then it would be more-or-less compatible with other alternatives (if needed :) ).
   
   For the bugfix, I concentrated on a feature flag to ease the transition from Oro to Java based. If we would like to be more flexible, the simplistic approach -- I took -- might not be the best and we should take more care to introduce a real abstraction instead of the if clauses.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org