You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/09/08 04:17:38 UTC

[Impala-ASF-CR](branch-4.1.1) IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Hello Impala Public Jenkins,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/18950

to review the following change.


Change subject: IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)
......................................................................

IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Machines that don't have en_US.UTF-8 installed see
issues when running ExprTest.Utf8MaskTest.
This currently impacts the Docker-based tests.
This installs the appropriate language packs
to have en_US.UTF-8 installed.

Testing:
 - Ran docker-based tests and verified that
   ExprTest.Utf8MaskTest passes.

Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Reviewed-on: http://gerrit.cloudera.org:8080/18875
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
---
M bin/bootstrap_system.sh
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/18950/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Gerrit-Change-Number: 18950
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR](branch-4.1.1) IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18950 )

Change subject: IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Gerrit-Change-Number: 18950
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 21:05:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-4.1.1) IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18950 )

Change subject: IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)
......................................................................

IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Machines that don't have en_US.UTF-8 installed see
issues when running ExprTest.Utf8MaskTest.
This currently impacts the Docker-based tests.
This installs the appropriate language packs
to have en_US.UTF-8 installed.

Testing:
 - Ran docker-based tests and verified that
   ExprTest.Utf8MaskTest passes.

Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Reviewed-on: http://gerrit.cloudera.org:8080/18875
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Reviewed-on: http://gerrit.cloudera.org:8080/18950
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M bin/bootstrap_system.sh
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Quanlong Huang: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Gerrit-Change-Number: 18950
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR](branch-4.1.1) IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18950 )

Change subject: IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)
......................................................................


Patch Set 1: Verified+1

Verified in https://gerrit.cloudera.org/c/18952/


-- 
To view, visit http://gerrit.cloudera.org:8080/18950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Gerrit-Change-Number: 18950
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 09 Sep 2022 05:12:23 +0000
Gerrit-HasComments: No