You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/05/23 22:48:45 UTC
Review Request: Fixed bug where we didn't stop all MesosExecutorDrivers when
using the TestingIsolator (potentially causing a segfault when a driver
attempts to use a MockExecutor that had been deallocated).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11352/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Description
-------
See summary.
Diffs
-----
src/tests/allocator_tests.cpp 540c05afa54caafea7c0b49773cf2613c87d1ba5
src/tests/allocator_zookeeper_tests.cpp 2c7deb1ef8d4349964ffa0bdd7b97ae616be1c43
src/tests/fault_tolerance_tests.cpp 68cd5fcff266d102d8edf265776517aa2eef6061
src/tests/gc_tests.cpp 97d2685e0f89e059ad424ecc5887eb18acc9612c
src/tests/isolator.hpp 17dc7b30415be1db984ca6290213840770f465a5
src/tests/master_tests.cpp 1b062d9ce96ae223389dea5f030f51640511ad52
src/tests/resource_offers_tests.cpp 5e53a89bcf99dedd4535545dc44a1a6229a09b0f
src/tests/status_update_manager_tests.cpp e375898152de357b1b50b7c5185b825e51bfaa3e
Diff: https://reviews.apache.org/r/11352/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Fixed bug where we didn't stop all MesosExecutorDrivers
when using the TestingIsolator (potentially causing a segfault when a
driver attempts to use a MockExecutor that had been deallocated).
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11352/
-----------------------------------------------------------
(Updated May 24, 2013, 6:36 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Added Thomas to the reviews since we chatted about this in person.
Description
-------
See summary.
Diffs
-----
src/tests/allocator_tests.cpp 540c05afa54caafea7c0b49773cf2613c87d1ba5
src/tests/allocator_zookeeper_tests.cpp 2c7deb1ef8d4349964ffa0bdd7b97ae616be1c43
src/tests/fault_tolerance_tests.cpp 68cd5fcff266d102d8edf265776517aa2eef6061
src/tests/gc_tests.cpp 97d2685e0f89e059ad424ecc5887eb18acc9612c
src/tests/isolator.hpp 17dc7b30415be1db984ca6290213840770f465a5
src/tests/master_tests.cpp 1b062d9ce96ae223389dea5f030f51640511ad52
src/tests/resource_offers_tests.cpp 5e53a89bcf99dedd4535545dc44a1a6229a09b0f
src/tests/status_update_manager_tests.cpp e375898152de357b1b50b7c5185b825e51bfaa3e
Diff: https://reviews.apache.org/r/11352/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Fixed bug where we didn't stop all MesosExecutorDrivers
when using the TestingIsolator (potentially causing a segfault when a
driver attempts to use a MockExecutor that had been deallocated).
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11352/#review20960
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 23, 2013, 8:48 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11352/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 8:48 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp 540c05afa54caafea7c0b49773cf2613c87d1ba5
> src/tests/allocator_zookeeper_tests.cpp 2c7deb1ef8d4349964ffa0bdd7b97ae616be1c43
> src/tests/fault_tolerance_tests.cpp 68cd5fcff266d102d8edf265776517aa2eef6061
> src/tests/gc_tests.cpp 97d2685e0f89e059ad424ecc5887eb18acc9612c
> src/tests/isolator.hpp 17dc7b30415be1db984ca6290213840770f465a5
> src/tests/master_tests.cpp 1b062d9ce96ae223389dea5f030f51640511ad52
> src/tests/resource_offers_tests.cpp 5e53a89bcf99dedd4535545dc44a1a6229a09b0f
> src/tests/status_update_manager_tests.cpp e375898152de357b1b50b7c5185b825e51bfaa3e
>
> Diff: https://reviews.apache.org/r/11352/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>