[GitHub] [accumulo] keith-turner commented on a change in pull request #2368: Create GenerateSplits utility

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #2368:
URL: https://github.com/apache/accumulo/pull/2368#discussion_r760564817



##########
File path: core/src/main/java/org/apache/accumulo/core/file/rfile/GenerateSplits.java
##########
@@ -201,7 +201,9 @@ public void execute(String[] args) throws Exception {
       itemsSketch.update(row);
       iterator.next();
     }
-    return itemsSketch.getQuantiles(numSplits);
+    Text[] items = itemsSketch.getQuantiles(numSplits + 2);

Review comment:
       ItemSketch has a method named getRetainedItems(), I wonder if this is the max that could be requested for getQuantiles()?  If so, what should be done if numSplits+2>itemsSketch.getRetainedItems()




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org