You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2016/08/26 01:45:22 UTC
[GitHub] incubator-gearpump pull request #77: [GEARPUMP-197] fix busy look in FetchTh...
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/77
[GEARPUMP-197] fix busy look in FetchThread
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump fix_fetch_thread
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit 92033c913877bae1e6225ba5654bad1cc349f4b5
Author: manuzhang <ow...@gmail.com>
Date: 2016-08-26T01:43:25Z
[GEARPUMP-197] fix busy look in FetchThread
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #77: [GEARPUMP-197] fix busy loop in FetchTh...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/77#discussion_r76543050
--- Diff: external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/consumer/FetchThread.scala ---
@@ -133,19 +133,21 @@ private[kafka] class FetchThread(
/**
* fetch message from each TopicAndPartition in a round-robin way
+ *
+ * @return whether to fetch more messages
--- End diff --
Could you create a jira ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #77: [GEARPUMP-197] fix busy loop in FetchThread
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/77
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #77: [GEARPUMP-197] fix busy loop in FetchThread
Posted by kkasravi <gi...@git.apache.org>.
Github user kkasravi commented on the issue:
https://github.com/apache/incubator-gearpump/pull/77
+1 though see my comment on round-robin fetching of messages
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #77: [GEARPUMP-197] fix busy loop in FetchTh...
Posted by kkasravi <gi...@git.apache.org>.
Github user kkasravi commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/77#discussion_r76534338
--- Diff: external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/consumer/FetchThread.scala ---
@@ -133,19 +133,21 @@ private[kafka] class FetchThread(
/**
* fetch message from each TopicAndPartition in a round-robin way
+ *
+ * @return whether to fetch more messages
--- End diff --
akka-streams has this GraphStage called InterLeave where upstreams are cycled and N messages are pulled from each one. I'm wondering if we should expose a policy related to fetch messages which is now round-robin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #77: [GEARPUMP-197] fix busy loop in FetchThread
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/77
## [Current coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/77?src=pr) is 69.69% (diff: 100%)
> Merging [#77](https://codecov.io/gh/apache/incubator-gearpump/pull/77?src=pr) into [master](https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr) will increase coverage by **1.09%**
```diff
@@ master #77 diff @@
==========================================
Files 177 177
Lines 5927 5927
Methods 5604 5606 +2
Messages 0 0
Branches 323 321 -2
==========================================
+ Hits 4066 4131 +65
+ Misses 1861 1796 -65
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [529799c...cbfc1a5](https://codecov.io/gh/apache/incubator-gearpump/compare/529799cc400a72ae9e0d2385044ce1fd5e329bb3...cbfc1a5d2dc1a170beb8847bdc549fc32c770e3d?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #77: [GEARPUMP-197] fix busy loop in FetchTh...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---