[GitHub] [airflow] bbovenzi commented on a diff in pull request #25098: Upgrade API file to typescript

[GitBox <gi...@apache.org>]

bbovenzi commented on code in PR #25098:
URL: https://github.com/apache/airflow/pull/25098#discussion_r923190466


##########
airflow/www/static/js/api/useClearRun.ts:
##########
@@ -17,30 +17,30 @@
  * under the License.
  */
 
-import axios from 'axios';
+import axios, { AxiosResponse } from 'axios';
 import { useMutation, useQueryClient } from 'react-query';
 import { getMetaValue } from '../utils';
 import { useAutoRefresh } from '../context/autorefresh';
 import useErrorToast from '../utils/useErrorToast';
 
-const csrfToken = getMetaValue('csrf_token');
-const clearRunUrl = getMetaValue('dagrun_clear_url');
+const csrfToken = getMetaValue('csrf_token') || '';
+const clearRunUrl = getMetaValue('dagrun_clear_url') || '';

Review Comment:
   Yeah, setting it to an empty string just kicks the error down the road. I don't know when these are not required, so I don't think we need an extra param. `getMetaValue()` should raise an exception and return empty string by default instead of coding it each time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org