[GitHub] [incubator-superset] suddjian commented on a change in pull request #9051: [explore] Modal to edit chart properties

[GitBox <gi...@apache.org>]

suddjian commented on a change in pull request #9051: [explore] Modal to edit chart properties
URL: https://github.com/apache/incubator-superset/pull/9051#discussion_r373268969
 
 

 ##########
 File path: superset/assets/src/explore/components/DisplayQueryButton.jsx
 ##########
 @@ -222,6 +233,20 @@ export default class DisplayQueryButton extends React.PureComponent {
         pullRight
         id="query"
       >
+        {this.props.slice && (
+          <>
+            <MenuItem onClick={this.openPropertiesModal}>
+              {t('Edit properties')}
+            </MenuItem>
+            <PropertiesModal
+              slice={this.props.slice}
+              show={this.state.propertiesModalOpen}
+              onHide={this.closePropertiesModal}
+              onSave={this.onSliceSave}
 
 Review comment:
   oops, yeah that shouldn't be there anymore

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org