You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/05/09 19:50:34 UTC

Review Request 21268: Add a "config" noun with a "list" verb to list jobs defined in a config file.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21268/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin and Suman Karumuri.


Bugs: aurora-403
    https://issues.apache.org/jira/browse/aurora-403


Repository: aurora


Description
-------

Add a "config" noun with a "list" verb to list jobs defined in a config file.


Diffs
-----

  src/main/python/apache/aurora/client/cli/BUILD 0c5a8c5cd11ad29b43027c0556710018b6ee3adc 
  src/main/python/apache/aurora/client/cli/client.py f7bafca8285ba5779ee185273d4843995a241b70 
  src/main/python/apache/aurora/client/cli/config.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 9766b3bdd0f5f552349453b6724573d43ddb02e5 
  src/test/python/apache/aurora/client/cli/test_config_noun.py PRE-CREATION 

Diff: https://reviews.apache.org/r/21268/diff/


Testing
-------

============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py ....

=========================== 4 passed in 0.03 seconds ===========================
Failed to run test!
Traceback (most recent call last):
  File "/Users/mchucarroll/.pex/install/twitter.pants-0.0.23-py2-none-any.whl.acd44f4c0cf3576608ff18b2adafeff6f0b8f65f/twitter.pants-0.0.23-py2-none-any.whl/twitter/pants/python/test_builder.py", line 204, in _run_python_test
    builder = chroot.dump()
  File "/Users/mchucarroll/.pex/install/twitter.pants-0.0.23-py2-none-any.whl.acd44f4c0cf3576608ff18b2adafeff6f0b8f65f/twitter.pants-0.0.23-py2-none-any.whl/twitter/pants/python/python_chroot.py", line 201, in dump
    platforms=platforms)
  File "/Users/mchucarroll/.pex/install/twitter.pants-0.0.23-py2-none-any.whl.acd44f4c0cf3576608ff18b2adafeff6f0b8f65f/twitter.pants-0.0.23-py2-none-any.whl/twitter/pants/python/resolver.py", line 109, in resolve_multi
    platform=platform)
  File "/Users/mchucarroll/.pex/install/twitter.common.python-0.5.6-py2-none-any.whl.966710ef4887d077b27ee1d9cc3725372604d0ef/twitter.common.python-0.5.6-py2-none-any.whl/twitter/common/python/resolver.py", line 107, in resolve
    new_requirements.update(requires(highest_package, requirement))
  File "/Users/mchucarroll/.pex/install/twitter.common.python-0.5.6-py2-none-any.whl.966710ef4887d077b27ee1d9cc3725372604d0ef/twitter.common.python-0.5.6-py2-none-any.whl/twitter/common/python/resolver.py", line 79, in requires
    dist = obtainer.obtain(package)
  File "/Users/mchucarroll/.pex/install/twitter.common.python-0.5.6-py2-none-any.whl.966710ef4887d077b27ee1d9cc3725372604d0ef/twitter.common.python-0.5.6-py2-none-any.whl/twitter/common/python/obtainer.py", line 158, in obtain
    dist = super(CachingObtainer, self).obtain(req_or_package)
  File "/Users/mchucarroll/.pex/install/twitter.common.python-0.5.6-py2-none-any.whl.966710ef4887d077b27ee1d9cc3725372604d0ef/twitter.common.python-0.5.6-py2-none-any.whl/twitter/common/python/obtainer.py", line 108, in obtain
    return self._translate_from([req_or_package])
  File "/Users/mchucarroll/.pex/install/twitter.common.python-0.5.6-py2-none-any.whl.966710ef4887d077b27ee1d9cc3725372604d0ef/twitter.common.python-0.5.6-py2-none-any.whl/twitter/common/python/obtainer.py", line 96, in _translate_from
    dist = self._translator.translate(package)
  File "/Users/mchucarroll/.pex/install/twitter.common.python-0.5.6-py2-none-any.whl.966710ef4887d077b27ee1d9cc3725372604d0ef/twitter.common.python-0.5.6-py2-none-any.whl/twitter/common/python/translator.py", line 44, in translate
    dist = tx.translate(package)
  File "/Users/mchucarroll/.pex/install/twitter.common.python-0.5.6-py2-none-any.whl.966710ef4887d077b27ee1d9cc3725372604d0ef/twitter.common.python-0.5.6-py2-none-any.whl/twitter/common/python/translator.py", line 116, in translate
    return DistributionHelper.distribution_from_path(target_path)
  File "/Users/mchucarroll/.pex/install/twitter.common.python-0.5.6-py2-none-any.whl.966710ef4887d077b27ee1d9cc3725372604d0ef/twitter.common.python-0.5.6-py2-none-any.whl/twitter/common/python/util.py", line 50, in distribution_from_path
    distributions = list(find_distributions(path))
  File "/Users/mchucarroll/.pex/install/twitter.common.python-0.5.6-py2-none-any.whl.966710ef4887d077b27ee1d9cc3725372604d0ef/twitter.common.python-0.5.6-py2-none-any.whl/twitter/common/python/finders.py", line 61, in __call__
    for dist in finder(importer, path_item, only=only):
  File "/Users/mchucarroll/.pex/install/twitter.common.python-0.5.6-py2-none-any.whl.966710ef4887d077b27ee1d9cc3725372604d0ef/twitter.common.python-0.5.6-py2-none-any.whl/twitter/common/python/finders.py", line 203, in find_wheels_in_zip
    dist = wheel_from_metadata(path_item, metadata)
  File "/Users/mchucarroll/.pex/install/twitter.common.python-0.5.6-py2-none-any.whl.966710ef4887d077b27ee1d9cc3725372604d0ef/twitter.common.python-0.5.6-py2-none-any.whl/twitter/common/python/finders.py", line 165, in wheel_from_metadata
    pkg_info = Parser().parsestr(metadata.get_metadata(pkg_resources.DistInfoDistribution.PKG_INFO))
  File "/Users/mchucarroll/Code/incubator-aurora/build-support/pants-0.0.23.pex/.bootstrap/pkg_resources.py", line 1361, in get_metadata
    return self._get(self._fn(self.egg_info,name))
  File "/Users/mchucarroll/Code/incubator-aurora/build-support/pants-0.0.23.pex/.bootstrap/pkg_resources.py", line 1425, in _get
    return self.loader.get_data(path)
ZipImportError: bad local file header in /Users/mchucarroll/Code/incubator-aurora/.pants.d/python/eggs/thrift-0.9.1-cp26-none-macosx_10_9_intel.whl
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
src.test.python.apache.aurora.client.cli.bridge                                 .....   SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks                          ..... EXCEPTION


Thanks,

Mark Chu-Carroll