You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by haohui <gi...@git.apache.org> on 2017/02/27 22:25:41 UTC
[GitHub] flink pull request #3426: [FLINK-5414] [table] Bump up Calcite version to 1....
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3426
[FLINK-5414] [table] Bump up Calcite version to 1.11
This PR resembles #3338 except that it canonizes the nullable types.
@wuchong can you please take a look?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui/flink FLINK-5414
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3426.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3426
----
commit 339f310dec67d40cd4ed4ecbabf09a0b0dcba518
Author: Haohui Mai <wh...@apache.org>
Date: 2017-02-27T22:24:08Z
[FLINK-5414] [table] Bump up Calcite version to 1.11. (Jark Wu and Haohui Mai)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3426
Hi @haohui , the code looks very good to me. Thanks for investigating this, waiting for the CI pass.
@twalthr , I think you would like to have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11
Posted by haohui <gi...@git.apache.org>.
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3426
Fix the unit tests.
There are two additional changes:
1. There are precision differences when converting `double` to `BigDecimal`. Fix the unit tests.
2. When registering UDFs Flink needs to distinguish nullable and non-nullable types. Patched `UserDefinedFunctionUtils`. We need a solution like FLINK-5177 to handle these cases systematically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11
Posted by haohui <gi...@git.apache.org>.
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3426
@twalthr can you please take another look? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3426
Thanks @wuchong and @haohui. I will look at it today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3426: [FLINK-5414] [table] Bump up Calcite version to 1....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3426
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3426
@haohui your build is failing. Can you have a look at it again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11
Posted by haohui <gi...@git.apache.org>.
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3426
Sorry stuck with something. Will update the PR in a day or two.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3426
Thanks for the update @haohui. I fixed the decimal issues by applying changes from @wuchong's PR. I think for now we should not do the primitive checking for scalar functions, this should be part of FLINK-5177. I will merge this now. But we should definitely solve FLINK-5177 soon. I will assign it to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---