You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2016/04/05 18:56:10 UTC
Review Request 45754: Use message provided by Mesos if present when
tasks fail due to resource limit violations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45754/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Zameer Manji.
Repository: aurora
Description
-------
Use message provided by Mesos if present when tasks fail due to resource limit violations.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java d4de225c7a96b26e493a3e77a2245ec132e06a08
src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 62ada33abcef977e722362904d671352e7f9947a
Diff: https://reviews.apache.org/r/45754/diff/
Testing
-------
./gradlew build -Pq
See attached screenshot for the Mesos-provided message we'll show in the case.
File Attachments
----------------
Exampled failed task
https://reviews.apache.org/media/uploaded/files/2016/04/05/df35aa54-2ef3-4e3b-8c9a-d3fe9bd26f74__Screen_Shot_2016-04-05_at_11.54.01_AM.png
Thanks,
Joshua Cohen
Re: Review Request 45754: Use message provided by Mesos if present
when tasks fail due to resource limit violations.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45754/#review127159
-----------------------------------------------------------
Ship it!
Master (663d13f) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 5, 2016, 5:40 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45754/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 5:40 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use message provided by Mesos if present when tasks fail due to resource limit violations.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java d4de225c7a96b26e493a3e77a2245ec132e06a08
> src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 62ada33abcef977e722362904d671352e7f9947a
>
> Diff: https://reviews.apache.org/r/45754/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
> See attached screenshot for the Mesos-provided message we'll show in the case.
>
>
> File Attachments
> ----------------
>
> Exampled failed task
> https://reviews.apache.org/media/uploaded/files/2016/04/05/df35aa54-2ef3-4e3b-8c9a-d3fe9bd26f74__Screen_Shot_2016-04-05_at_11.54.01_AM.png
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 45754: Use message provided by Mesos if present
when tasks fail due to resource limit violations.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45754/#review127156
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On April 5, 2016, 10:40 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45754/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 10:40 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use message provided by Mesos if present when tasks fail due to resource limit violations.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java d4de225c7a96b26e493a3e77a2245ec132e06a08
> src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 62ada33abcef977e722362904d671352e7f9947a
>
> Diff: https://reviews.apache.org/r/45754/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
> See attached screenshot for the Mesos-provided message we'll show in the case.
>
>
> File Attachments
> ----------------
>
> Exampled failed task
> https://reviews.apache.org/media/uploaded/files/2016/04/05/df35aa54-2ef3-4e3b-8c9a-d3fe9bd26f74__Screen_Shot_2016-04-05_at_11.54.01_AM.png
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 45754: Use message provided by Mesos if present
when tasks fail due to resource limit violations.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45754/#review127160
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On April 5, 2016, 5:40 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45754/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 5:40 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use message provided by Mesos if present when tasks fail due to resource limit violations.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java d4de225c7a96b26e493a3e77a2245ec132e06a08
> src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 62ada33abcef977e722362904d671352e7f9947a
>
> Diff: https://reviews.apache.org/r/45754/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
> See attached screenshot for the Mesos-provided message we'll show in the case.
>
>
> File Attachments
> ----------------
>
> Exampled failed task
> https://reviews.apache.org/media/uploaded/files/2016/04/05/df35aa54-2ef3-4e3b-8c9a-d3fe9bd26f74__Screen_Shot_2016-04-05_at_11.54.01_AM.png
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 45754: Use message provided by Mesos if present
when tasks fail due to resource limit violations.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45754/
-----------------------------------------------------------
(Updated April 5, 2016, 5:40 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Refactor tests to reuse code.
Repository: aurora
Description
-------
Use message provided by Mesos if present when tasks fail due to resource limit violations.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java d4de225c7a96b26e493a3e77a2245ec132e06a08
src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 62ada33abcef977e722362904d671352e7f9947a
Diff: https://reviews.apache.org/r/45754/diff/
Testing
-------
./gradlew build -Pq
See attached screenshot for the Mesos-provided message we'll show in the case.
File Attachments
----------------
Exampled failed task
https://reviews.apache.org/media/uploaded/files/2016/04/05/df35aa54-2ef3-4e3b-8c9a-d3fe9bd26f74__Screen_Shot_2016-04-05_at_11.54.01_AM.png
Thanks,
Joshua Cohen
Re: Review Request 45754: Use message provided by Mesos if present
when tasks fail due to resource limit violations.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45754/#review127142
-----------------------------------------------------------
Ship it!
Master (663d13f) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 5, 2016, 4:56 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45754/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 4:56 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use message provided by Mesos if present when tasks fail due to resource limit violations.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java d4de225c7a96b26e493a3e77a2245ec132e06a08
> src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 62ada33abcef977e722362904d671352e7f9947a
>
> Diff: https://reviews.apache.org/r/45754/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
> See attached screenshot for the Mesos-provided message we'll show in the case.
>
>
> File Attachments
> ----------------
>
> Exampled failed task
> https://reviews.apache.org/media/uploaded/files/2016/04/05/df35aa54-2ef3-4e3b-8c9a-d3fe9bd26f74__Screen_Shot_2016-04-05_at_11.54.01_AM.png
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 45754: Use message provided by Mesos if present
when tasks fail due to resource limit violations.
Posted by Joshua Cohen <jc...@apache.org>.
> On April 5, 2016, 5:18 p.m., Maxim Khutornenko wrote:
> > src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java, line 179
> > <https://reviews.apache.org/r/45754/diff/1/?file=1326081#file1326081line179>
> >
> > The number of these almost identical message tests grew up over time. Mind refactoring the common parts into a helper method instead?
Done, thanks for the nudge.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45754/#review127143
-----------------------------------------------------------
On April 5, 2016, 5:40 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45754/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 5:40 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use message provided by Mesos if present when tasks fail due to resource limit violations.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java d4de225c7a96b26e493a3e77a2245ec132e06a08
> src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 62ada33abcef977e722362904d671352e7f9947a
>
> Diff: https://reviews.apache.org/r/45754/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
> See attached screenshot for the Mesos-provided message we'll show in the case.
>
>
> File Attachments
> ----------------
>
> Exampled failed task
> https://reviews.apache.org/media/uploaded/files/2016/04/05/df35aa54-2ef3-4e3b-8c9a-d3fe9bd26f74__Screen_Shot_2016-04-05_at_11.54.01_AM.png
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 45754: Use message provided by Mesos if present
when tasks fail due to resource limit violations.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45754/#review127143
-----------------------------------------------------------
src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java (line 179)
<https://reviews.apache.org/r/45754/#comment190278>
The number of these almost identical message tests grew up over time. Mind refactoring the common parts into a helper method instead?
- Maxim Khutornenko
On April 5, 2016, 4:56 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45754/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 4:56 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use message provided by Mesos if present when tasks fail due to resource limit violations.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java d4de225c7a96b26e493a3e77a2245ec132e06a08
> src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 62ada33abcef977e722362904d671352e7f9947a
>
> Diff: https://reviews.apache.org/r/45754/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
> See attached screenshot for the Mesos-provided message we'll show in the case.
>
>
> File Attachments
> ----------------
>
> Exampled failed task
> https://reviews.apache.org/media/uploaded/files/2016/04/05/df35aa54-2ef3-4e3b-8c9a-d3fe9bd26f74__Screen_Shot_2016-04-05_at_11.54.01_AM.png
>
>
> Thanks,
>
> Joshua Cohen
>
>