You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/11/14 00:39:45 UTC

[kudu-CR] KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5056

to look at the new patch set (#2).

Change subject: KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests
......................................................................

KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests

This goes another step into removing safe time from mvcc. In this
patch we make tablet tests always use one instance of LocalTabletWriter
and use the same path as with regular transactions: i.e. always use
pre-assigned timestamps.

This means that tests now need to share an instance of LocalTabletWriter
since timestamp assignement does not retry until it finds an unassigned
timestamp anymore.

Still left for a follow-up patch is the complete removal of safe time
from mvcc as that requires changing the tests that interct with
MvccManager directly.

Change-Id: Ic08be57ed5ab38e3980c85102971c5998f7da2dc
---
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_history_gc-test.cc
6 files changed, 170 insertions(+), 139 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/5056/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic08be57ed5ab38e3980c85102971c5998f7da2dc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot