You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Istvan Toth (Jira)" <ji...@apache.org> on 2021/03/19 16:44:00 UTC

[jira] [Resolved] (PHOENIX-6419) Unused getResolverForQuery() in QueryCompiler.verifySCN()

     [ https://issues.apache.org/jira/browse/PHOENIX-6419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Istvan Toth resolved PHOENIX-6419.
----------------------------------
    Fix Version/s: 5.1.2
                   5.2.0
                   4.17.0
       Resolution: Fixed

Committed to master, 5.1, 4.x.
I am not sure who should commit to 4.16.

Thanks for the reviews [~vjasani] [~gjacoby]

> Unused getResolverForQuery() in QueryCompiler.verifySCN()
> ---------------------------------------------------------
>
>                 Key: PHOENIX-6419
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6419
>             Project: Phoenix
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 5.1.0, 4.16.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Trivial
>             Fix For: 4.17.0, 5.2.0, 5.1.2
>
>
> in org.apache.phoenix.compile.QueryCompiler.verifySCN()
> we create a resolver that we don't use.
> {code:java}
>         ColumnResolver resolver =
>             FromCompiler.getResolverForQuery(select, conn);
> {code}
> AFAICT this has no side effects that we need, and should be removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)