You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by swegner <gi...@git.apache.org> on 2016/07/14 15:49:58 UTC
[GitHub] incubator-beam pull request #654: [BEAM-339] Archetype project version shoul...
GitHub user swegner opened a pull request:
https://github.com/apache/incubator-beam/pull/654
[BEAM-339] Archetype project version shouldn't be coupled to Beam version
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Follow-up from [a previous archetype PR](https://github.com/apache/incubator-beam/pull/444/files/ba55042275bd9b525ee8716e4e1007b7924a647f#r66819150), the maven artifact version for the generated project should not be tied to the version of Beam. The generated module is a new user project, so the version should represent "initial version", i.e. 0.1.
This PR drops the -SNAPSHOT suffix from the version and fixes the version to 0.1 in our tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swegner/incubator-beam archetype-version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/654.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #654
----
commit 5b317b852b1fac9f6320e1a074238e6e7da77b79
Author: Scott Wegner <sw...@google.com>
Date: 2016-07-13T22:59:16Z
Archetype generated projects shouldn't have SNAPSHOT version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #654: [BEAM-339] Archetype project version shoul...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/654
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---