You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2021/01/06 08:16:21 UTC
[GitHub] [incubator-tuweni] atoulme opened a new pull request #189: Use GuardedByteArray to store the secret key of the wallet
atoulme opened a new pull request #189:
URL: https://github.com/apache/incubator-tuweni/pull/189
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/apache/incubator-tuweni/blob/master/CONTRIBUTING.md -->
## PR description
Secure the contents of the secret key into a "secured" Bytes object which is using GuardedBytesArray under the covers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #189:
URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report
> Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=desc) (e487d70) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `0.05%`.
> The diff coverage is `48.14%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #189 +/- ##
============================================
- Coverage 65.51% 65.46% -0.06%
- Complexity 4169 4190 +21
============================================
Files 372 374 +2
Lines 19951 20058 +107
Branches 2594 2607 +13
============================================
+ Hits 13071 13130 +59
- Misses 5421 5460 +39
- Partials 1459 1468 +9
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `49.12% <ø> (ø)` | `0.00 <ø> (ø)` | |
| unit | `60.76% <48.14%> (-0.04%)` | `0.00 <18.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...src/main/java/org/apache/tuweni/bytes/Bytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlczMyLmphdmE=) | `50.00% <0.00%> (-5.32%)` | `13.00 <0.00> (ø)` | |
| [...g/apache/tuweni/bytes/GuardedByteArrayBytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMzMi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/bytes/GuardedByteArrayBytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMuamF2YQ==) | `55.29% <55.29%> (ø)` | `16.00 <16.00> (?)` | |
| [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.79% <100.00%> (+0.12%)` | `153.00 <2.00> (+2.00)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `93.10% <100.00%> (+3.81%)` | `3.00 <0.00> (ø)` | |
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `69.64% <0.00%> (-3.58%)` | `0.00% <0.00%> (ø%)` | |
| [.../kotlin/org/apache/tuweni/kv/RedisKeyValueStore.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-a3Yvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2t2L1JlZGlzS2V5VmFsdWVTdG9yZS5rdA==) | `70.31% <0.00%> (-1.57%)` | `6.00% <0.00%> (-1.00%)` | |
| [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `70.63% <0.00%> (-0.80%)` | `0.00% <0.00%> (ø%)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.88% <0.00%> (-0.24%)` | `0.00% <0.00%> (ø%)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=footer). Last update [72681ad...e487d70](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #189:
URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report
> Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=desc) (6b7aa59) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `4.79%`.
> The diff coverage is `48.14%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #189 +/- ##
============================================
- Coverage 65.51% 60.72% -4.80%
+ Complexity 4169 3891 -278
============================================
Files 372 349 -23
Lines 19951 19677 -274
Branches 2594 2600 +6
============================================
- Hits 13071 11948 -1123
- Misses 5421 6378 +957
+ Partials 1459 1351 -108
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.72% <48.14%> (-0.08%)` | `0.00 <18.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...src/main/java/org/apache/tuweni/bytes/Bytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlczMyLmphdmE=) | `50.00% <0.00%> (-5.32%)` | `13.00 <0.00> (ø)` | |
| [...g/apache/tuweni/bytes/GuardedByteArrayBytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMzMi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/bytes/GuardedByteArrayBytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMuamF2YQ==) | `55.29% <55.29%> (ø)` | `16.00 <16.00> (?)` | |
| [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.79% <100.00%> (+0.12%)` | `153.00 <2.00> (+2.00)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `93.10% <100.00%> (+3.81%)` | `3.00 <0.00> (ø)` | |
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [72 more](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=footer). Last update [72681ad...6b7aa59](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #189:
URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report
> Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=desc) (c71f0b9) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `0.07%`.
> The diff coverage is `48.14%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #189 +/- ##
============================================
- Coverage 65.51% 65.44% -0.08%
- Complexity 4169 4187 +18
============================================
Files 372 374 +2
Lines 19951 20058 +107
Branches 2594 2607 +13
============================================
+ Hits 13071 13126 +55
- Misses 5421 5468 +47
- Partials 1459 1464 +5
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `49.22% <ø> (+0.10%)` | `0.00 <ø> (ø)` | |
| unit | `60.74% <48.14%> (-0.06%)` | `0.00 <18.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...src/main/java/org/apache/tuweni/bytes/Bytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlczMyLmphdmE=) | `50.00% <0.00%> (-5.32%)` | `13.00 <0.00> (ø)` | |
| [...g/apache/tuweni/bytes/GuardedByteArrayBytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMzMi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/bytes/GuardedByteArrayBytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMuamF2YQ==) | `55.29% <55.29%> (ø)` | `16.00 <16.00> (?)` | |
| [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.79% <100.00%> (+0.12%)` | `153.00 <2.00> (+2.00)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `93.10% <100.00%> (+3.81%)` | `3.00 <0.00> (ø)` | |
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `69.64% <0.00%> (-3.58%)` | `0.00% <0.00%> (ø%)` | |
| [.../kotlin/org/apache/tuweni/kv/RedisKeyValueStore.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-a3Yvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2t2L1JlZGlzS2V5VmFsdWVTdG9yZS5rdA==) | `70.31% <0.00%> (-1.57%)` | `6.00% <0.00%> (-1.00%)` | |
| [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `70.63% <0.00%> (-0.80%)` | `0.00% <0.00%> (ø%)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=footer). Last update [72681ad...c71f0b9](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #189:
URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report
> Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=desc) (c71f0b9) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `16.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #189 +/- ##
=============================================
- Coverage 65.51% 49.22% -16.29%
+ Complexity 4169 616 -3553
=============================================
Files 372 128 -244
Lines 19951 5895 -14056
Branches 2594 676 -1918
=============================================
- Hits 13071 2902 -10169
+ Misses 5421 2699 -2722
+ Partials 1459 294 -1165
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `49.22% <ø> (+0.10%)` | `0.00 <ø> (ø)` | |
| unit | `?` | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/tuweni/ethstats/TxStats.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9UeFN0YXRzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...weni/scuttlebutt/handshake/HandshakeException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL0hhbmRzaGFrZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ebutt/handshake/SecureScuttlebuttStreamServer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL1NlY3VyZVNjdXR0bGVidXR0U3RyZWFtU2VydmVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...in/kotlin/org/apache/tuweni/devp2p/eth/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9NZXNzYWdlcy5rdA==) | `0.00% <0.00%> (-94.50%)` | `0.00% <0.00%> (ø%)` | |
| [...kotlin/org/apache/tuweni/devp2p/v5/topic/Ticket.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVGlja2V0Lmt0) | `0.00% <0.00%> (-83.88%)` | `0.00% <0.00%> (-9.00%)` | |
| [...lin/org/apache/tuweni/devp2p/eth/EthSubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhTdWJwcm90b2NvbC5rdA==) | `0.00% <0.00%> (-78.95%)` | `0.00% <0.00%> (-12.00%)` | |
| [...ain/kotlin/org/apache/tuweni/devp2p/v5/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZXMua3Q=) | `18.88% <0.00%> (-72.73%)` | `0.00% <0.00%> (ø%)` | |
| [...in/org/apache/tuweni/devp2p/v5/topic/TopicTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVG9waWNUYWJsZS5rdA==) | `17.64% <0.00%> (-67.65%)` | `2.00% <0.00%> (-12.00%)` | |
| [...src/main/kotlin/org/apache/tuweni/devp2p/Packet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGFja2V0Lmt0) | `16.73% <0.00%> (-62.67%)` | `4.00% <0.00%> (-2.00%)` | |
| [...p/src/main/kotlin/org/apache/tuweni/devp2p/Node.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvTm9kZS5rdA==) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [285 more](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=footer). Last update [72681ad...c71f0b9](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #189:
URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report
> Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=desc) (e487d70) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `0.05%`.
> The diff coverage is `48.14%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #189 +/- ##
============================================
- Coverage 65.51% 65.46% -0.06%
- Complexity 4169 4190 +21
============================================
Files 372 374 +2
Lines 19951 20058 +107
Branches 2594 2607 +13
============================================
+ Hits 13071 13130 +59
- Misses 5421 5460 +39
- Partials 1459 1468 +9
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `49.12% <ø> (ø)` | `0.00 <ø> (ø)` | |
| unit | `60.76% <48.14%> (-0.04%)` | `0.00 <18.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...src/main/java/org/apache/tuweni/bytes/Bytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlczMyLmphdmE=) | `50.00% <0.00%> (-5.32%)` | `13.00 <0.00> (ø)` | |
| [...g/apache/tuweni/bytes/GuardedByteArrayBytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMzMi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/bytes/GuardedByteArrayBytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMuamF2YQ==) | `55.29% <55.29%> (ø)` | `16.00 <16.00> (?)` | |
| [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.79% <100.00%> (+0.12%)` | `153.00 <2.00> (+2.00)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `93.10% <100.00%> (+3.81%)` | `3.00 <0.00> (ø)` | |
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `69.64% <0.00%> (-3.58%)` | `0.00% <0.00%> (ø%)` | |
| [.../kotlin/org/apache/tuweni/kv/RedisKeyValueStore.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-a3Yvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2t2L1JlZGlzS2V5VmFsdWVTdG9yZS5rdA==) | `70.31% <0.00%> (-1.57%)` | `6.00% <0.00%> (-1.00%)` | |
| [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `70.63% <0.00%> (-0.80%)` | `0.00% <0.00%> (ø%)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.88% <0.00%> (-0.24%)` | `0.00% <0.00%> (ø%)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=footer). Last update [72681ad...6b7aa59](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #189:
URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report
> Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=desc) (6b7aa59) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `0.09%`.
> The diff coverage is `48.14%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #189 +/- ##
============================================
- Coverage 65.51% 65.42% -0.10%
- Complexity 4169 4187 +18
============================================
Files 372 374 +2
Lines 19951 20058 +107
Branches 2594 2607 +13
============================================
+ Hits 13071 13122 +51
- Misses 5421 5469 +48
- Partials 1459 1467 +8
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `49.12% <ø> (ø)` | `0.00 <ø> (ø)` | |
| unit | `60.72% <48.14%> (-0.08%)` | `0.00 <18.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...src/main/java/org/apache/tuweni/bytes/Bytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlczMyLmphdmE=) | `50.00% <0.00%> (-5.32%)` | `13.00 <0.00> (ø)` | |
| [...g/apache/tuweni/bytes/GuardedByteArrayBytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMzMi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/bytes/GuardedByteArrayBytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMuamF2YQ==) | `55.29% <55.29%> (ø)` | `16.00 <16.00> (?)` | |
| [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.79% <100.00%> (+0.12%)` | `153.00 <2.00> (+2.00)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `93.10% <100.00%> (+3.81%)` | `3.00 <0.00> (ø)` | |
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `69.64% <0.00%> (-3.58%)` | `0.00% <0.00%> (ø%)` | |
| [.../kotlin/org/apache/tuweni/kv/RedisKeyValueStore.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-a3Yvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2t2L1JlZGlzS2V5VmFsdWVTdG9yZS5rdA==) | `70.31% <0.00%> (-1.57%)` | `6.00% <0.00%> (-1.00%)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.40% <0.00%> (-0.71%)` | `0.00% <0.00%> (ø%)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=footer). Last update [72681ad...6b7aa59](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #189: Use GuardedByteArray to store the secret key of the wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #189:
URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report
> Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=desc) (95d84c5) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `16.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #189 +/- ##
=============================================
- Coverage 65.51% 49.17% -16.34%
+ Complexity 4169 612 -3557
=============================================
Files 372 128 -244
Lines 19951 5895 -14056
Branches 2594 676 -1918
=============================================
- Hits 13071 2899 -10172
+ Misses 5421 2701 -2720
+ Partials 1459 295 -1164
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `49.17% <ø> (+0.05%)` | `0.00 <ø> (ø)` | |
| unit | `?` | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/tuweni/ethstats/TxStats.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9UeFN0YXRzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...weni/scuttlebutt/handshake/HandshakeException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL0hhbmRzaGFrZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ebutt/handshake/SecureScuttlebuttStreamServer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL1NlY3VyZVNjdXR0bGVidXR0U3RyZWFtU2VydmVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...in/kotlin/org/apache/tuweni/devp2p/eth/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9NZXNzYWdlcy5rdA==) | `0.00% <0.00%> (-94.50%)` | `0.00% <0.00%> (ø%)` | |
| [...kotlin/org/apache/tuweni/devp2p/v5/topic/Ticket.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVGlja2V0Lmt0) | `0.00% <0.00%> (-83.88%)` | `0.00% <0.00%> (-9.00%)` | |
| [...lin/org/apache/tuweni/devp2p/eth/EthSubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhTdWJwcm90b2NvbC5rdA==) | `0.00% <0.00%> (-78.95%)` | `0.00% <0.00%> (-12.00%)` | |
| [...ain/kotlin/org/apache/tuweni/devp2p/v5/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZXMua3Q=) | `18.88% <0.00%> (-72.73%)` | `0.00% <0.00%> (ø%)` | |
| [...in/org/apache/tuweni/devp2p/v5/topic/TopicTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVG9waWNUYWJsZS5rdA==) | `17.64% <0.00%> (-67.65%)` | `2.00% <0.00%> (-12.00%)` | |
| [...src/main/kotlin/org/apache/tuweni/devp2p/Packet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGFja2V0Lmt0) | `16.73% <0.00%> (-62.67%)` | `4.00% <0.00%> (-2.00%)` | |
| [...p/src/main/kotlin/org/apache/tuweni/devp2p/Node.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvTm9kZS5rdA==) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [284 more](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=footer). Last update [72681ad...c71f0b9](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #189:
URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report
> Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=desc) (c71f0b9) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `0.07%`.
> The diff coverage is `48.14%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #189 +/- ##
============================================
- Coverage 65.51% 65.44% -0.08%
- Complexity 4169 4187 +18
============================================
Files 372 374 +2
Lines 19951 20058 +107
Branches 2594 2607 +13
============================================
+ Hits 13071 13126 +55
- Misses 5421 5468 +47
- Partials 1459 1464 +5
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `49.22% <ø> (+0.10%)` | `0.00 <ø> (ø)` | |
| unit | `60.74% <48.14%> (-0.06%)` | `0.00 <18.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...src/main/java/org/apache/tuweni/bytes/Bytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlczMyLmphdmE=) | `50.00% <0.00%> (-5.32%)` | `13.00 <0.00> (ø)` | |
| [...g/apache/tuweni/bytes/GuardedByteArrayBytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMzMi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/bytes/GuardedByteArrayBytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMuamF2YQ==) | `55.29% <55.29%> (ø)` | `16.00 <16.00> (?)` | |
| [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.79% <100.00%> (+0.12%)` | `153.00 <2.00> (+2.00)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `93.10% <100.00%> (+3.81%)` | `3.00 <0.00> (ø)` | |
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `69.64% <0.00%> (-3.58%)` | `0.00% <0.00%> (ø%)` | |
| [.../kotlin/org/apache/tuweni/kv/RedisKeyValueStore.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-a3Yvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2t2L1JlZGlzS2V5VmFsdWVTdG9yZS5rdA==) | `70.31% <0.00%> (-1.57%)` | `6.00% <0.00%> (-1.00%)` | |
| [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `70.63% <0.00%> (-0.80%)` | `0.00% <0.00%> (ø%)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=footer). Last update [72681ad...e487d70](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #189:
URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report
> Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=desc) (e487d70) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `4.74%`.
> The diff coverage is `48.14%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #189 +/- ##
============================================
- Coverage 65.51% 60.76% -4.75%
+ Complexity 4169 3894 -275
============================================
Files 372 349 -23
Lines 19951 19677 -274
Branches 2594 2600 +6
============================================
- Hits 13071 11957 -1114
- Misses 5421 6369 +948
+ Partials 1459 1351 -108
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.76% <48.14%> (-0.04%)` | `0.00 <18.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...src/main/java/org/apache/tuweni/bytes/Bytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlczMyLmphdmE=) | `50.00% <0.00%> (-5.32%)` | `13.00 <0.00> (ø)` | |
| [...g/apache/tuweni/bytes/GuardedByteArrayBytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMzMi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/bytes/GuardedByteArrayBytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMuamF2YQ==) | `55.29% <55.29%> (ø)` | `16.00 <16.00> (?)` | |
| [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.79% <100.00%> (+0.12%)` | `153.00 <2.00> (+2.00)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `93.10% <100.00%> (+3.81%)` | `3.00 <0.00> (ø)` | |
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [74 more](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=footer). Last update [72681ad...e487d70](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme merged pull request #189: Use GuardedByteArray to store the secret key of the wallet
Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #189:
URL: https://github.com/apache/incubator-tuweni/pull/189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme merged pull request #189: Use GuardedByteArray to store the secret key of the wallet
Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #189:
URL: https://github.com/apache/incubator-tuweni/pull/189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #189:
URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #189: Use GuardedByteArray to store the secret key of the wallet
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #189:
URL: https://github.com/apache/incubator-tuweni/pull/189#issuecomment-756604656
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=h1) Report
> Merging [#189](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=desc) (95d84c5) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/2293c03b05ed867d239a47814940b122aeee553b?el=desc) (2293c03) will **decrease** coverage by `0.15%`.
> The diff coverage is `48.14%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #189 +/- ##
============================================
- Coverage 65.51% 65.36% -0.16%
- Complexity 4169 4184 +15
============================================
Files 372 374 +2
Lines 19951 20058 +107
Branches 2594 2607 +13
============================================
+ Hits 13071 13110 +39
- Misses 5421 5483 +62
- Partials 1459 1465 +6
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `49.17% <ø> (+0.05%)` | `0.00 <ø> (ø)` | |
| unit | `60.69% <48.14%> (-0.11%)` | `0.00 <18.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...src/main/java/org/apache/tuweni/bytes/Bytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlczMyLmphdmE=) | `50.00% <0.00%> (-5.32%)` | `13.00 <0.00> (ø)` | |
| [...g/apache/tuweni/bytes/GuardedByteArrayBytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMzMi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/bytes/GuardedByteArrayBytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9HdWFyZGVkQnl0ZUFycmF5Qnl0ZXMuamF2YQ==) | `55.29% <55.29%> (ø)` | `16.00 <16.00> (?)` | |
| [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.79% <100.00%> (+0.12%)` | `153.00 <2.00> (+2.00)` | |
| [...src/main/kotlin/org/apache/tuweni/wallet/Wallet.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-d2FsbGV0L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS93YWxsZXQvV2FsbGV0Lmt0) | `93.10% <100.00%> (+3.81%)` | `3.00 <0.00> (ø)` | |
| [...a/org/apache/tuweni/ethstats/EthStatsReporter.java](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9FdGhTdGF0c1JlcG9ydGVyLmphdmE=) | `66.00% <0.00%> (-4.00%)` | `22.00% <0.00%> (-2.00%)` | |
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `69.64% <0.00%> (-3.58%)` | `0.00% <0.00%> (ø%)` | |
| [...apache/tuweni/concurrent/coroutines/AsyncResult.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNSZXN1bHQua3Q=) | `78.72% <0.00%> (-2.13%)` | `0.00% <0.00%> (ø%)` | |
| [.../kotlin/org/apache/tuweni/kv/RedisKeyValueStore.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-a3Yvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2t2L1JlZGlzS2V5VmFsdWVTdG9yZS5rdA==) | `70.31% <0.00%> (-1.57%)` | `6.00% <0.00%> (-1.00%)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.40% <0.00%> (-0.71%)` | `0.00% <0.00%> (ø%)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-tuweni/pull/189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=footer). Last update [72681ad...c71f0b9](https://codecov.io/gh/apache/incubator-tuweni/pull/189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org