You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2016/08/11 22:33:14 UTC
[Impala-CR](cdh5-trunk) IMPALA-3881: Add DataTables 1.10.12 to www/
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3881: Add DataTables 1.10.12 to www/
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3679/1/www/datatables.js
File www/datatables.js:
> It doesn't look we check in non-minimised files for the other dependencies
Bootstrap has the non-minimised files. I think JQuery can be downloaded in minimised form only, which is probably why the non-minimised files are missing.
I think it's probably better, for now, to have the whole library included at once.
Line 21: * Released under the MIT license
> I think we should check in actual license text, since all we have here is t
I'll do something similar separately as part of IMPALA-3853, which adds licenses for third-party dependencies.
--
To view, visit http://gerrit.cloudera.org:8080/3679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1001870a50fbf21efed29a446815436da1a36fa
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes