You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Logan McNaughton <lo...@bacoosta.com> on 2013/02/05 18:47:42 UTC
Re: Review Request: Add documentation for cloud-setup-databases
(CLOUDSTACK-404)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9292/
-----------------------------------------------------------
(Updated Feb. 5, 2013, 5:47 p.m.)
Review request for cloudstack.
Summary (updated)
-----------------
Add documentation for cloud-setup-databases (CLOUDSTACK-404)
Description
-------
This adds documentation for the changes introduced into 4.0.1 via commit 947d8cc6de6b69394457fd6f07d3bba82e14fd9f
Diffs
-----
docs/en-US/management-server-install-db-external.xml 3bba45f
docs/en-US/management-server-install-db-local.xml 3e09c55
docs/en-US/management-server-install-multi-node.xml e61f623
Diff: https://reviews.apache.org/r/9292/diff/
Testing
-------
I have not tested the -i option of cloud-setup-databases, however that commit has already been merged. This is simply for the documentation of the already-merged feature. I have created the documentation using Publican and it works fine
Thanks,
Logan McNaughton
Re: Review Request: Add documentation for cloud-setup-databases
(CLOUDSTACK-404)
Posted by Logan McNaughton <lo...@bacoosta.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9292/#review16464
-----------------------------------------------------------
Without the <prompt> it makes that line bright pink which looks off. Also, that's how the docs have "cloud-setup-management" the other time it is mentioned.
- Logan McNaughton
On Feb. 5, 2013, 5:47 p.m., Logan McNaughton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9292/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 5:47 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This adds documentation for the changes introduced into 4.0.1 via commit 947d8cc6de6b69394457fd6f07d3bba82e14fd9f
>
>
> Diffs
> -----
>
> docs/en-US/management-server-install-db-external.xml 3bba45f
> docs/en-US/management-server-install-db-local.xml 3e09c55
> docs/en-US/management-server-install-multi-node.xml e61f623
>
> Diff: https://reviews.apache.org/r/9292/diff/
>
>
> Testing
> -------
>
> I have not tested the -i option of cloud-setup-databases, however that commit has already been merged. This is simply for the documentation of the already-merged feature. I have created the documentation using Publican and it works fine
>
>
> Thanks,
>
> Logan McNaughton
>
>
RE: Review Request: Add documentation for cloud-setup-databases
(CLOUDSTACK-404)
Posted by Animesh Chaturvedi <an...@citrix.com>.
Rohit
Thanks for taking care of this patch
> -----Original Message-----
> From: Rohit Yadav [mailto:noreply@reviews.apache.org] On Behalf Of Rohit
> Yadav
> Sent: Tuesday, February 12, 2013 7:34 AM
> To: cloudstack; Logan McNaughton; Rohit Yadav
> Subject: Re: Review Request: Add documentation for cloud-setup-databases
> (CLOUDSTACK-404)
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9292/#review16467
> -----------------------------------------------------------
>
> Ship it!
>
>
> Awesome thanks. That was my only concern. Committing this right away. Thank
> you for your patch.
>
> - Rohit Yadav
>
>
> On Feb. 5, 2013, 5:47 p.m., Logan McNaughton wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9292/
> > -----------------------------------------------------------
> >
> > (Updated Feb. 5, 2013, 5:47 p.m.)
> >
> >
> > Review request for cloudstack.
> >
> >
> > Description
> > -------
> >
> > This adds documentation for the changes introduced into 4.0.1 via commit
> 947d8cc6de6b69394457fd6f07d3bba82e14fd9f
> >
> >
> > Diffs
> > -----
> >
> > docs/en-US/management-server-install-db-external.xml 3bba45f
> > docs/en-US/management-server-install-db-local.xml 3e09c55
> > docs/en-US/management-server-install-multi-node.xml e61f623
> >
> > Diff: https://reviews.apache.org/r/9292/diff/
> >
> >
> > Testing
> > -------
> >
> > I have not tested the -i option of cloud-setup-databases, however that commit
> has already been merged. This is simply for the documentation of the already-
> merged feature. I have created the documentation using Publican and it works
> fine
> >
> >
> > Thanks,
> >
> > Logan McNaughton
> >
> >
Re: Review Request: Add documentation for cloud-setup-databases
(CLOUDSTACK-404)
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9292/#review16467
-----------------------------------------------------------
Ship it!
Awesome thanks. That was my only concern. Committing this right away. Thank you for your patch.
- Rohit Yadav
On Feb. 5, 2013, 5:47 p.m., Logan McNaughton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9292/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 5:47 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This adds documentation for the changes introduced into 4.0.1 via commit 947d8cc6de6b69394457fd6f07d3bba82e14fd9f
>
>
> Diffs
> -----
>
> docs/en-US/management-server-install-db-external.xml 3bba45f
> docs/en-US/management-server-install-db-local.xml 3e09c55
> docs/en-US/management-server-install-multi-node.xml e61f623
>
> Diff: https://reviews.apache.org/r/9292/diff/
>
>
> Testing
> -------
>
> I have not tested the -i option of cloud-setup-databases, however that commit has already been merged. This is simply for the documentation of the already-merged feature. I have created the documentation using Publican and it works fine
>
>
> Thanks,
>
> Logan McNaughton
>
>
Re: Review Request: Add documentation for cloud-setup-databases
(CLOUDSTACK-404)
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9292/#review16460
-----------------------------------------------------------
Ship it!
This is alright, can anyone from the doc team do a final review. I saw <prompt>#</prompt>, don't know if this markup is alright.
- Rohit Yadav
On Feb. 5, 2013, 5:47 p.m., Logan McNaughton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9292/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 5:47 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This adds documentation for the changes introduced into 4.0.1 via commit 947d8cc6de6b69394457fd6f07d3bba82e14fd9f
>
>
> Diffs
> -----
>
> docs/en-US/management-server-install-db-external.xml 3bba45f
> docs/en-US/management-server-install-db-local.xml 3e09c55
> docs/en-US/management-server-install-multi-node.xml e61f623
>
> Diff: https://reviews.apache.org/r/9292/diff/
>
>
> Testing
> -------
>
> I have not tested the -i option of cloud-setup-databases, however that commit has already been merged. This is simply for the documentation of the already-merged feature. I have created the documentation using Publican and it works fine
>
>
> Thanks,
>
> Logan McNaughton
>
>
RE: Review Request: Add documentation for cloud-setup-databases
(CLOUDSTACK-404)
Posted by Animesh Chaturvedi <an...@citrix.com>.
Rohit can you review this doc patch?
> -----Original Message-----
> From: Logan McNaughton [mailto:noreply@reviews.apache.org] On Behalf Of
> Logan McNaughton
> Sent: Tuesday, February 05, 2013 9:48 AM
> To: cloudstack; Logan McNaughton
> Subject: Re: Review Request: Add documentation for cloud-setup-databases
> (CLOUDSTACK-404)
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9292/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 5:47 p.m.)
>
>
> Review request for cloudstack.
>
>
> Summary (updated)
> -----------------
>
> Add documentation for cloud-setup-databases (CLOUDSTACK-404)
>
>
> Description
> -------
>
> This adds documentation for the changes introduced into 4.0.1 via commit
> 947d8cc6de6b69394457fd6f07d3bba82e14fd9f
>
>
> Diffs
> -----
>
> docs/en-US/management-server-install-db-external.xml 3bba45f
> docs/en-US/management-server-install-db-local.xml 3e09c55
> docs/en-US/management-server-install-multi-node.xml e61f623
>
> Diff: https://reviews.apache.org/r/9292/diff/
>
>
> Testing
> -------
>
> I have not tested the -i option of cloud-setup-databases, however that commit
> has already been merged. This is simply for the documentation of the already-
> merged feature. I have created the documentation using Publican and it works
> fine
>
>
> Thanks,
>
> Logan McNaughton