You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by se...@apache.org on 2016/02/24 11:39:44 UTC
svn commit: r1732060 - in
/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api:
LdapConnectionConfig.java LdapNetworkConnection.java
Author: seelmann
Date: Wed Feb 24 10:39:43 2016
New Revision: 1732060
URL: http://svn.apache.org/viewvc?rev=1732060&view=rev
Log:
Use loopback address to avoid DNS lookup
Modified:
directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionConfig.java
directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java
Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionConfig.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionConfig.java?rev=1732060&r1=1732059&r2=1732060&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionConfig.java (original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionConfig.java Wed Feb 24 10:39:43 2016
@@ -21,8 +21,6 @@
package org.apache.directory.ldap.client.api;
-import java.net.InetAddress;
-import java.net.UnknownHostException;
import java.security.KeyStore;
import java.security.KeyStoreException;
import java.security.NoSuchAlgorithmException;
@@ -35,6 +33,7 @@ import javax.net.ssl.X509TrustManager;
import org.apache.directory.api.ldap.codec.api.BinaryAttributeDetector;
import org.apache.directory.api.ldap.codec.api.LdapApiService;
+import org.apache.directory.api.util.Network;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -298,14 +297,7 @@ public class LdapConnectionConfig
*/
public String getDefaultLdapHost()
{
- try
- {
- return InetAddress.getLocalHost().getHostName();
- }
- catch ( UnknownHostException uhe )
- {
- return DEFAULT_LDAP_HOST;
- }
+ return Network.LOOPBACK_HOSTNAME;
}
Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java?rev=1732060&r1=1732059&r2=1732060&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java (original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java Wed Feb 24 10:39:43 2016
@@ -28,10 +28,8 @@ import java.io.IOException;
import java.io.OutputStreamWriter;
import java.io.Writer;
import java.net.ConnectException;
-import java.net.InetAddress;
import java.net.InetSocketAddress;
import java.net.SocketAddress;
-import java.net.UnknownHostException;
import java.nio.channels.UnresolvedAddressException;
import java.nio.charset.Charset;
import java.security.PrivilegedExceptionAction;
@@ -144,6 +142,7 @@ import org.apache.directory.api.ldap.mod
import org.apache.directory.api.ldap.model.schema.registries.Registries;
import org.apache.directory.api.ldap.model.schema.registries.SchemaLoader;
import org.apache.directory.api.ldap.schema.manager.impl.DefaultSchemaManager;
+import org.apache.directory.api.util.Network;
import org.apache.directory.api.util.StringConstants;
import org.apache.directory.api.util.Strings;
import org.apache.directory.ldap.client.api.callback.SaslCallbackHandler;
@@ -496,14 +495,7 @@ public class LdapNetworkConnection exten
// Default to localhost if null
if ( Strings.isEmpty( server ) )
{
- try
- {
- config.setLdapHost( InetAddress.getLocalHost().getHostName() );
- }
- catch ( UnknownHostException uhe )
- {
- config.setLdapHost( LdapConnectionConfig.DEFAULT_LDAP_HOST );
- }
+ config.setLdapHost( Network.LOOPBACK_HOSTNAME );
}
else