You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/15 12:43:53 UTC
[GitHub] [pulsar] 315157973 opened a new pull request #7821: Support deduplication on topic level
315157973 opened a new pull request #7821:
URL: https://github.com/apache/pulsar/pull/7821
### Motivation
Support set `DeduplicationEnabled` on topic level
### Modifications
Support set/get/remove `DeduplicationEnabled` policy on topic level.
### Verifying this change
Added Unit test to verify set/get/remove `DeduplicationEnabled` policy at Topic level work as expected when Topic level policy is enabled/disabled
`org.apache.pulsar.broker.service.persistent.TopicDuplicationTest`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7821: Support deduplication on topic level
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7821:
URL: https://github.com/apache/pulsar/pull/7821#issuecomment-674535939
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7821: Support deduplication on topic level
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7821:
URL: https://github.com/apache/pulsar/pull/7821#issuecomment-675840887
@315157973 Could you please resolve the conflicts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #7821: Support deduplication on topic level
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7821:
URL: https://github.com/apache/pulsar/pull/7821
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jianyun8023 commented on a change in pull request #7821: Support deduplication on topic level
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on a change in pull request #7821:
URL: https://github.com/apache/pulsar/pull/7821#discussion_r472884791
##########
File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -1800,4 +1800,49 @@ void setDelayedDeliveryPolicy(String topic
* @param topic Topic name
*/
CompletableFuture<Void> removePersistenceAsync(String topic);
+
+ /**
+ * get deduplication enabled of a topic.
+ * @param topic
+ * @return
+ * @throws PulsarAdminException
+ */
+ Boolean getDeduplicationEnabled(String topic) throws PulsarAdminException;
+
+ /**
+ * get deduplication enabled of a topic asynchronously.
+ * @param topic
+ * @return
+ */
+ CompletableFuture<Boolean> getDeduplicationEnabledAsync(String topic);
+
+ /**
+ * set deduplication enabled of a topic.
+ * @param topic
+ * @param enabled
+ * @throws PulsarAdminException
+ */
+ void setDeduplicationEnabled(String topic, boolean enabled) throws PulsarAdminException;
+
+ /**
+ * set deduplication enabled of a topic asynchronously.
+ * @param topic
+ * @param enabled
+ * @return
+ */
+ CompletableFuture<Void> setDeduplicationEnabledAsync(String topic, boolean enabled);
+
+ /**
+ * remove deduplication enabled of a topic.
+ * @param topic
+ * @throws PulsarAdminException
+ */
+ void removeDeduplicationEnabled(String topic) throws PulsarAdminException;
+
+ /**
+ * remove deduplication enabled of a topic asynchronously.
+ * @param topic
+ * @return
+ */
+ CompletableFuture<Void> removeDeduplicationEnabledAsync(String topic);
Review comment:
minor: Would it be better to use enable and disable here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai edited a comment on pull request #7821: Support deduplication on topic level
Posted by GitBox <gi...@apache.org>.
MarvinCai edited a comment on pull request #7821:
URL: https://github.com/apache/pulsar/pull/7821#issuecomment-676520499
overall lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7821: Support deduplication on topic level
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7821:
URL: https://github.com/apache/pulsar/pull/7821#issuecomment-674615525
@jianyun8023 @MarvinCai Please help review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #7821: Support deduplication on topic level
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #7821:
URL: https://github.com/apache/pulsar/pull/7821#issuecomment-749846732
I've removed the "doc-required" label since the doc has been added [here](https://github.com/apache/pulsar/pull/7918).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on pull request #7821: Support deduplication on topic level
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #7821:
URL: https://github.com/apache/pulsar/pull/7821#issuecomment-676520499
lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org