You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2016/01/28 05:53:51 UTC
Review Request 42896: Remove timestamp from task IDs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42896/
-----------------------------------------------------------
Review request for Aurora, John Sirois and Zameer Manji.
Repository: aurora
Description
-------
Remove timestamp from task IDs.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 35675acfad8f98e833e0dba277ff65943a21db91
Diff: https://reviews.apache.org/r/42896/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 42896: Remove timestamp from task IDs.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42896/
-----------------------------------------------------------
(Updated Feb. 19, 2016, 3:12 p.m.)
Review request for Aurora, John Sirois and Zameer Manji.
Repository: aurora
Description
-------
Remove timestamp from task IDs.
Diffs (updated)
-----
NEWS 11a57bb18817b368f5855d6c3ff4282df3b10283
src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 35675acfad8f98e833e0dba277ff65943a21db91
Diff: https://reviews.apache.org/r/42896/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 42896: Remove timestamp from task IDs.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42896/#review116798
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Jan. 27, 2016, 8:53 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42896/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 8:53 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove timestamp from task IDs.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 35675acfad8f98e833e0dba277ff65943a21db91
>
> Diff: https://reviews.apache.org/r/42896/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 42896: Remove timestamp from task IDs.
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42896/#review116778
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On Jan. 28, 2016, 5:53 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42896/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 5:53 a.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove timestamp from task IDs.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 35675acfad8f98e833e0dba277ff65943a21db91
>
> Diff: https://reviews.apache.org/r/42896/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 42896: Remove timestamp from task IDs.
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 27, 2016, 9:56 p.m., Aurora ReviewBot wrote:
> > Master (89fad5a) is green with this patch.
> > ./build-support/jenkins/build.sh
> >
> > However, it appears that it might lack test coverage.
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
>
> Maxim Khutornenko wrote:
> Add a NEWS entry to highlight this change?
I don't really think this is newsworthy. It's likley a no-op for everyone, and shrug-worthy at best for even the most interested of people. I'd expect anyone interested in this level of detail would be best served following the commit log.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42896/#review116720
-----------------------------------------------------------
On Jan. 27, 2016, 8:53 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42896/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 8:53 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove timestamp from task IDs.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 35675acfad8f98e833e0dba277ff65943a21db91
>
> Diff: https://reviews.apache.org/r/42896/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 42896: Remove timestamp from task IDs.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Jan. 28, 2016, 5:56 a.m., Aurora ReviewBot wrote:
> > Master (89fad5a) is green with this patch.
> > ./build-support/jenkins/build.sh
> >
> > However, it appears that it might lack test coverage.
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
Add a NEWS entry to highlight this change?
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42896/#review116720
-----------------------------------------------------------
On Jan. 28, 2016, 4:53 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42896/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 4:53 a.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove timestamp from task IDs.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 35675acfad8f98e833e0dba277ff65943a21db91
>
> Diff: https://reviews.apache.org/r/42896/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 42896: Remove timestamp from task IDs.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Jan. 28, 2016, 5:56 a.m., Aurora ReviewBot wrote:
> > Master (89fad5a) is green with this patch.
> > ./build-support/jenkins/build.sh
> >
> > However, it appears that it might lack test coverage.
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
>
> Maxim Khutornenko wrote:
> Add a NEWS entry to highlight this change?
>
> Bill Farner wrote:
> I don't really think this is newsworthy. It's likley a no-op for everyone, and shrug-worthy at best for even the most interested of people. I'd expect anyone interested in this level of detail would be best served following the commit log.
To an operator (or anyone how ever debugged task-related issues), it could be quite puzzling to see different task ID formats in the scheduler/mesos logs. I think it's better to throw a line into the release news and let readers decide what's newsworthy than waste someone's time crawling trough the code/gitlog trying to understand the nature of that discrepancy.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42896/#review116720
-----------------------------------------------------------
On Jan. 28, 2016, 4:53 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42896/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 4:53 a.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove timestamp from task IDs.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 35675acfad8f98e833e0dba277ff65943a21db91
>
> Diff: https://reviews.apache.org/r/42896/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 42896: Remove timestamp from task IDs.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42896/#review116720
-----------------------------------------------------------
Master (89fad5a) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 28, 2016, 4:53 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42896/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 4:53 a.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove timestamp from task IDs.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 35675acfad8f98e833e0dba277ff65943a21db91
>
> Diff: https://reviews.apache.org/r/42896/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 42896: Remove timestamp from task IDs.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42896/#review116727
-----------------------------------------------------------
Ship it!
Ship It!
- John Sirois
On Jan. 27, 2016, 9:53 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42896/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 9:53 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove timestamp from task IDs.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 35675acfad8f98e833e0dba277ff65943a21db91
>
> Diff: https://reviews.apache.org/r/42896/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>