[GitHub] [iceberg] kbendick commented on a diff in pull request #4688: Add Apache HTTPComponents Client copyright to runtime NOTICE files

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #4688:
URL: https://github.com/apache/iceberg/pull/4688#discussion_r864444546


##########
flink/v1.13/flink-runtime/NOTICE:
##########
@@ -89,3 +89,14 @@ file:
 |
 | This product includes software developed at
 | The Apache Software Foundation (http://www.apache.org/).
+
+--------------------------------------------------------------------------------
+
+This binary artifact includes Apache HTTPComponents Client with the following
+in its NOTICE file:
+
+| Apache HttpComponents Client
+| Copyright 1999-2021 The Apache Software Foundation
+|
+| This product includes software developed at
+| The Apache Software Foundation (http://www.apache.org/).

Review Comment:
   Yeah we’d be fine. Two reasons:
   1. Copyright technically only matters from the starting year. People update them every year for the new year generally because they feel they should (and 100% I am the one to have updated the Iceberg files for the new year the past 2 years so I am guilty of this too), but it’s not actually required. The copyright only applies based on the start date.
   2. This is the file they have presently :)
   
   But reason 1 is good to know.
   
   If you want, they might accept a PR to update their notice though 😄 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org