You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jason Fehr (Code Review)" <ge...@cloudera.org> on 2025/06/27 19:42:23 UTC
[Impala-ASF-CR] IMPALA-13235: [Patch 2 of 5] - Add OpenSSL Utility Function to Validate PEM Bundles
Jason Fehr has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/23097 )
Change subject: IMPALA-13235: [Patch 2 of 5] - Add OpenSSL Utility Function to Validate PEM Bundles
......................................................................
IMPALA-13235: [Patch 2 of 5] - Add OpenSSL Utility Function to Validate PEM Bundles
Adds a new function ValidatePemBundle(const string& bundle) to the
openssl utilities. This function asserts that all certificates in a
string containing a bundle of X.509 PEM-encoded certificates are
valid. If even one certificate is invalid, them validation fails and
the function returns false.
Certificates can be invalid for these reasons:
1. Structure is invalid/PEM encoding is incorrect.
2. notBefore time is in the future.
3. notAfter time is in the past.
Testing accomplished by the tests in openssl-util-test.cc
successfully passing locally and in a build.
Change-Id: I1e9f12e854b679ccf3e94a38c2688a7431460a7a
---
M be/src/util/openssl-util-test.cc
M be/src/util/openssl-util.cc
M be/src/util/openssl-util.h
3 files changed, 201 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/23097/4
--
To view, visit http://gerrit.cloudera.org:8080/23097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e9f12e854b679ccf3e94a38c2688a7431460a7a
Gerrit-Change-Number: 23097
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>