You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/03/14 06:17:07 UTC
[GitHub] [drill] paul-rogers commented on a change in pull request #2026:
DRILL-7330: Implement metadata usage for all format plugins
paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement metadata usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392561161
##########
File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/TestFileScanFramework.java
##########
@@ -25,6 +25,8 @@
import java.util.Iterator;
import java.util.List;
+import mockit.Mock;
+import mockit.MockUp;
Review comment:
Please, if possible, try to avoid the use of Mocks here. These tend to work poorly in Eclipse. These tests try to use classes and interfaces designed to allow proper text fixture classes rather than dynamic mocks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services