[jira] [Commented] (JAMES-3205) Remove com.github.steveash.guavate from dependencies

["Benoit Tellier (Jira)" <se...@james.apache.org>]

    [ https://issues.apache.org/jira/browse/JAMES-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128865#comment-17128865 ] 

Benoit Tellier commented on JAMES-3205:
---------------------------------------

Good catch!

We did not do that move as Java8 immutable collection support is marked as Beta.

Here is what Guava have been documenting for Beta APIs:

{code:java}
 * Signifies that a public API (public class, method or field) is subject to incompatible changes,
 * or even removal, in a future release. An API bearing this annotation is exempt from any
 * compatibility guarantees made by its containing library. Note that the presence of this
 * annotation implies nothing about the quality or performance of the API in question, only the fact
 * that it is not "API-frozen."
 *
 * <p>It is generally safe for <i>applications</i> to depend on beta APIs, at the cost of some extra
 * work during upgrades. However it is generally inadvisable for <i>libraries</i> (which get
 * included on users' CLASSPATHs, outside the library developers' control) to do so.
{code}

If we accept that risk of API changes, then it makes perfect sense.

Maybe we could consider other options than Guava for immutable collection support, which is our main guava use case?

> Remove com.github.steveash.guavate from dependencies
> ----------------------------------------------------
>
>                 Key: JAMES-3205
>                 URL: https://issues.apache.org/jira/browse/JAMES-3205
>             Project: James Server
>          Issue Type: Task
>            Reporter: Ioan Eugen Stan
>            Assignee: Ioan Eugen Stan
>            Priority: Minor
>
> [https://github.com/steveash/guavate]
> From the project:
> """
> As of 2017-01-12 Guava 21 was released which brings Java 8 support to the library. That removes the need for Guavate. Please upgrade to Guava 21 This is a single jar dependency for Guavate written by Stephen Colebourne and included as part of Strata under the Apache 2 License. Guavate code is Copyright (C) 2014 - present by OpenGamma Inc. and the OpenGamma group of companies.
> """
> james project pom.xml  is using guava 25 
> {color:#e8bf6a}<guava.version>{color}25.1-jre{color:#e8bf6a}</guava.version>{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org