[GitHub] [netbeans] JaroslavTulach commented on pull request #2679: Properly stop Maven execution from LSP/DAP

[GitBox <gi...@apache.org>]

JaroslavTulach commented on pull request #2679:
URL: https://github.com/apache/netbeans/pull/2679#issuecomment-761481920


   > Maven executor forks the execution into a separate thread, and only then it creates a `ProgressHandle`. 
   
   Wouldn't changing the Maven to create the progress sooner be simpler? The changes in `java.lsp.server` are quite complicated and beyond my ability to review their correctness( which [would rather be verified](https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/test/suite/extension.test.ts) somehow).
   
   > The default execution engine implementation should support default `Lookup` passing, so the threads it creates operate in the caller's context.
   
   +1, please add there some unit tests for the platform changes
   
   > The tests of LSP server must run in headless mode; without that property, 
   > some code takes wrong path, blocking test execution on UI that nobody can click on.
   
   Wouldn't it be better to enforce the behavior with branding? E.g. have a property for various dialogs with values `Ask|Yes|No` which `java/java.lsp.server/nbcode` project would set to `No`? Value of `isHeadless()` may mean many things, it doesn't necessarily have to mean _running in VSCode extension_. Btw. I have a WIP replacing dialogs in `DataEditorSupport` with such branding.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists