You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "ZhangYu0123 (via GitHub)" <gi...@apache.org> on 2023/03/20 14:48:01 UTC

[GitHub] [doris] ZhangYu0123 opened a new pull request, #17975: [vectorized](function) support lamda function array_max / array_min / array_sum / array_avg / array_product

ZhangYu0123 opened a new pull request, #17975:
URL: https://github.com/apache/doris/pull/17975

   # Proposed changes
   Support lamda function array_max / array_min / array_sum / array_avg / array_product.
   
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   * [ ] Does it affect the original behavior
   * [ ] Has unit tests been added
   * [ ] Has document been added or modified
   * [ ] Does it need to update dependencies
   * [ ] Is this PR support rollback (If NO, please explain WHY)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] ZhangYu0123 closed pull request #17975: [vectorized](function) support lamda function array_max,array_min,array_sum,array_avg,array_product

Posted by "ZhangYu0123 (via GitHub)" <gi...@apache.org>.
ZhangYu0123 closed pull request #17975: [vectorized](function) support lamda function array_max,array_min,array_sum,array_avg,array_product
URL: https://github.com/apache/doris/pull/17975


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] HappenLee commented on pull request #17975: [vectorized](function) support lamda function array_max,array_min,array_sum,array_avg,array_product

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #17975:
URL: https://github.com/apache/doris/pull/17975#issuecomment-1476486959

   Hi, Thanks you contribute the code. but the lamda array_agg can be do like array_agg(array_map). For the sake of clean code, I don't think we should support this syntactic sugar. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] ZhangYu0123 commented on pull request #17975: [vectorized](function) support lamda function array_max,array_min,array_sum,array_avg,array_product

Posted by "ZhangYu0123 (via GitHub)" <gi...@apache.org>.
ZhangYu0123 commented on PR #17975:
URL: https://github.com/apache/doris/pull/17975#issuecomment-1476399012

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] HappenLee commented on pull request #17975: [vectorized](function) support lamda function array_max,array_min,array_sum,array_avg,array_product

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #17975:
URL: https://github.com/apache/doris/pull/17975#issuecomment-1476490092

   Hi, Thanks you contribute the code. but the lamda array_agg can be do like array_agg(array_map). For the sake of clean code, I don't think we should support this syntactic sugar. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17975: [vectorized](function) support lamda function array_max,array_min,array_sum,array_avg,array_product

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17975:
URL: https://github.com/apache/doris/pull/17975#issuecomment-1476376341

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17975: [vectorized](function) support lamda function array_max,array_min,array_sum,array_avg,array_product

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17975:
URL: https://github.com/apache/doris/pull/17975#issuecomment-1476383738

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org