You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/01/23 00:47:26 UTC
[GitHub] [libcloud] zepheiryan opened a new pull request #1416: Update Gandi
Live DNS driver to match service change
zepheiryan opened a new pull request #1416: Update Gandi Live DNS driver to match service change
URL: https://github.com/apache/libcloud/pull/1416
## Update Gandi Live DNS driver to match service change
### Description
The Gandi Live API appears to be more fluid and less than informative about its changes. They've changed their response to DELETE requests from HTTP 200 with a JSON message to HTTP 204 No content with no body at all, which breaks the current implementation. The driver and tests were updated to reflect the change.
### Status
Done, ready for review
### Checklist (tick everything that applies)
- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io commented on issue #1416: Update Gandi Live
DNS driver to match service change
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1416: Update Gandi Live DNS driver to match service change
URL: https://github.com/apache/libcloud/pull/1416#issuecomment-577835977
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1416?src=pr&el=h1) Report
> Merging [#1416](https://codecov.io/gh/apache/libcloud/pull/1416?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/a63b90eeddff9e85ae191b338f09b86e2f2a1713?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/libcloud/pull/1416?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1416 +/- ##
==========================================
- Coverage 86.46% 86.46% -0.01%
==========================================
Files 366 366
Lines 76799 76802 +3
Branches 7529 7531 +2
==========================================
Hits 66404 66404
- Misses 7527 7529 +2
- Partials 2868 2869 +1
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1416?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/test/dns/test\_gandi\_live.py](https://codecov.io/gh/apache/libcloud/pull/1416/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9kbnMvdGVzdF9nYW5kaV9saXZlLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [libcloud/common/gandi\_live.py](https://codecov.io/gh/apache/libcloud/pull/1416/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tbW9uL2dhbmRpX2xpdmUucHk=) | `95.23% <40%> (-4.77%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1416?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1416?src=pr&el=footer). Last update [a63b90e...7b65e0f](https://codecov.io/gh/apache/libcloud/pull/1416?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami merged pull request #1416: Update Gandi Live DNS
driver to match service change
Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1416: Update Gandi Live DNS driver to match service change
URL: https://github.com/apache/libcloud/pull/1416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services