You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/05/11 07:41:43 UTC
Re: Review Request 66825: Added per framework offer metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66825/
-----------------------------------------------------------
(Updated May 11, 2018, 12:41 a.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
Repository: mesos
Description
-------
Added per framework offer metrics.
Diffs (updated)
-----
src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66825/diff/4/
Changes: https://reviews.apache.org/r/66825/diff/3-4/
Testing
-------
Thanks,
Gilbert Song
Re: Review Request 66825: Added per framework offer metrics.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66825/#review203257
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On May 16, 2018, 12:43 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66825/
> -----------------------------------------------------------
>
> (Updated May 16, 2018, 12:43 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8848
> https://issues.apache.org/jira/browse/MESOS-8848
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per framework offer metrics.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/66825/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 66825: Added per framework offer metrics.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66825/
-----------------------------------------------------------
(Updated May 15, 2018, 5:43 p.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
Bugs: MESOS-8848
https://issues.apache.org/jira/browse/MESOS-8848
Repository: mesos
Description
-------
Added per framework offer metrics.
Diffs (updated)
-----
src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66825/diff/5/
Changes: https://reviews.apache.org/r/66825/diff/4-5/
Testing
-------
Thanks,
Gilbert Song
Re: Review Request 66825: Added per framework offer metrics.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66825/#review203173
-----------------------------------------------------------
src/master/master.cpp
Lines 4019 (patched)
<https://reviews.apache.org/r/66825/#comment285262>
Nit: can we use `++` here instead of `+= 1`?
src/master/master.cpp
Lines 5829 (patched)
<https://reviews.apache.org/r/66825/#comment285263>
Perhaps we should move this into the validation block as well, so that we only increment the metric when offers are successfully declined?
- Greg Mann
On May 11, 2018, 7:41 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66825/
> -----------------------------------------------------------
>
> (Updated May 11, 2018, 7:41 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per framework offer metrics.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/66825/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>