You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/08/13 18:44:55 UTC

Review Request 72771: Removed `evolve(const scheduler::Call&)`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72771/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

This patch removes a non-trivial `evolve()` overload that is not used
anywhere in Mesos code and is not covered by tests.


Diffs
-----

  src/internal/evolve.hpp e4e3ab41a90c420842103b27a8180cfc5835986e 
  src/internal/evolve.cpp c5e41516e5b9b08acf0641c89c3386e050783bf0 


Diff: https://reviews.apache.org/r/72771/diff/1/


Testing
-------

`support/mesos-gtest-runner.py src/mesos-tests`


Thanks,

Andrei Sekretenko

Re: Review Request 72771: Removed `evolve(const scheduler::Call&)`.

Posted by Benjamin Mahler <bm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72771/#review221602
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On Aug. 13, 2020, 6:44 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72771/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2020, 6:44 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch removes a non-trivial `evolve()` overload that is not used
> anywhere in Mesos code and is not covered by tests.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp e4e3ab41a90c420842103b27a8180cfc5835986e 
>   src/internal/evolve.cpp c5e41516e5b9b08acf0641c89c3386e050783bf0 
> 
> 
> Diff: https://reviews.apache.org/r/72771/diff/1/
> 
> 
> Testing
> -------
> 
> `support/mesos-gtest-runner.py src/mesos-tests`
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>