You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/08/13 20:37:32 UTC

[GitHub] jihoonson commented on issue #6162: Add maven.exec.xxx.skip option for exec-maven-plugin

jihoonson commented on issue #6162: Add maven.exec.xxx.skip option for exec-maven-plugin
URL: https://github.com/apache/incubator-druid/pull/6162#issuecomment-412655473
 
 
   @asdf2014 thanks for taking this issue. I've restarted the failed one. 
   
   BTW, IMO, it would be better to have an option to make the distribution tarball rather than avoiding pulling some dependencies. As you can see in https://github.com/apache/incubator-druid/blob/master/distribution/pom.xml, `mvn install` does more things other than pulling libraries to build the distribution tarball. I think we can simply skip this if some option like `-Pdist` is not specified. Please check [Hadoop's pom.xml](https://github.com/apache/hadoop/blob/trunk/hadoop-dist/pom.xml#L148-L226) as an example. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org