[GitHub] incubator-storm pull request: STORM-63 remove timeout drpc request...

[revans2 <gi...@git.apache.org>]

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/33#discussion_r10046165
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/drpc.clj ---
    @@ -59,6 +63,8 @@
                                 (when-let [sem (@id->sem id)]
                                   (swap! id->result assoc id (DRPCExecutionException. "Request timed out"))
                                   (.release sem))
    +                              (.remove (acquire-queue request-queues (@id->function id)) (@id->request id))
    --- End diff --
    
    Either your indentation is wrong here or you have put the remove in the incorrect place.  These are outside of the when-let block but have the indentation of items in it.  If sem has been removed then we don't need to remove it from the queue, although it should not hurt anything in that case. And the log line should be OK either way, but preferably in the when-let.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---