You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/10/24 03:13:01 UTC

Review Request: Fixing the build on Ubuntu 12.04.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7710/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Description
-------

Gtest does not like the following on some systems:

ASSERT_EQ(true, foo);
ASSERT_EQ(false, foo);

the preferred method is:
ASSERT_TRUE(foo);
ASSERT_FALSE(foo);


Diffs
-----

  src/tests/zookeeper_tests.cpp 4415a33b94dd6ca360a7dd3ca49f4c29ee25f5e8 

Diff: https://reviews.apache.org/r/7710/diff/


Testing
-------

make check on ubuntu 12.04 and OSX


Thanks,

Ben Mahler

Re: Review Request: Fixing the build on Ubuntu 12.04.

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7710/#review12740
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Oct. 24, 2012, 1:13 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7710/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2012, 1:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> Gtest does not like the following on some systems:
> 
> ASSERT_EQ(true, foo);
> ASSERT_EQ(false, foo);
> 
> the preferred method is:
> ASSERT_TRUE(foo);
> ASSERT_FALSE(foo);
> 
> 
> Diffs
> -----
> 
>   src/tests/zookeeper_tests.cpp 4415a33b94dd6ca360a7dd3ca49f4c29ee25f5e8 
> 
> Diff: https://reviews.apache.org/r/7710/diff/
> 
> 
> Testing
> -------
> 
> make check on ubuntu 12.04 and OSX
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>