Re: [PR] [SPARK-43301][CORE][SHUFFLE] BlockStoreClient getHostLocalDirs RPC supports IOException retry [spark]

["cxzl25 (via GitHub)" <gi...@apache.org>]

cxzl25 commented on code in PR #46805:
URL: https://github.com/apache/spark/pull/46805#discussion_r1686216130


##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java:
##########
@@ -46,6 +53,10 @@
 public abstract class BlockStoreClient implements Closeable {
   protected final SparkLogger logger = SparkLoggerFactory.getLogger(this.getClass());
 
+  private static final ScheduledExecutorService scheduledExecutor =
+          Executors.newScheduledThreadPool(16,
+                  NettyUtils.createThreadFactory("Block Store Client Retry"));

Review Comment:
   Now use `Executors.newSingleThreadScheduledExecutor`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org