You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Kwafoor (via GitHub)" <gi...@apache.org> on 2023/06/10 02:49:35 UTC
[GitHub] [spark] Kwafoor commented on pull request #41535: [SPARK-32559]Fix the trim logic did't handle ASCII control characters correctly
Kwafoor commented on PR #41535:
URL: https://github.com/apache/spark/pull/41535#issuecomment-1585437073
> I'm not sure this is correct. SQL TRIM from other DBs seems to default to removing _whitespace_ or the space char, not control codes.
I conducted tests on both MySQL and Hive, and found that Hive supports trimming control characters and spaces but does not support trimming characters within the range 0x7F to 0x9F. MySQL, on the other hand, supports trimming specific control characters.
<img width="397" alt="image" src="https://github.com/apache/spark/assets/25627922/3777b4e6-6b2a-4ec2-a87e-55e9439736b8">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org