You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wilder Rodrigues <wr...@schubergphilis.com> on 2013/11/07 08:23:08 UTC
Review Request 15298: Fix for issues on Coverity related to IDs 1125383 [82,
80, 79, 78, 77, 76, 75, 74]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15298/
-----------------------------------------------------------
Review request for cloudstack and Hugo Trippaers.
Bugs: 1125374, 1125375, 1125376, 1125377, 1125378, 1125379, 1125380, 1125382, and 1125383
https://issues.apache.org/jira/browse/1125374
https://issues.apache.org/jira/browse/1125375
https://issues.apache.org/jira/browse/1125376
https://issues.apache.org/jira/browse/1125377
https://issues.apache.org/jira/browse/1125378
https://issues.apache.org/jira/browse/1125379
https://issues.apache.org/jira/browse/1125380
https://issues.apache.org/jira/browse/1125382
https://issues.apache.org/jira/browse/1125383
Repository: cloudstack-git
Description
-------
Several bugs reported on coverity have been fixed on this path. The ID are: Fix for issues on Coverity related to IDs 1125383, 1125382, 1125380, 1125379, 1125378, 1125377, 1125376, 1125375, 1125374.
Those bugs are related to classes not implementing Serializable, nox overriding the equals and/or hashCode methods and with empty finalize method.
For the bug 1125374, although it has been submitted in a previous patch, there was a typo on the return key word, which contained a "s".
Diffs
-----
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 8cb4e8d
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java 455e601
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java 71d28ac
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java f22c7c5
Diff: https://reviews.apache.org/r/15298/diff/
Testing
-------
Thanks,
Wilder Rodrigues
Re: Review Request 15298: Fix for issues on Coverity related to IDs 1125383
[82, 80, 79, 78, 77, 76, 75, 74]
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15298/#review28357
-----------------------------------------------------------
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java
<https://reviews.apache.org/r/15298/#comment55184>
Can you replace the tabs with spaces please?
- Hugo Trippaers
On Nov. 7, 2013, 7:24 a.m., Wilder Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15298/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2013, 7:24 a.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Bugs: 1125374, 1125375, 1125376, 1125377, 1125378, 1125379, 1125380, 1125382, and 1125383
> https://issues.apache.org/jira/browse/1125374
> https://issues.apache.org/jira/browse/1125375
> https://issues.apache.org/jira/browse/1125376
> https://issues.apache.org/jira/browse/1125377
> https://issues.apache.org/jira/browse/1125378
> https://issues.apache.org/jira/browse/1125379
> https://issues.apache.org/jira/browse/1125380
> https://issues.apache.org/jira/browse/1125382
> https://issues.apache.org/jira/browse/1125383
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Several bugs reported on Coverity have been fixed on this path. The ID are: Fix for issues on Coverity related to IDs 1125383, 1125382, 1125380, 1125379, 1125378, 1125377, 1125376, 1125375, 1125374.
>
> Those bugs are related to classes not implementing Serializable, nox overriding the equals and/or hashCode methods and with empty finalize method.
>
> For the bug 1125376, although it has been submitted in a previous patch, there was a typo on the return key word, which contained a "s".
>
>
> Diffs
> -----
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 8cb4e8d
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java 455e601
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java 71d28ac
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java f22c7c5
>
> Diff: https://reviews.apache.org/r/15298/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Wilder Rodrigues
>
>
Re: Review Request 15298: Fix for issues on Coverity related to IDs
cv_1125383 [82, 80, 79, 78, 77, 76, 75, 74]
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15298/#review28358
-----------------------------------------------------------
Ship it!
commit c06d8a750c75f500fa29479c0aec58eb7fcea2ba
Author: wilderrodrigues <wr...@schubegphilis.com>
Date: Thu Nov 7 09:22:43 2013 +0100
Fix for issues on Coverity related to IDs cv_1125383, cv_1125382, cv_1125380, cv_1125379, cv_1125378, cv_1125377, cv_1125376, cv_1125375, cv_1125374.
Those bugs are related to classes not implementing Serializable, nox overriding the equals and/or hashCode methods and with empty finalize method.
Signed-off-by: Hugo Trippaers <ht...@schubergphilis.com>
- Hugo Trippaers
On Nov. 7, 2013, 8:25 a.m., Wilder Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15298/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2013, 8:25 a.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Several bugs reported on Coverity have been fixed on this path. The ID are: Fix for issues on Coverity related to IDs cv_1125383, cv_1125382, cv_1125380, cv_1125379, cv_1125378, cv_1125377, cv_1125376, cv_1125375, cv_1125374.
>
> Those bugs are related to classes not implementing Serializable, nox overriding the equals and/or hashCode methods and with empty finalize method.
>
> For the bug cv_1125376, although it has been submitted in a previous patch, there was a typo on the return key word, which contained a "s".
>
>
> Diffs
> -----
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 8cb4e8d
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java 455e601
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java 71d28ac
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java f22c7c5
>
> Diff: https://reviews.apache.org/r/15298/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Wilder Rodrigues
>
>
Re: Review Request 15298: Fix for issues on Coverity related to IDs
cv_1125383 [82, 80, 79, 78, 77, 76, 75, 74]
Posted by Wilder Rodrigues <wr...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15298/
-----------------------------------------------------------
(Updated Nov. 7, 2013, 8:25 a.m.)
Review request for cloudstack and Hugo Trippaers.
Changes
-------
replacing tabs with whitespaces and uploading new diff file
Repository: cloudstack-git
Description
-------
Several bugs reported on Coverity have been fixed on this path. The ID are: Fix for issues on Coverity related to IDs cv_1125383, cv_1125382, cv_1125380, cv_1125379, cv_1125378, cv_1125377, cv_1125376, cv_1125375, cv_1125374.
Those bugs are related to classes not implementing Serializable, nox overriding the equals and/or hashCode methods and with empty finalize method.
For the bug cv_1125376, although it has been submitted in a previous patch, there was a typo on the return key word, which contained a "s".
Diffs (updated)
-----
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 8cb4e8d
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java 455e601
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java 71d28ac
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java f22c7c5
Diff: https://reviews.apache.org/r/15298/diff/
Testing
-------
Thanks,
Wilder Rodrigues
Re: Review Request 15298: Fix for issues on Coverity related to IDs
cv_1125383 [82, 80, 79, 78, 77, 76, 75, 74]
Posted by Wilder Rodrigues <wr...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15298/
-----------------------------------------------------------
(Updated Nov. 7, 2013, 7:35 a.m.)
Review request for cloudstack and Hugo Trippaers.
Changes
-------
removing bug IDs because they are not jira, but coverity
Summary (updated)
-----------------
Fix for issues on Coverity related to IDs cv_1125383 [82, 80, 79, 78, 77, 76, 75, 74]
Repository: cloudstack-git
Description (updated)
-------
Several bugs reported on Coverity have been fixed on this path. The ID are: Fix for issues on Coverity related to IDs cv_1125383, cv_1125382, cv_1125380, cv_1125379, cv_1125378, cv_1125377, cv_1125376, cv_1125375, cv_1125374.
Those bugs are related to classes not implementing Serializable, nox overriding the equals and/or hashCode methods and with empty finalize method.
For the bug cv_1125376, although it has been submitted in a previous patch, there was a typo on the return key word, which contained a "s".
Diffs
-----
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 8cb4e8d
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java 455e601
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java 71d28ac
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java f22c7c5
Diff: https://reviews.apache.org/r/15298/diff/
Testing
-------
Thanks,
Wilder Rodrigues
Re: Review Request 15298: Fix for issues on Coverity related to IDs 1125383
[82, 80, 79, 78, 77, 76, 75, 74]
Posted by Wilder Rodrigues <wr...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15298/
-----------------------------------------------------------
(Updated Nov. 7, 2013, 7:24 a.m.)
Review request for cloudstack and Hugo Trippaers.
Changes
-------
Changing the ID of the Coverity issue that contained a type.
Bugs: 1125374, 1125375, 1125376, 1125377, 1125378, 1125379, 1125380, 1125382, and 1125383
https://issues.apache.org/jira/browse/1125374
https://issues.apache.org/jira/browse/1125375
https://issues.apache.org/jira/browse/1125376
https://issues.apache.org/jira/browse/1125377
https://issues.apache.org/jira/browse/1125378
https://issues.apache.org/jira/browse/1125379
https://issues.apache.org/jira/browse/1125380
https://issues.apache.org/jira/browse/1125382
https://issues.apache.org/jira/browse/1125383
Repository: cloudstack-git
Description (updated)
-------
Several bugs reported on Coverity have been fixed on this path. The ID are: Fix for issues on Coverity related to IDs 1125383, 1125382, 1125380, 1125379, 1125378, 1125377, 1125376, 1125375, 1125374.
Those bugs are related to classes not implementing Serializable, nox overriding the equals and/or hashCode methods and with empty finalize method.
For the bug 1125376, although it has been submitted in a previous patch, there was a typo on the return key word, which contained a "s".
Diffs
-----
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 8cb4e8d
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java 455e601
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java 71d28ac
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java f22c7c5
Diff: https://reviews.apache.org/r/15298/diff/
Testing
-------
Thanks,
Wilder Rodrigues