You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Fred Moyer <fr...@taperfriendlymusic.org> on 2007/03/23 05:11:41 UTC
Security Fix [mp2]
Philip gave a +1 here -
http://marc.info/?l=apache-modperl&m=117462227916610&w=2
I think I need another +1, right?
Working on the mp1 patch.
Index: Changes
===================================================================
--- Changes (revision 508723)
+++ Changes (working copy)
@@ -12,6 +12,9 @@
=item 2.0.4-dev
+fix unescaped variable interprolation in regular expression
+[Randal L. Schwartz <me...@stonehenge.com>, Fred Moyer
<fr...@redhotpenguin.com>]
+
Make $r->the_request() writeable
[Fred Moyer <fr...@redhotpenguin.com>]
Index: ModPerl-Registry/lib/ModPerl/RegistryCooker.pm
===================================================================
--- ModPerl-Registry/lib/ModPerl/RegistryCooker.pm (revision 508723)
+++ ModPerl-Registry/lib/ModPerl/RegistryCooker.pm (working copy)
@@ -337,7 +337,7 @@
my $self = shift;
my $path_info = $self->{REQ}->path_info;
- my $script_name = $path_info && $self->{URI} =~ /$path_info$/
+ my $script_name = $path_info && $self->{URI} =~ /\Q$path_info\E$/
? substr($self->{URI}, 0, length($self->{URI}) -
length($path_info))
: $self->{URI};
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Security Fix [mp2]
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Fred Moyer wrote:
> Geoffrey Young wrote:
>
>> Fred Moyer wrote:
>>
>>> Philip gave a +1 here -
>>> http://marc.info/?l=apache-modperl&m=117462227916610&w=2
>>>
>>> I think I need another +1, right?
>>
>>
>> I'll work on it now. this needs tests, though. definitely in mp2, and
>> in mp1 if we can figure it out :)
>
>
> Ok I will add tests for this. Sorry if I jumped the gun with the patch
> - was concerned that we were in some danger here, but reading through
> threads this morning I realize that those concerns may have been premature.
nope, you're good.
I've figured out that nothing we ship as a real handler in mp2 is
affected, and you can see why if you trace the cooker code back.
if you want to whip up a test for a custom cooker module feel free, but
I think we're ok. I'll commit the test I have that doesn't break but
exercises the security breach.
in light of this, I don't think we need to force our a mp2 release. but
I'll RM a mp1 release now.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Security Fix [mp2]
Posted by Fred Moyer <fr...@taperfriendlymusic.org>.
Geoffrey Young wrote:
> Fred Moyer wrote:
>> Philip gave a +1 here -
>> http://marc.info/?l=apache-modperl&m=117462227916610&w=2
>>
>> I think I need another +1, right?
>
> I'll work on it now. this needs tests, though. definitely in mp2, and
> in mp1 if we can figure it out :)
Ok I will add tests for this. Sorry if I jumped the gun with the patch
- was concerned that we were in some danger here, but reading through
threads this morning I realize that those concerns may have been premature.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Security Fix [mp2]
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Fred Moyer wrote:
> Philip gave a +1 here -
> http://marc.info/?l=apache-modperl&m=117462227916610&w=2
>
> I think I need another +1, right?
I'll work on it now. this needs tests, though. definitely in mp2, and
in mp1 if we can figure it out :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Security Fix [mp2]
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Thu, 22 Mar 2007, Fred Moyer wrote:
> Philip gave a +1 here -
> http://marc.info/?l=apache-modperl&m=117462227916610&w=2
>
> I think I need another +1, right?
>
> Working on the mp1 patch.
>
> Index: Changes
> ===================================================================
> --- Changes (revision 508723)
> +++ Changes (working copy)
> @@ -12,6 +12,9 @@
>
> =item 2.0.4-dev
>
> +fix unescaped variable interprolation in regular expression
> +[Randal L. Schwartz <me...@stonehenge.com>, Fred Moyer
> <fr...@redhotpenguin.com>]
> +
> Make $r->the_request() writeable
> [Fred Moyer <fr...@redhotpenguin.com>]
>
> Index: ModPerl-Registry/lib/ModPerl/RegistryCooker.pm
> ===================================================================
> --- ModPerl-Registry/lib/ModPerl/RegistryCooker.pm (revision 508723)
> +++ ModPerl-Registry/lib/ModPerl/RegistryCooker.pm (working copy)
> @@ -337,7 +337,7 @@
> my $self = shift;
>
> my $path_info = $self->{REQ}->path_info;
> - my $script_name = $path_info && $self->{URI} =~ /$path_info$/
> + my $script_name = $path_info && $self->{URI} =~ /\Q$path_info\E$/
> ? substr($self->{URI}, 0, length($self->{URI}) - length($path_info))
> : $self->{URI};
+1
--
best regards,
Randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org