You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/16 11:30:33 UTC
[GitHub] [cloudstack] nvazquez opened a new issue #4470: [Investigation] Templates/ISOs are not removed but marked as Inactive
nvazquez opened a new issue #4470:
URL: https://github.com/apache/cloudstack/issues/4470
Probably not an issue, but worth investigating the reason why templates/ISOs are not deleted in database (the removed column stays NULL) after deleting a template/ISO. The ticket is raised after some doubts on the reviews of PR #4047
##### ISSUE TYPE
* Other
##### COMPONENT NAME
~~~
API, templates, ISOs
~~~
##### CLOUDSTACK VERSION
~~~
All versions
~~~
##### CONFIGURATION
N/A
##### OS / ENVIRONMENT
N/A
##### SUMMARY
Deleting a template/ISO does not actually remove it, but set it to Inactive and hidden
##### STEPS TO REPRODUCE
~~~
Remove a template/ISO
~~~
##### EXPECTED RESULTS
~~~
Template/ISO removed in database
~~~
##### ACTUAL RESULTS
~~~
Template/ISO state = 'Inactive' but removed column not changed
~~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on issue #4470: [Investigation] Templates/ISOs are not removed but marked as Inactive
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #4470:
URL: https://github.com/apache/cloudstack/issues/4470#issuecomment-732023403
@rhtyd Like @nvazquez said, there is no issue here, just a question about design choices.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez closed issue #4470: [Investigation] Templates/ISOs are not removed but marked as Inactive
Posted by GitBox <gi...@apache.org>.
nvazquez closed issue #4470:
URL: https://github.com/apache/cloudstack/issues/4470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on issue #4470: [Investigation] Templates/ISOs are not removed but marked as Inactive
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #4470:
URL: https://github.com/apache/cloudstack/issues/4470#issuecomment-825050477
Tested - fixed confirmed. Thanks @Pearl1594 @rhtyd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4470: [Investigation] Templates/ISOs are not removed but marked as Inactive
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4470:
URL: https://github.com/apache/cloudstack/issues/4470#issuecomment-733539230
ok, this means we'll have to look for those find including removed calls and try to make sure the removed column is correctly filled at the correct moment. (future version for now)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on issue #4470: [Investigation] Templates/ISOs are not removed but marked as Inactive
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #4470:
URL: https://github.com/apache/cloudstack/issues/4470#issuecomment-732018027
I'm not sure what the original problem was, I have traced the active/inactive fields to a commit in 2013. In the git log there is speak of some kind of problem that was solved from version 2.1.x to do with the removed column not being correctly used.
```
Fixed the problem with offerings and templates. These two items due to a previous patch all the way back in 2.1.x versions uses the removed column incorrectly. No one fixed since then. Hence, there's a bunch of findbyidincludingremoved calls in the cloudstack code around these two items.
abbae2aa Alex Huang <al...@citrix.com> on 2013/08/27 at 02:30
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4470: [Investigation] Templates/ISOs are not removed but marked as Inactive
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4470:
URL: https://github.com/apache/cloudstack/issues/4470#issuecomment-824707973
Looks liked fixed in https://github.com/apache/cloudstack/pull/4748
@nvazquez can you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on issue #4470: [Investigation] Templates/ISOs are not removed but marked as Inactive
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #4470:
URL: https://github.com/apache/cloudstack/issues/4470#issuecomment-730254930
I'll take a look @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 removed a comment on issue #4470: [Investigation] Templates/ISOs are not removed but marked as Inactive
Posted by GitBox <gi...@apache.org>.
Spaceman1984 removed a comment on issue #4470:
URL: https://github.com/apache/cloudstack/issues/4470#issuecomment-732023403
@rhtyd Like @nvazquez said, there is no issue here, just a question about design choices.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4470: [Investigation] Templates/ISOs are not removed but marked as Inactive
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4470:
URL: https://github.com/apache/cloudstack/issues/4470#issuecomment-730016074
Cc @Spaceman1984 looks like GC issue, have you seen this or can you discuss with @nvazquez and investigate/fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org