You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/06/04 10:44:07 UTC

Review Request 35056: Perf: Add GZIP support for Ambari Server API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35056/
-----------------------------------------------------------

Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-11678
    https://issues.apache.org/jira/browse/AMBARI-11678


Repository: ambari


Description
-------

Add GZIP support for Ambari Server API
Add compression options to ambari.properties to make it configurable


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/Controller.py 94b574a 
  ambari-agent/src/main/python/ambari_agent/security.py a86d06b 
  ambari-project/pom.xml 528dbf4 
  ambari-server/pom.xml a17e529 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 4536b3c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 8320715 

Diff: https://reviews.apache.org/r/35056/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 35056: Perf: Add GZIP support for Ambari Server API

Posted by Dmytro Sen <ds...@hortonworks.com>.

> On Июнь 4, 2015, 4:26 п.п., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, line 300
> > <https://reviews.apache.org/r/35056/diff/3/?file=979154#file979154line300>
> >
> >     Is this 1K ?

10k


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35056/#review86637
-----------------------------------------------------------


On Июнь 4, 2015, 4:01 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35056/
> -----------------------------------------------------------
> 
> (Updated Июнь 4, 2015, 4:01 п.п.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-11678
>     https://issues.apache.org/jira/browse/AMBARI-11678
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add GZIP support for Ambari Server API
> Add compression options to ambari.properties to make it configurable
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 94b574a 
>   ambari-agent/src/main/python/ambari_agent/security.py a86d06b 
>   ambari-project/pom.xml 528dbf4 
>   ambari-server/pom.xml a17e529 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 4536b3c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 8320715 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java 6e1c97e 
> 
> Diff: https://reviews.apache.org/r/35056/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 35056: Perf: Add GZIP support for Ambari Server API

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35056/#review86637
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
<https://reviews.apache.org/r/35056/#comment138684>

    Is this 1K ?


- Sid Wagle


On June 4, 2015, 4:01 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35056/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 4:01 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-11678
>     https://issues.apache.org/jira/browse/AMBARI-11678
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add GZIP support for Ambari Server API
> Add compression options to ambari.properties to make it configurable
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 94b574a 
>   ambari-agent/src/main/python/ambari_agent/security.py a86d06b 
>   ambari-project/pom.xml 528dbf4 
>   ambari-server/pom.xml a17e529 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 4536b3c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 8320715 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java 6e1c97e 
> 
> Diff: https://reviews.apache.org/r/35056/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 35056: Perf: Add GZIP support for Ambari Server API

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35056/#review86648
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Червень 4, 2015, 7:01 після полудня, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35056/
> -----------------------------------------------------------
> 
> (Updated Червень 4, 2015, 7:01 після полудня)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-11678
>     https://issues.apache.org/jira/browse/AMBARI-11678
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add GZIP support for Ambari Server API
> Add compression options to ambari.properties to make it configurable
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 94b574a 
>   ambari-agent/src/main/python/ambari_agent/security.py a86d06b 
>   ambari-project/pom.xml 528dbf4 
>   ambari-server/pom.xml a17e529 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 4536b3c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 8320715 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java 6e1c97e 
> 
> Diff: https://reviews.apache.org/r/35056/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 35056: Perf: Add GZIP support for Ambari Server API

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35056/
-----------------------------------------------------------

(Updated Июнь 4, 2015, 4:01 п.п.)


Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-11678
    https://issues.apache.org/jira/browse/AMBARI-11678


Repository: ambari


Description
-------

Add GZIP support for Ambari Server API
Add compression options to ambari.properties to make it configurable


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/Controller.py 94b574a 
  ambari-agent/src/main/python/ambari_agent/security.py a86d06b 
  ambari-project/pom.xml 528dbf4 
  ambari-server/pom.xml a17e529 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 4536b3c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 8320715 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java 6e1c97e 

Diff: https://reviews.apache.org/r/35056/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 35056: Perf: Add GZIP support for Ambari Server API

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35056/
-----------------------------------------------------------

(Updated Июнь 4, 2015, 9:21 д.п.)


Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-11678
    https://issues.apache.org/jira/browse/AMBARI-11678


Repository: ambari


Description
-------

Add GZIP support for Ambari Server API
Add compression options to ambari.properties to make it configurable


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/Controller.py 94b574a 
  ambari-agent/src/main/python/ambari_agent/security.py a86d06b 
  ambari-project/pom.xml 528dbf4 
  ambari-server/pom.xml a17e529 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 4536b3c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 8320715 

Diff: https://reviews.apache.org/r/35056/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen