You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Zhenya Stanilovsky <ar...@mail.ru.INVALID> on 2021/04/15 11:39:29 UTC
Re[2]: [DISCUSSION] MaxLineLength checkstyle rule
Python is not so verbose as java )
+1 for 140
>Hi!
>Personally, I suppose that 120 chars per line is OK. Moreover, many
>codestyles suggests less chars per line.
>For example PEP8 recommends 80 (but we use 120 in pyignite and flake8
>codestyle checks it). Google java codestyle insists on 100.
>
>More than 120 chars is too long as for me and is not convenient for 3-way
>merges.
>
>чт, 15 апр. 2021 г. в 12:28, Nikolay Izhikov < nizhikov@apache.org >:
>
>> Hello, Ilya.
>>
>> Thanks for the feedback.
>>
>> 140 characters is fine for me.
>>
>> > 15 апр. 2021 г., в 12:25, Ilya Kasnacheev < ilya.kasnacheev@gmail.com >
>> написал(а):
>> >
>> > Hello!
>> >
>> > Please find attached the distribution of line lengths in the project, in
>> the form of (count, line length).
>> >
>> > I think that we can enforce a hard limit of 140 chars per line. I think
>> that having longer lines is excessive and does not benefit readability.
>> >
>> > Having a limit of 150 or 180 does not give us much since there's still
>> a long tail which has to be fixed.
>> >
>> > Regards,
>> > --
>> > Ilya Kasnacheev
>> >
>> >
>> > чт, 15 апр. 2021 г. в 11:30, Nikolay Izhikov < nizhikov@apache.org >:
>> > Hello, Igniters.
>> >
>> > Right now, we have a code style rule [1] - the line should fit in 120
>> characters.
>> > But, this rule violated in many and many places through code.
>> > I have a plan to add a check style rule to force maximum line length.
>> >
>> > For me, personally, 120 characters a bit old-fashioned restriction.
>> > Should we increase the maximum line length to 150 or even 180 characters?
>> >
>> > [1] https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines
>> > <linelengths.txt>
>>
>>
>--
>Sincerely yours, Ivan Daschinskiy
Re: [DISCUSSION] MaxLineLength checkstyle rule
Posted by Nikolay Izhikov <ni...@apache.org>.
Hello.
> BTW, was there any progress with this?
Patch is ready, please, join the review - https://github.com/apache/ignite/pull/9106
> 10 мая 2021 г., в 09:47, Ivan Pavlukhin <vo...@gmail.com> написал(а):
>
> +1 for 140 lines compromise.
> +1 if someone is ready to fix everything to fit 120.
>
> BTW, was there any progress with this?
>
> 2021-04-15 21:41 GMT+03:00, Maxim Muzafarov <mm...@apache.org>:
>> Folks,
>>
>> I've briefly checked the total amount of the max length violations:
>>
>> 120 line length - 5540 violations
>> 130 line length - 1891 violations
>> 140 line length - 895 violations
>> 150 line length - 478 violations
>>
>>
>> I think the 140 max line length might be the best option for us.
>>
>> On Thu, 15 Apr 2021 at 14:51, Ivan Daschinsky <iv...@gmail.com> wrote:
>>>
>>> But super long lines are a real problem while merging. It is super
>>> inconvenient.
>>> 120 chars is a good compromise.
>>>
>>> чт, 15 апр. 2021 г. в 14:39, Zhenya Stanilovsky
>>> <arzamas123@mail.ru.invalid
>>>> :
>>>
>>>>
>>>> Python is not so verbose as java )
>>>> +1 for 140
>>>>
>>>>> Hi!
>>>>> Personally, I suppose that 120 chars per line is OK. Moreover, many
>>>>> codestyles suggests less chars per line.
>>>>> For example PEP8 recommends 80 (but we use 120 in pyignite and flake8
>>>>> codestyle checks it). Google java codestyle insists on 100.
>>>>>
>>>>> More than 120 chars is too long as for me and is not convenient for
>>>>> 3-way
>>>>> merges.
>>>>>
>>>>> чт, 15 апр. 2021 г. в 12:28, Nikolay Izhikov < nizhikov@apache.org >:
>>>>>
>>>>>> Hello, Ilya.
>>>>>>
>>>>>> Thanks for the feedback.
>>>>>>
>>>>>> 140 characters is fine for me.
>>>>>>
>>>>>>> 15 апр. 2021 г., в 12:25, Ilya Kasnacheev <
>>>>>>> ilya.kasnacheev@gmail.com
>>>>>
>>>>>> написал(а):
>>>>>>>
>>>>>>> Hello!
>>>>>>>
>>>>>>> Please find attached the distribution of line lengths in the
>>>>>>> project,
>>>> in
>>>>>> the form of (count, line length).
>>>>>>>
>>>>>>> I think that we can enforce a hard limit of 140 chars per line. I
>>>> think
>>>>>> that having longer lines is excessive and does not benefit
>>>>>> readability.
>>>>>>>
>>>>>>> Having a limit of 150 or 180 does not give us much since there's
>>>>>>> still
>>>>>> a long tail which has to be fixed.
>>>>>>>
>>>>>>> Regards,
>>>>>>> --
>>>>>>> Ilya Kasnacheev
>>>>>>>
>>>>>>>
>>>>>>> чт, 15 апр. 2021 г. в 11:30, Nikolay Izhikov < nizhikov@apache.org
>>>>>>>> :
>>>>>>> Hello, Igniters.
>>>>>>>
>>>>>>> Right now, we have a code style rule [1] - the line should fit in
>>>>>>> 120
>>>>>> characters.
>>>>>>> But, this rule violated in many and many places through code.
>>>>>>> I have a plan to add a check style rule to force maximum line
>>>>>>> length.
>>>>>>>
>>>>>>> For me, personally, 120 characters a bit old-fashioned
>>>>>>> restriction.
>>>>>>> Should we increase the maximum line length to 150 or even 180
>>>> characters?
>>>>>>>
>>>>>>> [1]
>>>> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines
>>>>>>> <linelengths.txt>
>>>>>>
>>>>>>
>>>>> --
>>>>> Sincerely yours, Ivan Daschinskiy
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Sincerely yours, Ivan Daschinskiy
>>
>
>
> --
>
> Best regards,
> Ivan Pavlukhin
Re: Re[2]: [DISCUSSION] MaxLineLength checkstyle rule
Posted by Ivan Pavlukhin <vo...@gmail.com>.
+1 for 140 lines compromise.
+1 if someone is ready to fix everything to fit 120.
BTW, was there any progress with this?
2021-04-15 21:41 GMT+03:00, Maxim Muzafarov <mm...@apache.org>:
> Folks,
>
> I've briefly checked the total amount of the max length violations:
>
> 120 line length - 5540 violations
> 130 line length - 1891 violations
> 140 line length - 895 violations
> 150 line length - 478 violations
>
>
> I think the 140 max line length might be the best option for us.
>
> On Thu, 15 Apr 2021 at 14:51, Ivan Daschinsky <iv...@gmail.com> wrote:
>>
>> But super long lines are a real problem while merging. It is super
>> inconvenient.
>> 120 chars is a good compromise.
>>
>> чт, 15 апр. 2021 г. в 14:39, Zhenya Stanilovsky
>> <arzamas123@mail.ru.invalid
>> >:
>>
>> >
>> > Python is not so verbose as java )
>> > +1 for 140
>> >
>> > >Hi!
>> > >Personally, I suppose that 120 chars per line is OK. Moreover, many
>> > >codestyles suggests less chars per line.
>> > >For example PEP8 recommends 80 (but we use 120 in pyignite and flake8
>> > >codestyle checks it). Google java codestyle insists on 100.
>> > >
>> > >More than 120 chars is too long as for me and is not convenient for
>> > > 3-way
>> > >merges.
>> > >
>> > >чт, 15 апр. 2021 г. в 12:28, Nikolay Izhikov < nizhikov@apache.org >:
>> > >
>> > >> Hello, Ilya.
>> > >>
>> > >> Thanks for the feedback.
>> > >>
>> > >> 140 characters is fine for me.
>> > >>
>> > >> > 15 апр. 2021 г., в 12:25, Ilya Kasnacheev <
>> > >> > ilya.kasnacheev@gmail.com
>> > >
>> > >> написал(а):
>> > >> >
>> > >> > Hello!
>> > >> >
>> > >> > Please find attached the distribution of line lengths in the
>> > >> > project,
>> > in
>> > >> the form of (count, line length).
>> > >> >
>> > >> > I think that we can enforce a hard limit of 140 chars per line. I
>> > think
>> > >> that having longer lines is excessive and does not benefit
>> > >> readability.
>> > >> >
>> > >> > Having a limit of 150 or 180 does not give us much since there's
>> > >> > still
>> > >> a long tail which has to be fixed.
>> > >> >
>> > >> > Regards,
>> > >> > --
>> > >> > Ilya Kasnacheev
>> > >> >
>> > >> >
>> > >> > чт, 15 апр. 2021 г. в 11:30, Nikolay Izhikov < nizhikov@apache.org
>> > >> > >:
>> > >> > Hello, Igniters.
>> > >> >
>> > >> > Right now, we have a code style rule [1] - the line should fit in
>> > >> > 120
>> > >> characters.
>> > >> > But, this rule violated in many and many places through code.
>> > >> > I have a plan to add a check style rule to force maximum line
>> > >> > length.
>> > >> >
>> > >> > For me, personally, 120 characters a bit old-fashioned
>> > >> > restriction.
>> > >> > Should we increase the maximum line length to 150 or even 180
>> > characters?
>> > >> >
>> > >> > [1]
>> > https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines
>> > >> > <linelengths.txt>
>> > >>
>> > >>
>> > >--
>> > >Sincerely yours, Ivan Daschinskiy
>> >
>> >
>> >
>> >
>>
>>
>>
>> --
>> Sincerely yours, Ivan Daschinskiy
>
--
Best regards,
Ivan Pavlukhin
Re: Re[2]: [DISCUSSION] MaxLineLength checkstyle rule
Posted by Maxim Muzafarov <mm...@apache.org>.
Folks,
I've briefly checked the total amount of the max length violations:
120 line length - 5540 violations
130 line length - 1891 violations
140 line length - 895 violations
150 line length - 478 violations
I think the 140 max line length might be the best option for us.
On Thu, 15 Apr 2021 at 14:51, Ivan Daschinsky <iv...@gmail.com> wrote:
>
> But super long lines are a real problem while merging. It is super
> inconvenient.
> 120 chars is a good compromise.
>
> чт, 15 апр. 2021 г. в 14:39, Zhenya Stanilovsky <arzamas123@mail.ru.invalid
> >:
>
> >
> > Python is not so verbose as java )
> > +1 for 140
> >
> > >Hi!
> > >Personally, I suppose that 120 chars per line is OK. Moreover, many
> > >codestyles suggests less chars per line.
> > >For example PEP8 recommends 80 (but we use 120 in pyignite and flake8
> > >codestyle checks it). Google java codestyle insists on 100.
> > >
> > >More than 120 chars is too long as for me and is not convenient for 3-way
> > >merges.
> > >
> > >чт, 15 апр. 2021 г. в 12:28, Nikolay Izhikov < nizhikov@apache.org >:
> > >
> > >> Hello, Ilya.
> > >>
> > >> Thanks for the feedback.
> > >>
> > >> 140 characters is fine for me.
> > >>
> > >> > 15 апр. 2021 г., в 12:25, Ilya Kasnacheev < ilya.kasnacheev@gmail.com
> > >
> > >> написал(а):
> > >> >
> > >> > Hello!
> > >> >
> > >> > Please find attached the distribution of line lengths in the project,
> > in
> > >> the form of (count, line length).
> > >> >
> > >> > I think that we can enforce a hard limit of 140 chars per line. I
> > think
> > >> that having longer lines is excessive and does not benefit readability.
> > >> >
> > >> > Having a limit of 150 or 180 does not give us much since there's still
> > >> a long tail which has to be fixed.
> > >> >
> > >> > Regards,
> > >> > --
> > >> > Ilya Kasnacheev
> > >> >
> > >> >
> > >> > чт, 15 апр. 2021 г. в 11:30, Nikolay Izhikov < nizhikov@apache.org >:
> > >> > Hello, Igniters.
> > >> >
> > >> > Right now, we have a code style rule [1] - the line should fit in 120
> > >> characters.
> > >> > But, this rule violated in many and many places through code.
> > >> > I have a plan to add a check style rule to force maximum line length.
> > >> >
> > >> > For me, personally, 120 characters a bit old-fashioned restriction.
> > >> > Should we increase the maximum line length to 150 or even 180
> > characters?
> > >> >
> > >> > [1]
> > https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines
> > >> > <linelengths.txt>
> > >>
> > >>
> > >--
> > >Sincerely yours, Ivan Daschinskiy
> >
> >
> >
> >
>
>
>
> --
> Sincerely yours, Ivan Daschinskiy
Re: Re[2]: [DISCUSSION] MaxLineLength checkstyle rule
Posted by Ivan Daschinsky <iv...@gmail.com>.
But super long lines are a real problem while merging. It is super
inconvenient.
120 chars is a good compromise.
чт, 15 апр. 2021 г. в 14:39, Zhenya Stanilovsky <arzamas123@mail.ru.invalid
>:
>
> Python is not so verbose as java )
> +1 for 140
>
> >Hi!
> >Personally, I suppose that 120 chars per line is OK. Moreover, many
> >codestyles suggests less chars per line.
> >For example PEP8 recommends 80 (but we use 120 in pyignite and flake8
> >codestyle checks it). Google java codestyle insists on 100.
> >
> >More than 120 chars is too long as for me and is not convenient for 3-way
> >merges.
> >
> >чт, 15 апр. 2021 г. в 12:28, Nikolay Izhikov < nizhikov@apache.org >:
> >
> >> Hello, Ilya.
> >>
> >> Thanks for the feedback.
> >>
> >> 140 characters is fine for me.
> >>
> >> > 15 апр. 2021 г., в 12:25, Ilya Kasnacheev < ilya.kasnacheev@gmail.com
> >
> >> написал(а):
> >> >
> >> > Hello!
> >> >
> >> > Please find attached the distribution of line lengths in the project,
> in
> >> the form of (count, line length).
> >> >
> >> > I think that we can enforce a hard limit of 140 chars per line. I
> think
> >> that having longer lines is excessive and does not benefit readability.
> >> >
> >> > Having a limit of 150 or 180 does not give us much since there's still
> >> a long tail which has to be fixed.
> >> >
> >> > Regards,
> >> > --
> >> > Ilya Kasnacheev
> >> >
> >> >
> >> > чт, 15 апр. 2021 г. в 11:30, Nikolay Izhikov < nizhikov@apache.org >:
> >> > Hello, Igniters.
> >> >
> >> > Right now, we have a code style rule [1] - the line should fit in 120
> >> characters.
> >> > But, this rule violated in many and many places through code.
> >> > I have a plan to add a check style rule to force maximum line length.
> >> >
> >> > For me, personally, 120 characters a bit old-fashioned restriction.
> >> > Should we increase the maximum line length to 150 or even 180
> characters?
> >> >
> >> > [1]
> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines
> >> > <linelengths.txt>
> >>
> >>
> >--
> >Sincerely yours, Ivan Daschinskiy
>
>
>
>
--
Sincerely yours, Ivan Daschinskiy