You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/03 14:49:21 UTC

[GitHub] [spark] MaxGekk commented on a change in pull request #27732: [SPARK-30984][SS]Add UI test for Structured Streaming UI

MaxGekk commented on a change in pull request #27732: [SPARK-30984][SS]Add UI test for Structured Streaming UI
URL: https://github.com/apache/spark/pull/27732#discussion_r387066658
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/ui/UIUtils.scala
 ##########
 @@ -57,4 +62,16 @@ private[ui] object UIUtils {
       query.exception.map(_ => "FAILED").getOrElse("FINISHED")
     }
   }
+
+  private val progressTimestampFormat = new ThreadLocal[SimpleDateFormat]() {
+    override def initialValue(): SimpleDateFormat = {
+      val format = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'") // ISO8601
 
 Review comment:
   Any particular reasons for using SimpleDateFormat instead of DateTimeFormatter? Just in case, would it possible to use `TimestampFormatter` here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org