You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/05/16 09:24:43 UTC
[GitHub] [lucene] mocobeta opened a new pull request, #893: LUCENE-10531: Run scripts test nightly only
mocobeta opened a new pull request, #893:
URL: https://github.com/apache/lucene/pull/893
Mark `TestScripts` as `@Nightly` and add an Actions workflow for distribution tests that runs all distribution tests including nightly tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873520231
##########
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##########
@@ -47,6 +52,19 @@ public abstract class AbstractLuceneDistributionTest extends RandomizedTest {
/** Resolved and validated {@link #DISTRIBUTION_PROPERTY}. */
private static Path distributionPath;
+ // --------------------------------------------------------------------
+ // Test groups, system properties and other annotations modifying tests
+ // --------------------------------------------------------------------
+
+ public static final String SYSPROP_NIGHTLY = "tests.nightly";
+
+ /** Annotation for tests that should only be run during nightly builds. */
+ @Documented
+ @Inherited
+ @Retention(RetentionPolicy.RUNTIME)
+ @TestGroup(enabled = false, sysProperty = SYSPROP_NIGHTLY)
+ public @interface Nightly {}
Review Comment:
Off-the-shelf `com.carrotsearch.randomizedtesting.annotations.Nightly` would be okay (`tests.nightly` system property is used for the test group [as default](https://github.com/randomizedtesting/randomizedtesting/blob/8be8a09e3b3bf1a57947d5367a1afe68322ac4dc/randomized-runner/src/main/java/com/carrotsearch/randomizedtesting/annotations/TestGroup.java#L55)), but I re-defined `Nightly` annotation here as `LuceneTestCase` does so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873565003
##########
.github/workflows/hunspell.yml:
##########
@@ -28,9 +28,9 @@ jobs:
with:
path: |
~/.gradle/caches
- key: ${{ runner.os }}-gradle-solrj-${{ hashFiles('versions.lock') }}
+ key: ${{ runner.os }}-gradle-hunspell-${{ hashFiles('versions.lock') }}
restore-keys: |
- ${{ runner.os }}-gradle-solrj-
+ ${{ runner.os }}-gradle-hunspell-
Review Comment:
While we are here, I think this can be also fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #893: LUCENE-10531: Add @RequiresGUI test group for GUI tests
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128610332
Increase the timeout, maybe? Windows boxes on github are slow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
dweiss commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873545503
##########
.github/workflows/distribution.yml:
##########
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+ branches:
+ - 'main'
+ paths:
Review Comment:
I think this should be triggered by all paths, not just those. under the distribution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run GUI tests on CI only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873963691
##########
lucene/distribution.tests/build.gradle:
##########
@@ -50,10 +50,15 @@ test {
jvmArgumentProviders.add(new CommandLineArgumentProvider() {
@Override
Iterable<String> asArguments() {
- return [
+ var args = [
"-Dlucene.distribution.dir=${configurations.binaryDistribution.singleFile.absolutePath }",
"-Dlucene.distribution.version=${project.version}"
]
+ if (isCIBuild) {
+ // force to run GUI tests
+ args += ["-Dtests.gui=true"]
+ }
Review Comment:
I simply use `isCIBuild` variable that was introduced in #890; this might be hacky?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873784334
##########
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##########
@@ -47,6 +52,19 @@ public abstract class AbstractLuceneDistributionTest extends RandomizedTest {
/** Resolved and validated {@link #DISTRIBUTION_PROPERTY}. */
private static Path distributionPath;
+ // --------------------------------------------------------------------
+ // Test groups, system properties and other annotations modifying tests
+ // --------------------------------------------------------------------
+
+ public static final String SYSPROP_NIGHTLY = "tests.nightly";
+
+ /** Annotation for tests that should only be run during nightly builds. */
+ @Documented
+ @Inherited
+ @Retention(RetentionPolicy.RUNTIME)
+ @TestGroup(enabled = false, sysProperty = SYSPROP_NIGHTLY)
+ public @interface Nightly {}
Review Comment:
@dweiss there will be lots of retries to make it work on both Linux shell and Windows command (I don't have other ideas to test Actions); I think "Unsubscribe" this PR is recommended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #893: LUCENE-10531: Add @RequiresGUI test group for GUI tests
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1129612104
I'd apply this to 9x as well since it'll ease backports of other things/ decrease the potential of a conflict in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #893: LUCENE-10531: Add @RequiresGUI test group for GUI tests
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128601383
up to you, entirely. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #893: LUCENE-10531: Add @RequiresGUI test group for GUI tests
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128664466
sorry couldn't resist.
"Build Duke"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run GUI tests on CI only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873987904
##########
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##########
@@ -47,6 +52,19 @@ public abstract class AbstractLuceneDistributionTest extends RandomizedTest {
/** Resolved and validated {@link #DISTRIBUTION_PROPERTY}. */
private static Path distributionPath;
+ // --------------------------------------------------------------------
+ // Test groups, system properties and other annotations modifying tests
+ // --------------------------------------------------------------------
+
+ public static final String SYSPROP_NIGHTLY = "tests.nightly";
+
+ /** Annotation for tests that should only be run during nightly builds. */
+ @Documented
+ @Inherited
+ @Retention(RetentionPolicy.RUNTIME)
+ @TestGroup(enabled = false, sysProperty = SYSPROP_NIGHTLY)
+ public @interface Nightly {}
Review Comment:
I also corrected the pull request description to reflect the renaming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #893: LUCENE-10531: Run GUI tests on CI only
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128054906
The duke is awesome (as are the others on your site)!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #893: LUCENE-10531: Add @RequiresGUI test group for GUI tests
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128612813
I increased the timeout to 120 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta merged pull request #893: LUCENE-10531: Add @RequiresGUI test group for GUI tests
Posted by GitBox <gi...@apache.org>.
mocobeta merged PR #893:
URL: https://github.com/apache/lucene/pull/893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1127470140
The added workflow takes 3 minutes on ubuntu-latest, and it takes 5 minutes on macos-latest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1127771394
This worked on Windows VM - looks fairly slow (the whole workflow takes 7.5 minutes) as compared to Ubuntu (3 minutes) though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873578148
##########
.github/workflows/distribution.yml:
##########
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+ branches:
+ - 'main'
+ paths:
+ - '.github/workflows/distribution.yml'
+ - 'lucene/distribution/**'
+ - 'lucene/distribution.tests/**'
+
+jobs:
+ test:
+ name: Run distribution nightly tests
+
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os: [ubuntu-latest, macos-latest]
+
+ steps:
+ - uses: actions/checkout@v2
+ - name: Set up JDK
+ uses: actions/setup-java@v2
+ with:
+ distribution: 'temurin'
+ java-version: 17
+ java-package: jdk
+ - name: Grant execute permission for gradlew
+ run: chmod +x gradlew
Review Comment:
It worked without the grant step; I removed it from all workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #893: LUCENE-10531: Add @RequiresGUI test group for GUI tests
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128605453
I'll update the directory name later.
This time, the test timed out on Windows... I think this could occasionally happen :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #893: LUCENE-10531: Add @RequiresGUI test group for GUI tests
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128676036
Passed all checks and I think we've done all I wanted to do here - we disabled the GUI test in the mandatory test runs, instead, we enabled it on all CI runs (Jenkins, GH Actions) and the smoke tester.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
dweiss commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873730908
##########
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##########
@@ -47,6 +52,19 @@ public abstract class AbstractLuceneDistributionTest extends RandomizedTest {
/** Resolved and validated {@link #DISTRIBUTION_PROPERTY}. */
private static Path distributionPath;
+ // --------------------------------------------------------------------
+ // Test groups, system properties and other annotations modifying tests
+ // --------------------------------------------------------------------
+
+ public static final String SYSPROP_NIGHTLY = "tests.nightly";
+
+ /** Annotation for tests that should only be run during nightly builds. */
+ @Documented
+ @Inherited
+ @Retention(RetentionPolicy.RUNTIME)
+ @TestGroup(enabled = false, sysProperty = SYSPROP_NIGHTLY)
+ public @interface Nightly {}
Review Comment:
Thanks for cleaning up those workflow files, @mocobeta ! I don't haven that much experience with github actions so it's definitely cruft that accumulated over time.
Adding a new test group itself (disabled by default) doesn't require any special actions. If we want to run it on nightly runs then yes - jenkins would have to be configured properly for this... Alternatively, the value of the property triggering the test group could be computed inside gradle scripts (much like Uwe recently modified the errorprone to run on CI servers). Does this sound better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
dweiss commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873544355
##########
.github/workflows/distribution.yml:
##########
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+ branches:
+ - 'main'
+ paths:
+ - '.github/workflows/distribution.yml'
+ - 'lucene/distribution/**'
+ - 'lucene/distribution.tests/**'
+
+jobs:
+ test:
+ name: Run distribution nightly tests
+
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os: [ubuntu-latest, macos-latest]
+
+ steps:
+ - uses: actions/checkout@v2
+ - name: Set up JDK
+ uses: actions/setup-java@v2
+ with:
+ distribution: 'temurin'
+ java-version: 17
+ java-package: jdk
+ - name: Grant execute permission for gradlew
+ run: chmod +x gradlew
Review Comment:
this should not be needed - if it is, it's a bug. git will restore file permissions correctly from the repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873579845
##########
.github/workflows/distribution.yml:
##########
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+ branches:
+ - 'main'
+ paths:
+ - '.github/workflows/distribution.yml'
+ - 'lucene/distribution/**'
+ - 'lucene/distribution.tests/**'
+
+jobs:
+ test:
+ name: Run distribution nightly tests
+
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os: [ubuntu-latest, macos-latest]
+
+ steps:
+ - uses: actions/checkout@v2
+ - name: Set up JDK
+ uses: actions/setup-java@v2
+ with:
+ distribution: 'temurin'
+ java-version: 17
+ java-package: jdk
+ - name: Grant execute permission for gradlew
+ run: chmod +x gradlew
+ - uses: actions/cache@v2
+ with:
+ path: |
+ ~/.gradle/caches
+ key: ${{ runner.os }}-gradle-solrj-${{ hashFiles('versions.lock') }}
Review Comment:
This is fixed in https://github.com/apache/lucene/pull/893/commits/0176c98062d45c093cdfbddd8bb99bcd7f506ad7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1127809075
surprisingly, it worked on the first try... I'll open this and try to address https://github.com/apache/lucene/pull/893#discussion_r873546269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873570217
##########
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##########
@@ -47,6 +52,19 @@ public abstract class AbstractLuceneDistributionTest extends RandomizedTest {
/** Resolved and validated {@link #DISTRIBUTION_PROPERTY}. */
private static Path distributionPath;
+ // --------------------------------------------------------------------
+ // Test groups, system properties and other annotations modifying tests
+ // --------------------------------------------------------------------
+
+ public static final String SYSPROP_NIGHTLY = "tests.nightly";
+
+ /** Annotation for tests that should only be run during nightly builds. */
+ @Documented
+ @Inherited
+ @Retention(RetentionPolicy.RUNTIME)
+ @TestGroup(enabled = false, sysProperty = SYSPROP_NIGHTLY)
+ public @interface Nightly {}
Review Comment:
Right... but I think if we introduce a new test group and system property, Jenkins and smoke tester configurations also need to be tweaked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
dweiss commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873546269
##########
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##########
@@ -47,6 +52,19 @@ public abstract class AbstractLuceneDistributionTest extends RandomizedTest {
/** Resolved and validated {@link #DISTRIBUTION_PROPERTY}. */
private static Path distributionPath;
+ // --------------------------------------------------------------------
+ // Test groups, system properties and other annotations modifying tests
+ // --------------------------------------------------------------------
+
+ public static final String SYSPROP_NIGHTLY = "tests.nightly";
+
+ /** Annotation for tests that should only be run during nightly builds. */
+ @Documented
+ @Inherited
+ @Retention(RetentionPolicy.RUNTIME)
+ @TestGroup(enabled = false, sysProperty = SYSPROP_NIGHTLY)
+ public @interface Nightly {}
Review Comment:
I would rename the annotation "RequiresGui" or something like this. It really is not a nightly test - just one that has additional requirements/ side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873759662
##########
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##########
@@ -47,6 +52,19 @@ public abstract class AbstractLuceneDistributionTest extends RandomizedTest {
/** Resolved and validated {@link #DISTRIBUTION_PROPERTY}. */
private static Path distributionPath;
+ // --------------------------------------------------------------------
+ // Test groups, system properties and other annotations modifying tests
+ // --------------------------------------------------------------------
+
+ public static final String SYSPROP_NIGHTLY = "tests.nightly";
+
+ /** Annotation for tests that should only be run during nightly builds. */
+ @Documented
+ @Inherited
+ @Retention(RetentionPolicy.RUNTIME)
+ @TestGroup(enabled = false, sysProperty = SYSPROP_NIGHTLY)
+ public @interface Nightly {}
Review Comment:
Thanks for your suggestion. I'd like to run this test on the Jenkis Server with other nightly tests, and also in the smoke tester before every release.
I'll look at the alternatives once I will have made it work on Windows VM (currently it works only on Unix-like shells, of course).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #893: LUCENE-10531: Run GUI tests on CI only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1127993496
while waiting for review... here's `Randomizedtesting Luke`, rough-and-tumble boy (based on the "Tumble Duke") - the latest addition to my [fan-art collection](https://github.com/mocobeta/unofficial-lucene-mascot)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873784334
##########
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##########
@@ -47,6 +52,19 @@ public abstract class AbstractLuceneDistributionTest extends RandomizedTest {
/** Resolved and validated {@link #DISTRIBUTION_PROPERTY}. */
private static Path distributionPath;
+ // --------------------------------------------------------------------
+ // Test groups, system properties and other annotations modifying tests
+ // --------------------------------------------------------------------
+
+ public static final String SYSPROP_NIGHTLY = "tests.nightly";
+
+ /** Annotation for tests that should only be run during nightly builds. */
+ @Documented
+ @Inherited
+ @Retention(RetentionPolicy.RUNTIME)
+ @TestGroup(enabled = false, sysProperty = SYSPROP_NIGHTLY)
+ public @interface Nightly {}
Review Comment:
@dweiss there will be lots of retries to make it work on both Linux shell and Windows command (I don't have other ideas to test Actions); I think "Unscribe" this PR is recommended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #893: LUCENE-10531: Add @RequiresGUI test group for GUI tests
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128599401
How about renaming the action's directory name `.github/actions/yarn-caches/` to `.github/actions/gradle-caches/`? @dweiss
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873580622
##########
.github/workflows/distribution.yml:
##########
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+ branches:
+ - 'main'
+ paths:
Review Comment:
I removed the entire `paths` filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #893: LUCENE-10531: Add @RequiresGUI test group for GUI tests
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1129641582
Ok I'll backport it to the 9x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #893: LUCENE-10531: Add @RequiresGUI test group for GUI tests
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128594358
The previous CI run result looks good to me. I also enabled GUI tests in the smoke tester.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #893: LUCENE-10531: Add @RequiresGUI test group for GUI tests
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128601991
The yarn-caches name is wrong - it's something else I was working (!).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
dweiss commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873544584
##########
.github/workflows/distribution.yml:
##########
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+ branches:
+ - 'main'
+ paths:
+ - '.github/workflows/distribution.yml'
+ - 'lucene/distribution/**'
+ - 'lucene/distribution.tests/**'
+
+jobs:
+ test:
+ name: Run distribution nightly tests
+
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os: [ubuntu-latest, macos-latest]
+
+ steps:
+ - uses: actions/checkout@v2
+ - name: Set up JDK
+ uses: actions/setup-java@v2
+ with:
+ distribution: 'temurin'
+ java-version: 17
+ java-package: jdk
+ - name: Grant execute permission for gradlew
+ run: chmod +x gradlew
+ - uses: actions/cache@v2
+ with:
+ path: |
+ ~/.gradle/caches
+ key: ${{ runner.os }}-gradle-solrj-${{ hashFiles('versions.lock') }}
Review Comment:
solrj in the key and keys below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run GUI tests on CI only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873972923
##########
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##########
@@ -47,6 +52,19 @@ public abstract class AbstractLuceneDistributionTest extends RandomizedTest {
/** Resolved and validated {@link #DISTRIBUTION_PROPERTY}. */
private static Path distributionPath;
+ // --------------------------------------------------------------------
+ // Test groups, system properties and other annotations modifying tests
+ // --------------------------------------------------------------------
+
+ public static final String SYSPROP_NIGHTLY = "tests.nightly";
+
+ /** Annotation for tests that should only be run during nightly builds. */
+ @Documented
+ @Inherited
+ @Retention(RetentionPolicy.RUNTIME)
+ @TestGroup(enabled = false, sysProperty = SYSPROP_NIGHTLY)
+ public @interface Nightly {}
Review Comment:
@dweiss I renamed the annotation (test group) as suggested, added `tests.gui` system property for the test group, and made the sysprop forcibly set to true on CI builds - does this change make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a diff in pull request #893: LUCENE-10531: Run GUI tests on CI only
Posted by GitBox <gi...@apache.org>.
dweiss commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r874090898
##########
lucene/distribution.tests/build.gradle:
##########
@@ -50,10 +50,15 @@ test {
jvmArgumentProviders.add(new CommandLineArgumentProvider() {
@Override
Iterable<String> asArguments() {
- return [
+ var args = [
"-Dlucene.distribution.dir=${configurations.binaryDistribution.singleFile.absolutePath }",
"-Dlucene.distribution.version=${project.version}"
]
+ if (isCIBuild) {
Review Comment:
I would move this to be a dynamically computed default value in randomization.gradle.
##########
.github/workflows/distribution.yml:
##########
@@ -0,0 +1,61 @@
+name: Distribution tests
+
+on:
+ pull_request:
+ branches:
+ - 'main'
+
+jobs:
+ test:
+ name: Run distribution tests
+
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ # we run the distribution tests on all major OSs.
+ os: [ubuntu-latest, macos-latest, windows-latest]
+
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Set up JDK
+ uses: actions/setup-java@v2
+ with:
+ distribution: 'temurin'
+ java-version: 17
+ java-package: jdk
+
+ - name: Save/Restore gradle cache (${{ matrix.os }})
+ uses: actions/cache@v2
+ if: ${{ startsWith(matrix.os, 'windows') }}
+ with:
+ path: |
+ %HOMEDRIVE%%HOMEPATH%\.gradle\caches
+ key: ${{ runner.os }}-gradle-distribution-${{ hashFiles('versions.lock') }}
+ restore-keys: |
+ ${{ runner.os }}-gradle-distribution-
+ ${{ runner.os }}-gradle-
+ - name: Save/Restore gradle cache (${{ matrix.os }})
+ uses: actions/cache@v2
+ if: ${{ ! startsWith(matrix.os, 'windows') }}
+ with:
+ path: |
+ ~/.gradle/caches
+ key: ${{ runner.os }}-gradle-distribution-${{ hashFiles('versions.lock') }}
+ restore-keys: |
+ ${{ runner.os }}-gradle-distribution-
+ ${{ runner.os }}-gradle-
+
+ - name: Initialize gradle settings (${{ matrix.os }})
+ if: ${{ startsWith(matrix.os, 'windows') }}
+ run: .\gradlew localSettings
+ - name: Initialize gradle settings (${{ matrix.os }})
+ if: ${{ ! startsWith(matrix.os, 'windows') }}
+ run: ./gradlew localSettings
+
+ - name: Run all distribution tests including GUI tests (${{ matrix.os }})
+ if: ${{ startsWith(matrix.os, 'windows') }}
+ run: .\gradlew -p "lucene\distribution.tests" test
Review Comment:
I think windows runs with powershell and ./gradlew should work on both platforms, actually (no need for duplication). Carrot2 runs on both from a single workflow definition:
https://github.com/carrot2/carrot2/actions/runs/2329856785/workflow
https://github.com/carrot2/carrot2/actions/runs/2329856785
The paths for gradle can contain slashes on Windows as well.
##########
.github/workflows/hunspell.yml:
##########
@@ -22,15 +22,13 @@ jobs:
distribution: 'temurin'
java-version: 17
java-package: jdk
- - name: Grant execute permission for gradlew
- run: chmod +x gradlew
- uses: actions/cache@v2
with:
path: |
~/.gradle/caches
- key: ${{ runner.os }}-gradle-solrj-${{ hashFiles('versions.lock') }}
Review Comment:
The key here should be identical so that cache is reused for the same os+versions.lock - the infix is not required, actually - it makes the cache miss files that would otherwise be reused across jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873553627
##########
.github/workflows/distribution.yml:
##########
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+ branches:
+ - 'main'
+ paths:
+ - '.github/workflows/distribution.yml'
+ - 'lucene/distribution/**'
+ - 'lucene/distribution.tests/**'
+
+jobs:
+ test:
+ name: Run distribution nightly tests
+
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os: [ubuntu-latest, macos-latest]
+
+ steps:
+ - uses: actions/checkout@v2
+ - name: Set up JDK
+ uses: actions/setup-java@v2
+ with:
+ distribution: 'temurin'
+ java-version: 17
+ java-package: jdk
+ - name: Grant execute permission for gradlew
+ run: chmod +x gradlew
Review Comment:
I copied it from .github/workflows/hunspell.yml and ./github/workflows/gradle-precommit.yml; I'm not sure but it was needed at that time?
I'll remove this step and then rerun the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run scripts test nightly only
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873556370
##########
.github/workflows/distribution.yml:
##########
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+ branches:
+ - 'main'
+ paths:
+ - '.github/workflows/distribution.yml'
+ - 'lucene/distribution/**'
+ - 'lucene/distribution.tests/**'
+
+jobs:
+ test:
+ name: Run distribution nightly tests
+
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os: [ubuntu-latest, macos-latest]
+
+ steps:
+ - uses: actions/checkout@v2
+ - name: Set up JDK
+ uses: actions/setup-java@v2
+ with:
+ distribution: 'temurin'
+ java-version: 17
+ java-package: jdk
+ - name: Grant execute permission for gradlew
+ run: chmod +x gradlew
+ - uses: actions/cache@v2
+ with:
+ path: |
+ ~/.gradle/caches
+ key: ${{ runner.os }}-gradle-solrj-${{ hashFiles('versions.lock') }}
Review Comment:
I overlooked it and it also remains in other workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #893: LUCENE-10531: Add @RequiresGUI test group for GUI tests
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1129442757
I'm merging this only to main - let me know if it's worth backporting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #893: LUCENE-10531: Add @RequiresGUI test group for GUI tests
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1133530902
We increased the timeout to 120 seconds, but the test still occasionally fails on Windows. I opened #917 to disable it on windows for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org