[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.

[GitBox <gi...@apache.org>]

ruanwenjun commented on PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#issuecomment-1250441968

   > > > But the UI page still will show the last EndTime, but re-run still running, not finish. So i think that we need to make sure that setEndTime(null) can take affect
   > > 
   > > 
   > > OK, but can we replace the field annotation with udpateWrapper or the global config FieldStrategy? Because if you just configure a field separately, it may be a hidden logic. WDYT? cc @ruanwenjun
   > 
   > i think that the global config FieldStratrgy should be better, but we need review all MybatisPlus updateById to make sure that the FiledStrategy.IGNORE can match all scenes
   
   It's not a good idea to use the `strategy` from MybatisPlus, we may use another ERM in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org